beanmo / json-find Goto Github PK

json-find.js line:197

function isObject(v) {
    return typeof(v) === 'object' && !isArray(v);
}

modify:

function isObject(v) {
    return typeof(v) === 'object' && !isArray(v) && v !== null;
}

Hi,
when trying to create an optimized build with create-react-app it fails throwing this error:

Failed to minify the code from this file:

        ./node_modules/json-find/json-find.js:17

So this line:
https://github.com/BeAnMo/json-find/blob/master/json-find.js#L17

let res2 = {
list: {
a:undefined,
blur:1
},
}
let doc = JsonFind(res2);
let is_private = doc.checkKey('is_private');
TypeError: Cannot convert undefined or null to object

Thanks for an awesome utility! I'm having an unexplained failure to find a certain key, though. In this example...

const doc1 = {
  "arr1": [
    {
      "arr2": [
        {
          "a": 1,
          "arrTarget": [
            {
              "b": 2
            },
            {
              "keyTarget": "target value"
            }
          ]
        }
      ]
    }
  ]
}

... jsonFind(doc1).findValues("keyTarget") returns an empty object. However, remove the object before the target object:

const doc2 = {
  "arr1": [
    {
      "arr2": [
        {
          "a": 1,
          "arrTarget": [
            {
              "keyTarget": "target value"
            }
          ]
        }
      ]
    }
  ]
}

... and it returns target value as expected. It also works when {"keyTarget": "target value"} is followed by another object.

[extractPaths mehtod ]: Why not return a null character when the field is not found, but return an error?
Because the data is dynamic, it cannot guarantee absolute integrity.