beedaddy / radiorec Goto Github PK

I do not know if this is really a mistake, but if you start radiorec.py without an argument, this will come out. I've tried to fix it but have not made it yet. Maybe you can find the issue

MacOSX 10.12.6 and Debian9 with python 3.6

Started as ./radiorec.py

without record or list

Traceback (most recent call last):
  File "./radiorec.py", line 161, in <module>
    main()
  File "./radiorec.py", line 158, in main
    args.func(args)
AttributeError: 'Namespace' object has no attribute 'func'

Trying to run with python 3.2.3 i got following problems:

sys.plaform is linux2, not the expected linux

After changing that to test sys.platform.startswith("linux") I get following error:

recthread = threading.Thread(target = record_worker, args = (stoprec, streamurl, target_dir, args), daemon = True)
TypeError: __init__() got an unexpected keyword argument 'daemon'

I created a patch to set the location of the settings.ini file. I would be glad if you would like to include it into your project.

https://github.com/gjelsas/radiorec

When trying to record a shoutcast stream, the radiorec script prints the following error. Tested on Debian Jessie using a shoutcast V1 stream.
Icecast-based streams work as expected.
Radiorec_error.txt

Hi there,

first off thanks for the great script!
Is there an option to set the id3 tag of the files being recorded?
I want to set them in order to distinguish between the different files in my player on my mobile phone.

Line 48 in radiorec.py could add another condition to compatible with OS X.

Hi there,

did you do anything in regards to re-connection handling? I couldn't really find anything in the code.
I'm not sure if urllib.request does something in these regards. So if the stream disconnects for whatever reason, the recording should not stop before the recording duration set.

Best regards,
J

Python 3.6.4 (v3.6.4:d48ecebad5, Dec 18 2017, 21:07:28)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.

./radiorec.py list
./radiorec.py record

the same error

Traceback (most recent call last):
  File "./Daten/Programme/radiorec-master/radiorec.py", line 162, in <module>
    main()
  File "./Daten/Programme/radiorec-master/radiorec.py", line 159, in main
    args.func(args)
  File "./Daten/Programme/radiorec-master/radiorec.py", line 130, in list
    settings = read_settings()
  File "./Daten/Programme/radiorec-master/radiorec.py", line 55, in read_settings
    + 'Application Support' + os.sep + 'radiorec'
TypeError: bad operand type for unary +: 'str'

I'm currently getting ValueError: I/O operation on closed file. when trying to record stations with m3u urls. With mp3-urls it works though.

It seems to be the code around line 126 where the Poolmanager requests the m3u url, and an empty value is stored in the value line in line 127.

I'm using mp3 urls right now, but this could be fixed easily I guess...