benbli / projecttwo Goto Github PK

Hey Ben,

Nice job on this assignment. I really really liked your introduction to your project, where you talked about your own experience and how it informed your application, especially your choice to design the UI as mobile-first. Also, I thought the animation on your home page was a nice touch!

I noticed that you wrote your application helper to have a bunch of different methods, and then included it in your application controller so you could presumably have access to all of those methods throughout your application. I would suggest that for specific methods, like the currency conversion ones, you include them in the model for the table, or whichever model you are generating the receipt from. Only because it is generally suggested to try and modularize your code as much as possible.

It looks like you have a bunch of js files and a bunch of scss files that don't have anything in them? I'd suggest maybe cleaning up anything that is just blank, or there because you used rails generate. Also, you have your RSpec folder set up, but I am not seeing any tests written. Not sure if I am just missing them, but maybe think about adding some in there, it'll looks super impressive to people looking at your code!

Overall, I think you thought all of this out really well and should be proud of your finished project!

Score: 2 - Meets expectations, great!