bencotti / ped Goto Github PK

When standard fields other than time and date are blackspaces, program crashes.

Crashes when blackspace is used for input.

find pr

Maybe some user validation would be helpful. Can consider using .isempty() to check for stray white spaces.

No standard format for ic/phone number field. Does not validate user input, able to put negative values for number, nric, blood type. Admin won't know an error is made on those fields (eg. phone number or wrong IC) on the spot. Can pose a serious security flaw.

Program crashes when a blank space is supplied after nric

When putting in the fields, the UG and program help provides different formats. It would be good to standardise to avoid confusion and unnecessary input from users (though that should be handled as well)

Program crashes if supplied with blackspace after nric

For add patient, when date is requested, it does not show the format required until it is put wrongly. One would assume if it was not specified in UG or Help that anything would be accepted. Similarly, under patient record, time is not specified. It is also not very practical to log in the seconds as it won't be physically accurate.

Features that are not optimized enough for target users - fast typing users.

Slow - canont use quickly, once one field has error need to restart.
Unable to quickly add essential details first and fill later.

Need to approve evertime a new patient is added, unable to automate. Essentially works the same way as how one would imagine a gui version to be.

Command crashes with used with two double spaces. Did not do validation check to see if valid string.

Certain error messages just inform the user something is wrong. Perhaps it could also dispay the actual command guide for that particular task.

Also error messages like the screenshot below are quite confusing. Input in wrong, but error is a wrong message.