benestar / ask-wikidata Goto Github PK

The tests pass when executing in the browser, see https://tools.wmflabs.org/bene/ask/test/qunit.html. However, at travis they fail: https://travis-ci.org/Benestar/ask-wikidata. The reason for this might be that the "arguments" keyword for all parameters passed to a function in javascript does not work there. See also https://github.com/Benestar/ask-wikidata/blob/master/test/test_ask.js#L55 and https://github.com/Benestar/ask-wikidata/blob/master/src/ask.js#L40

@Benestar, can you provide a very short overview of how ask-wikidata works? It would help for contributors to add new patterns. Specifically, how does the parseQuestion function in src/parser.js work with the patterns/*.json files to interpret the question, and what exactly does the handleParsed function in src/index.js do with the result?

You could either provide this as a high-level quick overview in the README, or add comments to the relevant lines in those functions and json files.

For example, the home page could say something like:

Type your question into the input box above and press enter. Or click one of the examples below:

• When was Elvis born?
• Where is the Eiffel tower?

And clicking the questions would automatically fill the search box and run the query.

When linking to a query, you need to put actual spaces in the fragment part of the URL. That's invalid per RfC 3986 and most editing tools cannot handle it.