The search can't find this: https://www.openstreetmap.org/node/4642112460

By the way, it's pretty complete as far as POIs go, so if you want to render more tags, that café is a good example to model from.

I find it helpful to have a dev mode in these redux, react apps with some extra logging and stuff to help figure out what's going on. I especially like redux-logger for figuring out all the actions that are firing as I first checkout how the app is working. See https://github.com/mpmckenna8/mapbox-maps/blob/action_logger/src/index.js#L34 for an example and let me know if it would be wanted to pull request or if there's a better way to do it or if you think this isn't necessary.

• Sort proptypes and all by alphabetical order
• add isRequired for required proptTypes
• Stricter eslint
• Break down components when possible

Follow up to the more general #25

• Add svgs to the sprites on Studio
• Swap markers for proper layers
• Click to set search location on POIs
• Drag to set start/end points. Follow those instructions
• Write reverse geocoding api-caller method to set place information and address of dropped pins

While dragging the pin the search field contains a loading icon and the search query string in the URL is /~__loading. After dropping it onto a building the search field contains the address of the building, but the URL does not change.

That results in the loading icon and a POI with the title __loading to appear when loading that URL.

Example URL: https://benmaps.fr/@6.696634,50.644408,15.06/+6.693082,50.643154/~__loading

User Story
Looking for an address, typing it on the search bar, entry.
I see the marker, right click on the marker to copy paste GPS coordinates.
Then, a click on the map makes the marker disappear. 'Where is my marker?'
While, as a user, I was just expecting the coordinates window to be closed.

But I would also expect a click on the map to keep the marker (as Google Maps does)

Sorry for the English grammar mistakes

This is something that we forgot to add to the map. I'd suggest placing it to the right of satellite view switcher instead of stacking it upwards!

If I want to modify the apartment # for instance or a typo in the cty field

https://github.com/benjamintd/mapbox-maps/blob/dfda321/src/styles/style.json specifies "sprite": "mapbox://sprites/benjamintd/cj2wkuwc000582spd6gz9cf00". This file doesn't seem to be accessible without your access token. This issue doesn't seem to exist with the glyphs file just below, it seems to have more liberal permissions.

Adding this file to the to the source distribution would probably be the best option here, but it's probably sufficient for now to just change the permissions to make it accessible to everyone.

Clicking on the map scale ( #29 ) should switch from metric to imperial. A similar option should be available for directions.

I would want to know if something is open. So a simple "is [open | closed] till [today | tomorrow | Mo-Su] [00-12]:[00-60]" would be appreciated. Furthermore I'd like to see table of opening hours.

For both a public holiday provider would make it more accurate. Though I couldn't find any free.

I hope I'm not the only one interested in this. Thanks!

Some shops and amenities from OSM have a brand:wikidata tag from which their logo could be pulled. The brand is an important part of many shop and amenity POIs.

Besides that the website is great

See https://github.com/mapbox/mapbox-gl-traffic

cc @aparlato

When screens are > 420px wide, use the current setting. Otherwise use the full width.

I'm hesitant to add another (paid) API on top of Mapbox, but it would be cool to provide images on searches other that those which have Wikidata tags.

See how to display and how to search Mapillary's data.

This would allow to display, and search through, the user's previously searched locations.

When searching for e.g. supermarket in benmaps a list of supermarkets near-by is the result. Would it be possible to display/highlight those in the map. It would be a huge improvement. Thanks!

When searching for small village the zoom does not feet the feature

If the project is run without Benjamin's mapbox api key in the .env file the request for the static image for the primary basemap will fail with https://api.mapbox.com/styles/v1/benjamintd/cj0szkyh5009i2slfhsmxhtni/static/-122.45920072674187,37.7712861641578,15.255089647198925/56x100@2x?access_token=pk.eyJ1IjoibXBtY2tlbm5hOCIsImEiOiJfYWx3RlJZIn0.v-vrWv_t1ytntvWpeePhgQ&attribution=false 404 (Not Found)

But since it's basically just the streets basemap we would just use that link and it will work for any mapbox api user. See https://github.com/mpmckenna8/mapbox-maps/blob/staticlinkfix/src/components/StyleSwitch.js#L32

I don't understand, Benmaps returns a blank screen with Firefox 68.0.1.

No problem with Chromium but i don't use it !

Thanks for BenMaps !

We should be able to visualize traffic on the streets and satellite maps.

Example: https://benjamintd.github.io/mapbox-maps/@-122.271101,39.138201,16.0

Required for sharing the URLs.

Here is additional information that might be useful:

• Add an elevation profile for bike directions (see this example)
• Add turn by turn instructions and traffic-on-route for car directions

As this grows into its own thing, maybe we should find an identity separate from Mapbox and the classic map interface everyone is used to.

We need a name, logo, palette, and style :)

One thing I find annoying about google maps when getting directions, especially on mobile is that there's often no clear way to toggle between the mapview and all of the map options. Especially while out using the routing feature. I think just having a nice max min button to hide and show all the stuff would be nice and make this usable even before turn by turn directions are added.

See https://mpmckenna8.github.io/mapbox-maps/ and enter a route to see an example of what I was thinking.

https://benjamintd.github.io/mapbox-maps/ redirects to https://www.benjamintd.com/mapbox-maps/ and then SSL is broken.

We should display and make alternative routes clickable, when they exist.

@mpmckenna8 started with a prototype on this:

^v on the left of the directions panel.

https://benmaps.fr/@0,0,16.00

Just back to the last location.

Either a left click or a right click is not removing the selected location!

Reproduce

1. Select a place from the search or use right click and select the coordinate
2. The location will be selected
3. Clicking on any other area should ideally remove the selected location - from the search and the marker.

Here is using right click:

One possible use for keeping the selection is to use it in directions: from or to. But we are not really used to this behaviour?

Marker hides clicked feature

Labels/names written in a right to left script like Arabic, Hebrew, Persian are not shown on the map. Take a look at Northern Africa, Arabian Peninsula, Israel and Iran here: https://benmaps.fr/@25.180060,29.601285,4.19
Might be related to the font you are using which might be lacking full UTF support

At any time, the URL should reflect what the user sees. This way, it becomes easy to share one's location or directions.

Some POIs show the phone number and website from contact:phone and contact:website tags from OSM, but some don't. Here is an example, where nothing is shown: https://benmaps.fr/@11.275137,53.700220,18.33/+11.274755,53.700284/~Seehotel

depending on the state, we should populate the 'from' field when both are empty, the empty field when only one if free, or mask the choice when both fields are populated.

Add a button to center the map on the user's location at the bottom right

As a user, after having triggered directions, I'd like to modify the destination point by clicking and dragging the pin =D

Hi Benjamin,
The first address in the readme is wrong:
https://benjamintd.github.io/mapbox-maps/

Place search: picture attribution missing

In the bike route altitude graph, make it so if you hover along the graph it shows you the equivalent point in the route map, that way you know exactly where the peaks and slopes are.

... And display the result

Some options should be available on right-click:

• directions from here
• directions to here
• what's here ? (returning the reverse geocoding result and lon, lat copyable to the clipboard)

Since #41 landed we can add share buttons to copy the url to clipboard when needed.

Using this model, test other components and the Redux logic.

• Google Maps cartography
• Usability
• Technologies
• Open data