Giter VIP home page Giter VIP logo

Comments (9)

antony avatar antony commented on August 25, 2024

is it an error or a warning?

a bit annoying, but if we want to publish the banner as a WebComponent too, we need to include that. I'm not sure there is a way around it.

from gdpr-cookie-consent-banner.

BigBuckBunny avatar BigBuckBunny commented on August 25, 2024

Hi,

Sorry it was a warning.

Might I suggest appending to your Svelte example the modification to svelte.config.js in the Readme.md.

Thanks for the update,

Pierre

from gdpr-cookie-consent-banner.

antony avatar antony commented on August 25, 2024

It says in the warning what you need to do, so not sure this is necessary.

I feel like this is an issue within the way Svelte works, since you don't actually want custom element output in a regular svelte project.

the compiler should know that you're seeing the options tag in a project dependency, not the main project, and not warn.

i'll raise an issue with Svelte (or you can)

from gdpr-cookie-consent-banner.

stalkerg avatar stalkerg commented on August 25, 2024

@antony did you make an issue?

from gdpr-cookie-consent-banner.

antony avatar antony commented on August 25, 2024

from gdpr-cookie-consent-banner.

Cayllen avatar Cayllen commented on August 25, 2024

Not sure if this is related but I cannot use the cookie banner because of the following issue:
image

from gdpr-cookie-consent-banner.

Cayllen avatar Cayllen commented on August 25, 2024

Actually solved, seems I used an old version of sveltekit

from gdpr-cookie-consent-banner.

belte42 avatar belte42 commented on August 25, 2024

Still shows an error on latest sveltekit "@sveltejs/kit": "^2.5.0".
The problem with this is once I add

compilerOptions: {
customElement: true,
},

pre-rendering with static adapter kit breaks and CSS is no longer loaded from Svelte pages and components.

from gdpr-cookie-consent-banner.

antony avatar antony commented on August 25, 2024

@belte42 because you're trying to mark your entire project as a custom element, which won't work. The "did you forget to add" customElement: true warning is just a warning, and can be safely ignored.

If it bothers you a lot, please raise a SvelteKit issue and I'll discuss it with the others and see if I can implement a fix - but at the moment, I don't have time to do it.

from gdpr-cookie-consent-banner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.