Comments (3)
CptCrispyCrunchy
commented on August 25, 2024
I'll second that. Especially as it is part of being GDPR-compliant (which is stated in the Readme). A simple true/false value representing the consent given attached to the custom event (like on:analytics) should suffice to easily run opt-out functions to revoke cookies.
An even neater solution would just notify on choice changes. When backwards-compatibility should be kept, a different custom event should better be dispatched, e.g. on:analytics-opt-out, so that all the opt-in code can be left untouched. Let me know if that solution is acceptable and I will create a PR.
I would appreciate this change very much!
Here is a simple proposal (I also changed the cookie settings close button to submit the changes directly):
commit
from gdpr-cookie-consent-banner.
antony
commented on August 25, 2024
The way this is GDPR compliant is that you don't run any sort of non-gdpr compliant code until the user consents to those types of code, by clicking Accept. If they Reject or ignore, then you don't do anything.
That being said I'm not averse to events being run when the choices change. Feel free to open a PR and I will review.
from gdpr-cookie-consent-banner.
kratos-digital
commented on August 25, 2024
Ok, I will create PR as soon as I can
from gdpr-cookie-consent-banner.
Related Issues (20)
- gdpr-cookie-consent-banner with SvelteKit HOT 6
- Suggestion: Icon button do not have an accessible name HOT 2
- WebComponent packaging HOT 1
- Missing TypeScript declaration HOT 1
- aria-label part of button label HOT 5
- This doesn't work with svelte/astro HOT 2
- Cannot use this in Svelte with Type: Module when running in development mode HOT 2
- update to ^10.0.0 in Sveltekit project: minor TS error HOT 2
- Ability to hide Edit Cookies button; possible to add prop? HOT 2
- svelte 4 support
- Property for entire Config HOT 1
- Suggestion: Disable tabbing behind the cookie banner HOT 2
- svelte:options customElement HOT 9
- How to change the background color of checked toggles? HOT 1
- Add `canRejectCookies` to documentation
- How can i add the props (if i want to use custom props) to the banner ? HOT 2
- Add pointer cursor to toggles HOT 1
- Change transition speed for settings modal HOT 3
- HTML / Web Components addEventListener can't work
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gdpr-cookie-consent-banner.