bgaze / bootstrap-form Goto Github PK

I couldn't tell if this was intentional, but every other input creates a Name and an ID attribute when you give a name argument, but @hidden only creates the name attribute.

Hello,

first: thank you for this useful library! It really simplifies things.

I have an issue with using model binding with store and update. This is how I open the form:

/*[...]*/
@open(['model' => $news, 'update' => 'Backend\NewsController@update', 'store' => 'Backend\NewsController@store'])
/*[...]*/

Now if I try to save a new record I get the following error:

Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException thrown with message "The POST method is not supported for this route. Supported methods: GET, HEAD, PUT, PATCH, DELETE."

this is the definition for this route:

Route::group(['prefix' => 'backend', 'as' => 'backend.', 'namespace' => 'Backend'], function() {
    /* [...] */
    Route::group(['as' => 'contents.'], function() {
        Route::resource('news', 'NewsController');
    });
});

Updating an existing record works. Am I missing something? I'm using Laravel 6.5.0.

Edit: I can create new records when I use a different form @open(['action' => 'Backend\NewsController@store']), but I'd like to use the update-/store-option so I can use the same template for both actions.

As the title states, it seems like you accidentally left some test data in the code, so Form Groups are gaining a class of "test". It shouldn't affect anything unless someone has a custom class with that name, but it's still probably something you don't want there. This can even be seen in the examples in the documentation.

Hello,

Since the third Alpha version of Bootstrap 5 will be out soon, it would be great if support could be added to this package. In my opinion, this package offers the best combination with regards to forms in Laravel and Bootstrap. I am sadly not too familiar with the inner workings of the package, else I would have created a proposal.

The changelog is not that huge regarding forms (https://v5.getbootstrap.com/docs/5.0/migration/):

• Rearranged form documentation under its own top-level section.
  • Split out old Forms page into several subpages
  • Moved input groups docs under the new Forms section
• Rearranged source Sass files under scss/forms/, including moving over input group styles.
• Combined native and custom checkboxes and radios into a single .form-check class.
  • New checks support sizing via em/font-size or explicit modifier classes now.
  • New checks now appear larger by default for improved usability.
  • Dropped .custom-control and associated classes.
  • Renamed most $custom-control variables to $form-control ones.
• Combined native and custom selects into .form-select.
  • Dropped .custom-select and associated classes.
  • Renamed most $custom-select variables to $form-select ones.
• Updated file input component with the same overall design, but improved HTML.
  • Refactored .form-file markup to resolve some visual bugs while allowing translation and button text changes via HTML instead of CSS.
  • Dropped native .form-control-file and .form-control-range components entirely.
  • Renamed .custom-file to .form-file (including variables).
  • Added support for :focus and :disabled styles.
• Renamed .custom-range to .form-range (including variables).
• Dropped .form-group for margin utilities (we’ve replaced our docs examples with .mb-3).
• Dropped .form-row for the more flexible grid gutters.
• Dropped .form-inline for the more flexible grid.
• Dropped support for .form-control-plaintext inside .input-groups.
• Dropped .input-group-append and .input-group-prepend. You can now just add buttons and .input-group-text as direct children of the input groups.
• Form labels now require the .form-label class. Sass variables are now available to style form labels to your needs. See #30476

I am not sure if it's best to support two versions of the package or to add a config variable to switch between v4 and v5. Since the forms are rather similar, it might be easiest to add a config variable.

This is bordering on being a feature request, but it seems like file inputs remaining as the html standard while every other input has a form-control class makes the file input look out of place, while giving it a form-control class gives it the same shape and size as the rest of the inputs.

Without form-control:

With form-control:

  @checkbox('recently_sold','Include recently sold listings',1,true,['switch'=>true])

Not sure why but when It try to check a checkbox by default, it doesn't have that state. Am I doing something wrong?

Is there a way config an error bag for a form?

https://packages.bgaze.fr/bootstrap-form

In the publish command it missing "

Liking this package so far.

Any way to add custom-select to a @select?

It should probably be the default tbh.

I'm unable to render view through blade directive where BF facade is working.
brackets are missing for BF::close, it should be BF::close() in documentation otherwise this would throw an exception (Undefined class constant 'close').

Setting any radio input to required should set the whole group to be required, but when I add 'required' to the options on a radio group, it doesn't have any effect. Ideally, adding ['required' => true] to a radio input group would set the first option to required.

Is there or could there be a way to automatically add a class to all labels, except functional labels for checkboxes/radios? It would be nice to add the 'form-label' class to all form group labels, instead of having to specify the label and its class for each input.

Something in release 1.0.4 broke the labels of checkbox and radio choices. They are all inheriting the group name, so if a radio group is named "Colors", all radio choices will be labeled "Colors" as well.

By default, feedback is not visible in Bootstrap 4. Feedback becomes visible when adjacent to an element with the class 'is-invalid'. This works for normal inputs, but input groups have a parent div which prevents the feedback from showing up.

The Bootstrap documentation avoids this issue by appending the feedback to the input instead of the form-group, keeping the feedback inside the input-group. Perhaps this functionality could be added to the feedback for input-group elements.