bgeron / diff-pdf-visually Goto Github PK

https://drive.google.com/file/d/1-cczG0g2Ge3XV-oZD1iiM63a0x_r64WU/view?usp=sharing
https://drive.google.com/file/d/1lPmEj-KWWteo_V2Shcd847d6YXHqE2wb/view?usp=sharing

Min sig = 43.9278, significant?=True. The PDFs are different. The most different pages are: page 1 (sgf. 43.9278).

Hi,

Thank you for this great tool!

I wanted to confirm your comment in the code:
The name of this function is slightly confusing: it returns whether the PDFs are *not* different.

Actually, I was looking for other tools, thinking this one wasn't working correctly, before inverting my boolean check.

We seriously need a clear function name \o/

Hi, thanks for the great tool!
I'm wondering if it is possible for users to set up a target directory to save the diff pngs for the command line usage?
Currently it will automatically save to the /tmp/diffpdf* location. And since the tmp location is added to the function according to this closed issue: #6, It would be helpful if we can set our own from the command line.
I think the relevant part is line 70 to 74 in main.py.

Hi, I can't compare 2 PDF files and I'm getting the error of:

FileNotFoundError: [WinError 2] The system cannot find the file specified

Although, the file paths are correct. I also tried to run the IDE as Administrator but without success.
I should open the file with the permission of "R/W" or it is enough to add the path as is?

It would be nice if pdfdiff_pages() was callable with an optional target directory, so that one could look at the diff images for instances. You could use nullcontext to handle the two cases.

Hi @bgeron
I have an issue with the last release: it only works with py38+ but the classifiers in the setup.py still states it is supposed to work on py36+, so pip is still installing it for py36 and py37 while it should not. The setup.py seems to be generated by hatch but I never used it so I would prefer you update it yourself. But I can try if you have no time for this.

Hey!,
seems to work well at a first glance.
In the context i need (maven plugin to build from latex)
i have a lot of converters and need to check the version.

Could you provide a command line option to display the version?

Thank you in advance!

Best Regards,
Ernst

Is that possible to redirect the output diff to a specific file rather than a temporary one?

This package does not contain any instruction for developers. pip -e fails and setup.py is missing.

I guess poetry is somehow used, but that's currently a nonstandard tool, so it would be good to have some basic instructions on how to use it to end up with an editable installation of this package.

I am thankful for the useful code, I'm just trying to make it better - please help us help you ;)