bh11 / crisp Goto Github PK
View Code? Open in Web Editor NEWGAP package CRISP
Home Page: http://www.icm.tu-bs.de/~bhoeflin/crisp/index.html
License: Other
GAP package CRISP
Home Page: http://www.icm.tu-bs.de/~bhoeflin/crisp/index.html
License: Other
It will be desirable to make a new release of Crisp, otherwise Crisp breaks bugfix test in the master branch:
########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-master-test/GAPCOPT\
S/32build/GAPTARGET/bugfix/label/kovacs/GAP-master-snapshot/tst/testbugfix/200\
5-05-03-t00324.tst:2
# Input is:
if TestPackageAvailability("crisp") <> fail and
LoadPackage("crisp", false) <> fail then
F:=FreeGroup("a","b","c");;
a:=F.1;;b:=F.2;;c:=F.3;;
G:=F/[a^12,b^2*a^6,c^2*a^6,b^-1*a*b*a,c^-1*a*c*a^-7,c^-1*b*c*a^-9*b^-1];;
pcgs := PcgsElementaryAbelianSeries (G);;
ser := ChiefSeries (G);;
if ForAny (ser, H -> ParentPcgs (InducedPcgs (pcgs, H))
<> ParentPcgs (pcgs)) then
Print( "problem with crisp (1)\n" );
fi;
if ForAny (ser, H -> ParentPcgs (InducedPcgsWrtHomePcgs (H))
<> ParentPcgs(HomePcgs (H))) then
Print( "problem with crisp (2)\n" );
fi;
if ForAny (ser, H -> ParentPcgs (InducedPcgsWrtHomePcgs (H))
<> HomePcgs (H)) then
Print( "problem with crisp (3)\n" );
fi;
G2:=Image(IsomorphismPermGroup(G));
pcgs := PcgsElementaryAbelianSeries (G2);
ser := ChiefSeries (G2);
if ForAny (ser, H -> ParentPcgs (InducedPcgs (pcgs, H))
<> pcgs) then
Print( "problem with crisp (4)\n" );
fi;
if ForAny (ser, H -> ParentPcgs (InducedPcgsWrtHomePcgs (H))
<> ParentPcgs(HomePcgs (H))) then
Print( "problem with crisp (5)\n" );
fi;
if ForAny (ser, H -> ParentPcgs (InducedPcgsWrtHomePcgs (H))
<> HomePcgs (H)) then
Print( "problem with crisp (6)\n" );
fi;
fi;
# Expected output:
# But found:
#I DeclareGlobalFunction: too many arguments in /circa/scratch/gap-jenkins/wo\
rkspace/GAP-master-test/GAPCOPTS/32build/GAPTARGET/bugfix/label/kovacs/GAP-mas\
ter-snapshot/pkg/crisp-1.4.4/lib/util.gd:16
########
The reason is that DeclareGlobalFunction
should not use the undocumented 2nd argument (which also never been used), and in GAP 4.12 it will produce a warning, see gap-system/gap#3694 by @fingolfin
[The following of course also applies to irredsol]
With the change in 1f908e9, I cannot use crisp directly from its repository anymore, at least not without figuring out how to build it. That's quite a step backwards from my point of view :-(
My guess is that I need to do something like make VERSION=1.4dev
to get a working crisp. But this then runs into the problem that it seems you hardcoded the assumption that crisp is in $GAPROOT/pkg/crisp -- which it isn't for me. Also, it seems to assume that htm
directory with certain content already exists. I worked around that by adding
GAPROOT=../..
to the top of the Makefile, and then changing the manual.html
target to
manual.html:
( \
rm -f htm/*.htm; \
mkdir -p htm; \
perl $(GAPROOT)/etc/convert.pl -n CRISP -c -i doc htm; \
chmod -R a+r htm \
)
That said, perhaps you could provide a default value for VERSION
in your Makefile, like dev
or 1.4dev
, so that unsuspecting people can just type make
to get a working package?
And perhaps the default target could just be versions
, or all: versions manual
or so -- this way, people who are not you and do not wish to build a release tarball, just use the package from the repository, would be accomodated.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.