bh11 / irredsol Goto Github PK

Version 1.4 was released 03/08/2017 according to its PackageInfo.g file, but there is no git tag for that version, unlike for all previous reasons. It would be really nice to have such a tag, so that one can quickly see what exactly changed between released.

I tried but could not identify which commit this released was made from: there is a commit on 2017-02-17, which is immediately followed by one from 2018-09-18 ?

I was about to suggest to use TestDirectory in this package, but I see this is already the case in the master branch. Great! So I'd like to request that a new release be made, with this change in, so that we can simplify the code in the GAP distribution which detects whether the tests of a package passed.

Thanks!

It would be great if you could ship the data files in data and fp as gzip files inside the irredsol.tar.gz.

I.e., before putting them into the archive, run gzip (or even gzip -9) on them. For me, this reduces disk usage for the fp plus data directory from 71.5 MB to 25.5 MB (with PR #19: from 58 MB to 25 MB).

While disk space is cheap these days, some people still need to use GAP in lab environments with home dirs on NFS with limited quota, so having this smaller is helpful.

(base) dabajabaza@XXXX:~$ gap
┌───────┐ GAP 4.10.0 of 01-Nov-2018
│ GAP │ https://www.gap-system.org
└───────┘ Architecture: x86_64-pc-linux-gnu-default64
Configuration: gmp 6.1.2, readline
Loading the library and packages ...
Error, Variable: 'DegreeOfMatrixGroup' must have a value
not in any function at /usr/lib/gap/pkg/irredsol-1.4/lib/matmeths.gi:16
Error, was not in any namespace at /usr/share/gap/lib/variable.g:291 called from
LEAVE_NAMESPACE( ); at /usr/share/gap/lib/package.gi:1255 called from
ReadPackage( "irredsol", path ) at /usr/lib/gap/pkg/irredsol-1.4/init.g:9 called from
<function "IRREDSOL_Read">( )
called from read-eval loop at /usr/lib/gap/pkg/irredsol-1.4/read.g:9
you can 'quit;' to quit to outer loop, or
you can 'return;' to continue
brk> return;
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/iterato
rs.gi:246
[[Degree, DegreeOfMatrixGroup, Dimension, DimensionOfMatrixGroup], I
sPosInt],
^
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/iterato
rs.gi:251
[[IsPrimitive, IsPrimitiveMatrixGroup, IsLinearlyPrimitive], x -> x
in [true, false]],
^
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/recogni
ze.gi:20
DegreeOfMatrixGroup(G), Size(TraceField(G)));
^
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/recogni
ze.gi:35
DegreeOfMatrixGroup(G), Size(TraceField(G)));
^
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/recogni
ze.gi:563
n := DegreeOfMatrixGroup(H);
^
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/recogni
ze.gi:649
n := DegreeOfMatrixGroup(G);
^
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/recogni
ze.gi:764
DegreeOfMatrixGroup(G), Size(F), 1, inds, [Order(G)],
^
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/recogni
ze.gi:774
H := IrreducibleSolubleMatrixGroup(DegreeOfMatrixGroup(G), Size(F),
1, inds[i]);
^
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/recogni
ze.gi:795
info.id := [DegreeOfMatrixGroup(G), Size(F), 1, inds[i]];
^
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/recogni
ze.gi:814
info.id := [DegreeOfMatrixGroup(G), Size(F), 1, i];
^
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/recogni
ze.gi:819
H := IrreducibleSolubleMatrixGroup(DegreeOfMatrixGroup(G), Size(F), 1, i);
^
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/recogni
ze.gi:935
newinfo := rec(id := [DegreeOfMatrixGroup(G), Size(TraceField(G)), 1
, info.id[4]]);
^
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/recogni
ze.gi:963
d := DegreeOfMatrixGroup(G)/MTX.Dimension (module);
^
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/recogni
ze.gi:988
DegreeOfMatrixGroup(G), q, d, info.id[4]);
^
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/recogni
ze.gi:991
id := [DegreeOfMatrixGroup(G), q, d, info.id[4]^(perm_pow.perm^perm_
pow.pow)]);
^
Syntax warning: Unbound global variable in /usr/lib/gap/pkg/irredsol-1.4/lib/primiti
ve.gi:36
d := DegreeOfMatrixGroup(Range(hom));
^
Error, was not in any namespace at /usr/share/gap/lib/variable.g:291 called from
LEAVE_NAMESPACE( ); at /usr/share/gap/lib/package.gi:1340 called from
LoadPackage_ReadImplementationParts( secondrun, banner
); at /usr/share/gap/lib/package.gi:1636 called from
LoadPackage( name, false ) at /usr/share/gap/lib/package.gi:1930 called from
func( ); at /usr/share/gap/lib/system.g:213 called from
<function "CallAndInstallPostRestore">( )
called from read-eval loop at /usr/share/gap/lib/init.g:765
you can 'quit;' to quit to outer loop, or
you can 'return;' to continue
brk> return;
Packages: Alnuth 3.1.0, AtlasRep 1.5.1, AutPGrp 1.10, CRISP 1.4.4, CTblLib 1.2.2,
FactInt 1.6.2, FGA 1.4.0, GAPDoc 1.6.2, IO 4.5.4, IRREDSOL 1.4,
LAGUNA 3.9.3, Polycyclic 2.14, PrimGrp 3.3.2, SmallGrp 1.3,
Sophus 1.24, TomLib 1.2.7, TransGrp 2.0.4
Try '??help' for help. See also '?copyright', '?cite' and '?authors'
gap>

It would be useful to edit the repository description like shown e.g. at
https://stackoverflow.com/questions/7757751/how-do-you-change-a-repository-description-on-github
and add a link to the package webpage http://www.icm.tu-bs.de/~bhoeflin/irredsol/index.html. This allows quickly to navigate from the repository to the webpage, instead of having to look for its URL in PackageInfo.g.

Could you perhaps make a new release with the DegreeOfMatrixGroup fix in it? It is a blocker for gap-system/gap#4349