The #/export url is not properly designed:

• add it in the left menu (for users with administration permission)
• integrate the design to be like other pages (with the menu, the css, ...)

Urungi has no CSRF protection

https://lgtm.com/rules/1506064038914/

Let the user enter an SQL query (direct) to define the max value of the report. For example : a gauge displaying this month check-out, would have a max of [SELECT count()2 FROM issues WHERE month(issuedate)=month(today())-1 AND year issue(date)=year(today))] => will display the % of checkouts compared to last month, up to 200% (because of the *2)

Note that this example query has a lot of mistakes (for example january will compare to nothing)

When building a cross table report, the report is not displayed and the following error appears in browser console:

Error: d.size is not a function
N@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:876:13491
n@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:876:8446
o@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:876:8671
init/l<@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:876:4677
each@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:1:2775
each@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:1:1417
init@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:876:184
y.fn.cypivot@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:876:16675
link/</<@http://biblibre-urungi.test.biblibre.eu/js/report/directives/reportView.js:55:50
e/<@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:141:434
$eval@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:156:65
$digest@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:153:123
$apply@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:156:361
l@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:108:192
K@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:112:376
tg/</N.onload@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:113:338
bundle.min.js:128:446
    f http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:128
    get http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:101
    e http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:142
    $eval http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:156
    $digest http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:153
    $apply http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:156
    l http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:108
    K http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:112
    onload http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:113

To Reproduce
Steps to reproduce the behavior:

1. Build a simple cross table report
2. Click on 'Refresh data'

Expected behavior
The report should be displayed

Client (please complete the following information):

• Browser: Firefox 66.0.4

The layer list is sorted alphabetically, but UC are all before lc : A N Z d e
Should be A d e N Z

Currently, the report builder and dashboard builder use the plugin https://github.com/neoziro/angular-draganddrop, which is no longer maintained.
If a better, still maintained plugin could be found and used instead, that would be a good thing. https://github.com/codef0rmer/angular-dragdrop looks more promising.
Switching the plugins would be a good occasion to also fix the issue of columns not being draggable from one area to another in the report builder.

In layer creation, at the top of each table, there is a white + or -
He show/hide table fields. For now, he hides everything.
Expected behavior: hide only unused fields of the table.

There should be a way to store the version of the software the layer has been built for.
The version is entered manually, and when imported, it is retrieved and displayed.

Describe the bug
docker-compose up -d failed

To Reproduce
Steps to reproduce the behavior:

clone
docker-compose up -d
error

W: Failed to fetch http://httpredir.debian.org/debian/dists/jessie-updates/InRelease  Unable to find expected entry 'main/binary-amd64/Packages' in Release file (Wrong sources.list entry or malformed file)

E: Some index files failed to download. They have been ignored, or old ones used instead.
ERROR: Service 'widestage' failed to build: The command '/bin/sh -c apt-get update && apt-get install -y openjdk-7-jdk &&  npm install -g bower' returned a non-zero code: 100

Server (please complete the following information):

• OS: ubuntu 18.04 server
• docker-compose version 1.22.0

Additional context

Step 2/8 : RUN apt-get update && apt-get install -y openjdk-7-jdk &&  npm install -g bower
 ---> Running in 56bfae231ede
Ign http://httpredir.debian.org jessie InRelease
Get:1 http://httpredir.debian.org jessie-updates InRelease [7340 B]
Get:2 http://httpredir.debian.org jessie Release.gpg [2420 B]
Get:3 http://httpredir.debian.org jessie Release [148 kB]
Get:4 http://httpredir.debian.org jessie/main amd64 Packages [9098 kB]
Get:5 http://security.debian.org jessie/updates InRelease [44.9 kB]
Get:6 http://security.debian.org jessie/updates/main amd64 Packages [849 kB]
Fetched 10.2 MB in 11s (885 kB/s)
W: Failed to fetch http://httpredir.debian.org/debian/dists/jessie-updates/InRelease  Unable to find expected entry 'main/binary-amd64/Packages' in Release file (Wrong sources.list entry or malformed file)

E: Some index files failed to download. They have been ignored, or old ones used instead.
ERROR: Service 'widestage' failed to build: The command '/bin/sh -c apt-get update && apt-get install -y openjdk-7-jdk &&  npm install -g bower' returned a non-zero code: 100

Add a feature to export a dashboard or a report as [PDF or image (PNG, JPG, SVG) ?] when executing a R or a D.

The main page of Urungi looks like:

The main menu:

• could be more on the left (only a few blank between border and menu)
• could be less large: a lot of empty space between the end of "My dashboards" and the number of dashboards

On my 1366x768 14" laptop screen, the dashboard page (Firefox, display 100%) look like this:

The dashboard list:

• strange to have the (public) and (shared) infos on the left, and the sharing button on the right.
• strange to have 3 buttons at the same level, the 4th on 2nd line
• the filter forms for name & author are too big, can we reduce their height ?

Zoom in/out: the 4 buttons are moving around... depending on the zoom %
You can get:
(100%)
(80%)
(110%)

can we have a smaller asc/desc) button at the right of Name/Author/Creation date ?

When using an Oracle data source, date filters generate a wrong query, and Oracle returns the following error message:

ORA-01861: literal does not match format string

It should be possible to define manually the legend. For now, if you select biblionumber (count) as a metric, the legend of the X axis is "biblionumber (count)".

Depends on #130

SQL views should be accessible in layers

In MariaDB (and mySQL), you can query different DB in a single SELECT using fully qualified identifier : dbname.table.column Introduce this behaviour in Urungi to enable cross DB queries

When you create a report, the fields list (on the left, from the layer) can be very long.
It would be very useful to have a filter: enter "price" and you get all the fields containing price in the description

The #/import url is not properly designed:

• add it in the left menu (for users with administration permission)
• integrate the design to be like other pages (with the menu, the css, ...)

For now, when you #/import a json, if the id already exist, the import is cancelled. We should have an option to overwrite an existing layer/dashboard/report (with a confirmation that you want to overwrite)

That will be very helpful to deploy on several customers Urungi instances.

the #/import feature must be runnable using command line

Create a report from patrons
count all patrons sex=M and registration year = 2016 => Urungi says 14
Display the name+firstname of all patrons sex=M and registration year = 2016 => Urungi shows 13 !!!!

For now, there is no permission to manage layers, it's included in the "Urungi administrator" pseudo-role.
If you have this pseudo-role, you can do anything : manage layers, data source, roles, users.
It would be great to have a specific permission for layers, in the roles definition, like the one we have to create reports/dashboard/explore/view SQL:

You often want to run a report based on "today" ("fixed value", not selected by the user) Currently, there's no possibility to set a SQL statement like "today".

Feature => add the possibility to enter a SQL statement on the right part of a filter

Sometimes you want to display the same data in different formats. It is possible to change the format only at the layer level. It would be nice to be able to change the format at the report level.

Depends on #130

When you put a filter on a date, you get a date selector, but it's impossible to enter manually a date. finding an old date is highly time consuming, we need to be able to enter the date.
there is a graphic glitch (see screenshot)

When adding a field to a layer, retrieve the "comment" of the field and put it in the "description" of the field in the layer

In the report list :

• display the layer used for the report
• sort by layer
• filter by layer

LGTM reports several issues with the latest Urungi code:
https://lgtm.com/projects/g/biblibre/urungi/alerts/?mode=list.

Add the following icons to the available images. they must be available when you add an image on a dashboard
icon.zip

when I select Oracle mode as the data source. I enter the information requested by the form and when I click on the connection test button I have the message :

Error executing test connection SQL : TypeError: "listener" argument must be a function

On the urungi server I installed node-oracle and installed the oracle basic client

If you enter a ? in a calculated field (within ''), you get a nasty error message
Steps to reproduce: create a calculated fields containing '?', and display it in a report.

gauge.max has the default value of 100. The user should be able to enter the max value manually.

the view SQL button appears only once the results have been displayed. It would be much better to have it immediately when the user hit "refresh data")

• in the public area, clic on a notification icon
• see or customise the frequency (every day, every week)
• must verify if the email address is filled in my profile
• must setup a cron (have a look to nodejs possibilities https://www.npmjs.com/package/cron)
• save the settings in the Users table
• create a snaphost of the report or dashboard

Format to define (easiest way for the first step)

• pdf is complicated to generate
• svg ?
• html ?
• screenshot de la visualisation ?

=> pdf + image attached to the mail

Possible solution:

• Store all execution times
• Display the average

It would be nice to give the user the ability to authenticate in case he forgot his password with "Secure password reset emails"

Edit DLL - D1 - Imprimés et D2 ...
The crossed reports are small, but they have scrollbars, horizontal and vertical, that are useless.
I tried to update the size of the graph, the container, could make them disappear, until I redraw the result.

catalogue.zip
after selecting a 'catalogue.json' file, I see:

invalid file format controller.js:52:17
Error: "missing fields"
onload http://biblibre-urungi.test.biblibre.eu/js/io/controller.js:49

=> this message should be on the screen, it's probably an old .json file (will attach it on this PR)

Trying with a newer json file, it work, even if I get:
Error: Argument 1 of FileReader.readAsText is not an object.
$scope.upload@http://biblibre-urungi.test.biblibre.eu/js/io/controller.js:43:9
fn@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js line 245 > Function:4:281
m@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:8100:8643
i.updateModel/<@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:8100:10186
e/<@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:141:434
$eval@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:156:65
$digest@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:153:123
$apply@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:156:361
e/q<@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:169:386
f@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:54:490
mg/k.defer/c<@http://biblibre-urungi.test.biblibre.eu/js/bundle.min.js:57:418

Originally posted by @PaulPoulain in #48 (comment)

When we select french translation , the two buttons in layers are displayed incorrectly and one become unclickable.

To reproduce the bug:
Check that the layer has a date field. For example, the acquisition layer shows:

The "date saisie ligne commande" is a date field, and has a small pink calendar icon.
Create a report:

The icon is not a calendar. This is true for every date field. Everything work well, if you select the date field, it is considered as a field, the icon is wrong, nothing more.

When you open a dashboard, it is immediately calculated, even if there is a parameter to set (mandatory or not).
Change the behavior to calculate only when the user clic on OK when there is a run-time parameter

When you add a report on a dashboard, a preview is made. There's no 'limit' used when building the preview. On large dataset, you have to wait a long time before seing the result. Automatically limit the sample to X first results (configurable)

• draw only when clicking new 'Redraw' button
• rename 'Refresh' (-> Redraw) button in report edition

In cross tables, display totals of all columns and rows
In grids and vgrids, add ability to define a list of columns where the total should be calculated