bielikb / fastlane-plugin-create_xcframework Goto Github PK

I am using this plugin as follows:

create_xcframework(
	workspace: 'Framework.xcworkspace',
	scheme: 'Framework',
	destinations: ['iOS'],
	xcframework_output_directory: 'output'
)

This results in having a separate Framework.xcframework, Framework.dSYMs and Framework.BCSymbolMaps

I would expect the symbols included inside the xcframework, next to the frameworks for the separate architectures.

With popularity of SPM not every project now has .xcworkspace, would be great to have :project key as an alternative

After archive, fastlane will merge framework to xcframework,
if output path have space, like "your path/folder", it will get an error says, "error: the output path must end with the extension 'xcframework'".
you must set your path like, "your_path/folder", it will be success.

fastlane finished with errors

[!] ▸ PRODUCT_NAME was misdefined: MySDK. Please, provide :product_name option

Hi @bielikb !

We are using the plugin and it is working good. Thanks for that! For our use case, though, we would like to be able to disable BUILD_LIBRARY_FOR_DISTRIBUTION, but we have found that the plugin is replacing the configuration.

We would like to contribute to the plugin and make it configurable (by default override it to keep current behavior, but give the possibility to the consumer of the plugin to specify whichever value they want for it). I wanted to know if you would be interested in including this in the plugin. If so, I will create a PR bringing in those changes.

Let me know your thoughts!

It would be useful if the xcconfig parameter of xcodebuild was supported.

From xcodebuild --help:

-xcconfig PATH               apply the build settings defined in the file at PATH as overrides

Hello,

Thank you for this plugin.
I'd like to report a bug in which any custom xcargs passed via OTHER_CFLAGS will be overwritten by the string "-fembed-bitcode" regardless of whether or not it's appearing the in related Fastfile argument.
For example, say I have the following specified:
xcargs: 'OTHER_CFLAGS="-DOSCL_EXPORT_REF= -DOSCL_UNUSED_ARG= -DOSCL_IMPORT_REF= -fembed-bitcode"',
I'd expect the plugin to not modify OTHER_CFLAGS, but it will replace it, leaving only "-fembed-bitcode" and thus changing the intended compilation code.

Regards,
Doron

Add possibility to create xcframework for static libraries

Even though the include_debug_symbols parameter defaults to true, if omitted, debug symbols will not be included in the .xcframework file.

I tested in https://github.com/RevenueCat/purchases-ios adding and removing the parameter here.

I don't believe this is the expected behavior given that the parameter defaults to true, but happy to close if this was indeed the expected behavior.