billogram / billogram-v2-api-php-lib Goto Github PK

$method is never used in this function.

    /**
     * Creates and sells a billogram.
     *
     * @param $data
     * @param $method
     * @return \Billogram\Api\Objects\BillogramObject
     */
    public function createAndSell($data, $method)
    {
        $data['_event'] = 'sell';
        $billogram = $this->create($data);

        return $billogram;
    }

Please consider using semver versioning (http://semver.org/)

Line number 68

        $response = $this->api->delete($this->url());

The function 'delete' is returning null and not $response. $response could be removed?

How to fetch list of invoices by date range? For example, invoice_date> = 2019-01-01 and invoice_date <= 2019-02-01.

At the moment you are using fopen to send HTTP requests. A lot of what you are doing is like waking across the bridge for water.
Would you be open for using a standard way of sending HTTP requests by using HTTPlug?

This will reduce your code by at least 50% and will also solve the issue in #9.

Autoloading Billogram with composer doesn't work. Add this to composer.json to make it work:

"autoload": {
        "psr-0": {"Billogram": ""}
}

Working fork here: https://github.com/murtlest/billogram-v2-api-php-lib

Possible to include the lib without the use of composer?

Hey @AndreasHogstrom

May I suggest that you should not be defensive in your responses. Example #9, #12, #13, #14. There are a lot of great developers that would like to help you making your project better, they should be encouraged instead of shot down with an answer without content.

Im fine with you not accepting my changes but I would like to see a reason based on good software design instead of "I do not feel like it".

Just a minor thing. A cool company like Billogram should not be using deprecated PSRs. We should consider moving to PSR4.

Hi,

using http wrapper in streams considered as potential security risk. On our server we use allow_url_fopen=0 to block possibility to use url instead filenames. The recomended method to make remote requests in PHP is to use curl directly.
Anyway there would be no problem to override Api::httpRequest if it would have protected access modifier.

Does the library allow creating invoices without a customer no? I have an issue where every API order creates duplicate customer profiles. The example file is pretty insufficient perhaps an example would save integrators a lot of time.

Is there any plans for an extension/adapter to Payum? Would you willing to accept a new package like that?