Giter VIP home page Giter VIP logo

Comments (3)

johnlees avatar johnlees commented on May 30, 2024 1

This compiles ok for me on Linux, but fails on OS X. I think it may be because size_t will typically be 64 bits on Linux, but 32 bits on OS X. I think the fix for this is to make the various places where hashes are defined as:

std::vector<size_t>& hashes

to explicitly use 64 bits as in other defintions:

std::vector<uint64_t>& hashes

However this will still fail when compiling aio_search_file as we don't have the linux kernel headers:

../cobs/query/compact_index/aio_search_file.hpp:13:10: fatal error: linux/aio_abi.h: No such file or directory
   13 | #include <linux/aio_abi.h>
      |          ^~~~~~~~~~~~~~~~~

@bingmann Do you know any way around this, or have any plans to officially support OS X?
Also, would it be helpful if I raised a PR for the consistent integer widths?

from cobs.

johnlees avatar johnlees commented on May 30, 2024

This compiles ok for me on Linux, but fails on OS X. I think it may be because size_t will typically be 64 bits on Linux, but 32 bits on OS X. I think the fix for this is to make the various places where hashes are defined as:

Or it may be that they are the same width, but unsigned long long vs unsigned long, which are treated as distinct by the compiler despite being the same - I'm not sure! Either way changing the size_t to a specified width doesn't seem like a bad idea

from cobs.

bingmann avatar bingmann commented on May 30, 2024

Yes, changing size_t to the correct specific data types is of course wise.
Regarding the other issues, I don't have a Mac, so I can't fix that.

from cobs.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.