📎 Implement `lint/noUselessLoneBlockStatements` - `eslint/no-lone-block` about biome HOT 13 CLOSED

I think, in our case, the word "lone" can be dropped. I suggest noUselessBlock

from biome.

I think, in our case, the word "lone" can be dropped. I suggest noUselessBlock

Not sure, because the rule concerns only "lone" block statements, i.e. block statements that are not attached to a if, else, while, function, ...

EDIT: The rule prohibits lone blocks that don't include any variables declaration.

Example of incorrect code:

{
  f();
}

{}

Example of correct ode:

{
  let x = 1;
}

// This is not a lone block
if (cond) {}

from biome.

Thank you for clarifying! I would still remove "statement" from the word :) it's not beginner friendly

from biome.

Hey there. I've been using Biome so would love to contribute. I'm fairly new to Rust, but willing to give this a go if you're ok with that?

from biome.

Go ahead @emab , feel free to use this issue to ask any question, or even a draft pr

from biome.

Great! Thank you.

from biome.

Hi @ematipico, please can I check if I'm on the right path?

emab@62e85fe

from biome.

I wasn't sure how to check for strict mode in one of my functions...

from biome.

Please open a PR so that we can add comments :)

from biome.

Opened, link above!

from biome.

@Conaclos may I ask how I can have multiple valid / invalid test files? I want to include ones which are a module (by adding exports {}) and ones which are not in order to properly test the detection of functions in block statements.

from biome.

@emab simply add other files, for example invalidXXXX.js.

For esm use js or ts extension. For script file (non-strict mode) you can use cjs extension.

from biome.

@emab simply add other files, for example invalidXXXX.js.

For esm use js or ts extension. For script file (non-strict mode) you can use cjs extension.

Brilliant thank you, have updated the PR.

from biome.