Giter VIP home page Giter VIP logo

convgrucell-pytorch's Introduction

convgrucell-pytorch's People

Contributors

bionick87 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

convgrucell-pytorch's Issues

The convolution layers kernel size are set to 3

Shouldn't the kernel size be equal to kernel_size. It seems to be explicitly assigned to 3. Just commenting because I am using part of your code for a different project, not replicating the paper.

Update previous state?

for e in xrange(max_epoch): for time in xrange(num_seqs): h_next = model(input_gru[time], None) err += MSE_criterion(h_next [0], target_gru[time]) print(err.data[0])

It seems to me that you assume that previous states are all None. But after time step 1, the previous state is now h_t-1 so I think the code should be like below:

prev_state = None for e in xrange(max_epoch): for time in xrange(num_seqs): h_next = model(input_gru[time], prev_state) err += MSE_criterion(h_next [0], target_gru[time]) prev_state = h_next print(err.data[0])

The calculation process is inconsistent with the original paper

image
In your implementation part.
In your implementation process, Equation (8) uses the following code:
next_h = torch.mul(update_gate,hidden) + (1-update_gate)*ct

According to the original calculation process, it should be the following code organization:
next_h = torch.mul(update_gate,ct) + (1-update_gate)*hidden

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.