Giter VIP home page Giter VIP logo

Comments (7)

cbeams avatar cbeams commented on June 23, 2024

I've been thinking about doing this as well, glad you suggested it. I wonder about keeping the underlying infrastructure in place, though. We don't have to remove it right away, but over time it may become a liability. It adds considerable complexity and now there will be nothing testing or exercising it. It'll be dead code that does nothing but get in the way.

from proposals.

sqrrm avatar sqrrm commented on June 23, 2024

I agree with removing the support. I also see that there might come a time when we need to re-enable it considering it's less than a year since it was first needed. I would probably keep the infrastructure in place at least for a while.

from proposals.

ManfredKarrer avatar ManfredKarrer commented on June 23, 2024

Yes lets see how BTC as base currency develops. Miner fees will for sure rise once again to considerable heights and then we might re-consider to go back if we don't have a new off-chain model by then. I hope for the next 1-2 years we are still good with BTC and on-chain transactions.

from proposals.

ManfredKarrer avatar ManfredKarrer commented on June 23, 2024

The proposal was accepted by 4 votes and 0 rejections. It is implemented in v0.7.0.

from proposals.

 avatar commented on June 23, 2024

I have a little suggestion, hopefully not too complicated:

  • would it be interesting to store the Litecoin concerned code in a github repo here ? This in order for potentially interested people to be able to put an eye on it
  • would it be interesting to open an operator role for running some LTC nodes in order to be able to (re)propose this feature in the future (if there is interest) ?

I make this suggestion because I imagine it was some work to propose that, and it may be sad to have the code just dissapearing and forgotten.
I make this suggestion for the LTC code and nodes, but maybe it would be more appropriate for BCH ?

from proposals.

ManfredKarrer avatar ManfredKarrer commented on June 23, 2024

The code stays, we just deactivated in the UI the currency selection.

from proposals.

cbeams avatar cbeams commented on June 23, 2024

I've added the was:approved label to this issue. @ManfredKarrer, technically, only one of the @bisq-network/proposals-maintainers should actually close issues. (You can do this yourself since you're one of the @bisq-network/github-admins, but the best thing in the future would be to @mention the proposals maintainers and ask them to close the issue, so they can double-check everything is in order process-wise, add labels as appropriate, etc. (by the way, I appreciate that you probably did this on my behalf because of my recent health issues. Just mentioning it here all the same for completeness).

from proposals.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.