bit-nation / bitnation-pangea-mobile Goto Github PK

Feature / Issue

Currently, Some visual styles are set inside of components. See the file, src/components/common/NationListItem.js
All visual styling should be in central, global style files

Acceptance criteria

• Create central styling files and method
• Move local visual styling to one or more global style files
  • Nations
  • Wallet
  • Profile
  • Chat
  • Dashboard
  • Components

Additional information

Feature / Issue

Original issue on Panthalassa repo.

Acceptance criteria

App should open Realm db correctly (without warning).

Additional information

Check out branch feature/extend-rows where required linking on Android is completed (check link for details). The app will crash without that linking.

Feature / Issue

We use "Demo" for features that are for show only. Change the "Demo" label to read "Coming Soon".

Acceptance criteria

• Change all "Demo" to "Coming Soon"

Additional information

Feature / Issue

This SHOULD be assigned to mimetic, who is david.mimetic

Acceptance criteria

• When i ... then ... (remove this)

Additional information

Keep ... in mind

Feature

As a user I can see the splash screen when app open

Acceptance criteria

• App should show a splash screen on loading

Resources

In comments, below, is a JPG of a useable splash screen.

Existance of private key controls flow

As a user, if you do not have a private key, then you cannot have a wallet, nor create a nation.
You will be warned to get a private, and/or be guided to create a private key.
Private Key Flow Notes.pdf

Acceptance criteria

• Nations: "New" link shows either correct alerts or leads to "Create Nation".
• Wallets: software shows either "Create Wallet" or "Wallets List"

Additional information

In the future, there may be different private keys for different activities, e.g. nation-building, wallets, documents. Expect more decision making like this to come, especially with the implementation of a simple "Key Chain".

Feature / Issue

Panthalassa (or no pangea libs) has some new features etc. We need to update it.

Feature / Issue

As a developer I need an easy way to sign my project for ad-hoc build's and releases.

Acceptance criteria

• Sign code for development / ad-hoc
• Sign code for releases

Feature / Issue

The label text is extending outside the View element in simulator. Might do so in real app? Bug?
See the SwitchLabeled.js component. Styles are in global/Styles.js

Acceptance criteria

• Text should stay inside the View!

Additional information

Keep ... in mind

Feature / Issue

The App's current version stores the User's Profile information only into the device memory so it does not persists through several uses. Need to implement the saving of this information in Panthalassa.

Acceptance criteria

App should stores User's Profile information, persists and be accesible also from all versions (mobile and desktop). Please provide me the functions to implement this behavior on the mobile version.

Feature / Issue

As a user I would like to see a dashboard when I open the app that show's different thing's like my wallet balance and so on.

Resources

There must be mosaic code somewhere. However, see this code for a possible solution to the mosaic layout (for now) : GeekyAnts/react-native-easy-grid@a6fa694

Newest UI Design screens

https://invis.io/HTF508H5Z
(Contact David Gross for permissions)

Acceptance criteria

• Should resize according to the screen size.
• The component's should be reusable.
• Elements are "panels." Each panel contains a title and information, e.g. "Nations" and text.
• Not all panels must function. To show ideas, we can make fake panels but add "DEMO" to the background of the panel.
• The text and/or list of items is a sub-component, containing either a styled text block, a table, or an image
• Code suggestion from David: Write the code each so that it can hold a multimedia element, or a link to one. That might be a styled text, image(s), a link to a video, or audio, or a web page, etc. I suggest the panel is given a database reference that points to a record (which can be cached!). That record contains the multimedia information or references necessary. This approach moves creation of the multimedia panels to some other system, and allows faster caching and checking for updates.
• Panels color and size can change based on variables that reflect age, importance of information, and amount of content. For example, an important news item about your nations should make the Nations panel larger, at the top-left, and more saturated color. How this should work, I do not know yet.
• Example of JS code to draw a Responsive, dynamic Tile Grid Layout (with many more examples in links below): https://www.jqueryscript.net/layout/Responsive-Dynamic-Tile-Grid-Layout-with-jQuery-tileWall.html

Issue

There is a fundamental issue in service container, actually ethWeb3Instance is NOT a Web3 instance, but IS a promise that resolves into Web3 instance, however we pass it as Web3 instance to another constructors. That surely leads to crash on using Web3 instance methods (since there is no actually an instance, but promise).

Possible solutions

Export not a container object but promise that returns a container. Requires changes across all the app.

Feature / Issue

Consistent footer nav provided for all indicated screens (see each ticket created for each screen)

Acceptance criteria

This issue is closed with the menu functionality is provided as defined for the specified screens (see each ticket).

Additional information

See attached file.

Needed:

• Icons for each (Kent is creating the one for Dashboard - ignore the one for Lucy
• Labels for each (should be self-explanatory but see Kent if there's questions)

icons.zip

Feature / Issue

Status bar can be on/off, depending on app settings.
When we specify the navigation area, it draws from the top of the screen, under the status bar, instead of starting below the status bar.
The "fake" navigation bar switches between status bar height and one navigation height (there should be two kinds of navigation)
In our basic screen layout, the status bar is mixed in with the Navigation, which is the next row on the screen.

Acceptance criteria

• Separate the status bar view from the navigation view. The flags to turn on/off status is completely different than the one for navigation.

Additional information

User can enter a space for name and/or location, and then they are an "empty" user.

Fix:

□ Trim user entry of spaces front and back
□ If username is empty, then mark as empty (missing) profile and discard location

Feature / Issue

Devs will find it useful to have ESLint installed.
Setting up ESLint for Webstorm isn't 100% obvious if you don't know ESLint.
Recommendation: Set up ESLint for React Native.

Acceptance criteria

• Add install and setup instructions to the developer setup information page:

Global Install

Use global install because otherwise, you have to reinstall if you reinstall the project.

Global Installation and Usage

If you want to make ESLint available to tools that run across all of your projects, we recommend installing ESLint globally. You can do so using npm:

$ npm install -g eslint
You should then setup a configuration file:

$ eslint --init
After that, you can run ESLint on any file or directory like this:

$ eslint yourfile.js
Any plugins or shareable configs that you use must also be installed globally to work with a globally-installed ESLint.

Note: eslint --init is intended for setting up and configuring ESLint on a per-project basis and will perform a local installation of ESLint and its plugins in the directory in which it is run. If you prefer using a global installation of ESLint, any plugins used in your configuration must also be installed globally.

Additional information

Keep ... in mind

Feature / Issue

The Google Play store, and the Apple iTunes App Store, both require graphics to display in the store.
The iTunes Store only requires a large-sized icon, which I can included in the icon files inside the build.

Acceptance criteria

• Google Play store graphics (Hi-Res Icon, Feature Graphic, TV Banner, Promo Graphic)
• iTunes store graphics ()
• Google Play store screen shots
• iTunes Store screen shots

Additional information

Files are attached below, as comments.

Nations View needs a Chat

Users need to be able to jump to a chat for a nation.
Functionality will come in a later version
Design shows this...done in code?

Acceptance criteria

• Add Chat button to the menu bar on the screen, below the title.
• Reorder buttons in the menu bar
• Also, need correct icon graphics for the menu bar.

Additional information

Need icon graphic design for the menu bar.

Review file structure and technical details in Readme and update it to current version.

Issue:
When editing or creating the Profile, the app forces the user to enter a location.

How to fix:
The location is optional, and can be left empty.

Feature / Issue

Since chat is not ready, we cannot share ETH addresses on our chat to allow someone to send money.
It is common to transfer ETH from outside Bitnation.
Therefore, we need a way to share a Bitnation wallet address outside the system, e.g. email, chat, etc.

Acceptance criteria

• Make "Share" button on Wallet Receive screen share a wallet address via system sharing tools (e.g. email, chat, etc.) These are the user configurable phone sharing tools. On iOS, they usually include email and message.
• Sharing should include the wallet address as a string, AND the QR code.

Additional information

Issue

App needs to be restructure

Acceptance criteria

• app should wired up with Redux and Redux-Saga
• smart and dummy components should be Seperate
• Styles should be separate from classes/screens
• Fonts, Colors and other assets should be placed seperately

Problem:

It is not clear how to place and position major elements on screens, including navigation. If the status bar were to be hidden, everything would break because we don't have a structure that accommodates it.
We want modularity.

Solution:

Make a generalized page layout view, with sections in the comment below.

Issues

• We cannot simply add margins left/right, because some elements go to the screen edges.

Feature / Issue

Usage behavior when a user opens the Pangea application and is already logged in

Acceptance criteria

This feature is complete when the application interaction is consistent with that which is documented in the attached interaction flow diagram

Additional information

See attached files
Logged In Mode v1.pdf

Wallet v3.pdf

Feature / Issue

Functionality in support of wallet capability

Acceptance criteria

this is satisfied when the feature and application look and feel has been delivered consistent with that which is defined in the attached interaction flow diagram and screen images.

Additional information

See attached images

• If the app does not have a private key for the wallet, then "create wallet" must lead the user through the "Create a Key" process, including the verification. Only then is the private key created, and only then can a wallet be created.

Newest Screen Designs

https://invis.io/HTF508H5Z
Contact David Gross if you do not have permissions to see.

NEEDED

• icons
• labels
• help text finalization and approval
  
  
  
  
  
  
  
  

Feature / Issue

The instructions in Project Setup are incomplete.

Acceptance criteria

• Add: Install CocoaPods (https://cocoapods.org)
• Add the following procedure after checking out a branch:

npm install
cp .env.dev.example to .env
cd ios
pod install
cd ..

[ ] Add ESLint setup: Combination of these :

1. To set the Google JavaScript Style Guide as default
   Open the ﹍Code Style. JavaScript﹍ page (in the Settings/Preferences dialog (⌘,), choose Editor | Code Style | JavaScript), click Set from, and then choose Predefined Style |Google JavaScript Style Guide. The style will replace your current scheme.
2. http://www.codeblocq.com/2016/03/Setup-ESLint-in-WebStorm/

Additional information

If you don't like the Google JavaScript Style Guide, then change the above instructions.

Text for the UI should be stored in a global file so that it is easy to make changes.
For example, a "label" for a form field should be stored in this global file. That is, in a form, the label "Nation Name" should be stored in the global file.

Acceptance criteria

• This library is integrated to provide internationalization.
• File structure configured for localization, like ./src/global/strings/en.json and so on.
• Everything is split up into separated objects (scopes), like:

legalCodeCommon: 'Common Law',
legalCodeCivil: 'Civil Law',

should be

"legalCode": {
"common": "Common Law",
"civil": "Civil Law"
}

(note the .json format), and used like Strings.t('legalCode.common').

• Strings file cleaned up from everything except infrastructure for string internationalization, like formatter functions should be removed (we have formatters in ./src/utils/formatters.js) and so on.

Feature / Issue

We need the eth daemon lightnode since we need to access the ETH network.

Acceptance criteria

• Implement a start method were the config can be passed as an json object.
• Implement a stop method that will stop the daemon

Additional information

Pls keep in mind to update the doc's.

Feature / Issue

Nations functionality (screen and function)

Acceptance criteria

Satisfied when the screens deliver upon the look, feel, form, and function as defined in the attached document and as indicated in the attached interaction flow document

Additional information

See attached. Seek kent for clarification

• If the app does not have a private key OR there is no wallet for payment OR there are not sufficient ETH funds in the wallet, THEN the "New" link used to create a new nation should NOT be visible.
• For 0.3, there is only one private key for the app. This key is used for the wallet and for nation creation. This will change in the future.

Newest Screen Designs

https://invis.io/HTF508H5Z
Contact David Gross if you do not have permissions to see.

NEEDED

• icons (Kent) (Icon are provided in the comments, below, in PNG format)
• label verbiage (should be obvious but we need to review)
• descriptive text for each interaction (needs to be defined and approved)

Nations Module v1.pdf

Issue

Sometimes bitrise fails. It seem's to be a kind of random. The error:

▸ Copying /Users/vagrant/git/node_modules/react-native-vector-icons/Fonts/MaterialCommunityIcons.ttf
▸ Compiling LaunchScreen.xib
▸ Processing Preprocessed-Info.plist
▸ Generating 'Pangea.app.dSYM'
▸ Running script 'Bundle React Native code and images'
the transform cache was reset.
❌  error: File /Users/vagrant/Library/Developer/Xcode/DerivedData/Pangea-aiqbjxbwbwzexecwjgzgojuzeleo/Build/Intermediates.noindex/ArchiveIntermediates/Pangea/BuildProductsPath/Release-iphoneos/Pangea.app/main.jsbundle does not exist. This must be a bug with
** ARCHIVE FAILED **
The following build commands failed:
PhaseScriptExecution Bundle\ React\ Native\ code\ and\ images /Users/vagrant/Library/Developer/Xcode/DerivedData/Pangea-aiqbjxbwbwzexecwjgzgojuzeleo/Build/Intermediates.noindex/ArchiveIntermediates/Pangea/IntermediateBuildFilesPath/Pangea.build/Release-iphoneos/Pangea.build/Script-00DD1BFF1BD5951E006B06BC.sh
(1 failure)
[22:43:23]: Exit status: 65

have a look at this

Acceptance criteria

• Builds should pass

Issue

I can't build the project for ios with the linked realm library. I am getting this error:

** BUILD FAILED **


The following build commands failed:
	CompileC /Users/florian/project/BITNATION-Pangea-mobile/ios/build/Build/Intermediates.noindex/RealmJS.build/Debug-iphonesimulator/GCDWebServers.build/Objects-normal/x86_64/GCDWebServer.o /Users/florian/project/BITNATION-Pangea-mobile/node_modules/realm/vendor/GCDWebServer/GCDWebServer/Core/GCDWebServer.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
	CompileC /Users/florian/project/BITNATION-Pangea-mobile/ios/build/Build/Intermediates.noindex/RealmJS.build/Debug-iphonesimulator/GCDWebServers.build/Objects-normal/x86_64/GCDWebServerConnection.o /Users/florian/project/BITNATION-Pangea-mobile/node_modules/realm/vendor/GCDWebServer/GCDWebServer/Core/GCDWebServerConnection.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
	CompileC /Users/florian/project/BITNATION-Pangea-mobile/ios/build/Build/Intermediates.noindex/RealmJS.build/Debug-iphonesimulator/GCDWebServers.build/Objects-normal/x86_64/GCDWebServerDataRequest.o /Users/florian/project/BITNATION-Pangea-mobile/node_modules/realm/vendor/GCDWebServer/GCDWebServer/Requests/GCDWebServerDataRequest.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
	CompileC /Users/florian/project/BITNATION-Pangea-mobile/ios/build/Build/Intermediates.noindex/RealmJS.build/Debug-iphonesimulator/GCDWebServers.build/Objects-normal/x86_64/GCDWebServerDataResponse.o /Users/florian/project/BITNATION-Pangea-mobile/node_modules/realm/vendor/GCDWebServer/GCDWebServer/Responses/GCDWebServerDataResponse.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(4 failures)

Installing build/Build/Products/Debug-iphonesimulator/Pangea.app
An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=2):
Failed to install the requested application
An application bundle was not found at the provided path.
Provide a valid path to the desired application bundle.
Print: Entry, ":CFBundleIdentifier", Does Not Exist

Command failed: /usr/libexec/PlistBuddy -c Print:CFBundleIdentifier build/Build/Products/Debug-iphonesimulator/Pangea.app/Info.plist
Print: Entry, ":CFBundleIdentifier", Does Not Exist

on my branch (panthalassa/db).

Acceptance criteria

• I should be able to run the project with yarn run ios

Create global 'styles.js' that everything loads for visual styles, e.g. NationListItem.js should load global styles.js.
The component can override styles, or add new styles if it needs to.

Feature / Issue

When a user clicks "chat" in the bottom nav, a chat mock-up appears. it's entirely static and merely indicates intended direction in a future release.

Acceptance criteria

Accepted when the functionality reflects that which is specified in the attached image.

Additional information

See attached image.

Newest Screen Designs

https://invis.io/HTF508H5Z
Contact David Gross if you do not have permissions to see.

NEEDED

• Explicit direction regarding what happens when someone clicks the chat interface. Nothing? Does it pop a little window that says "coming soon" with some examples of how it may be used?
  

Feature / Issue

The app must validate input to ensure the user doesn't add a value which could corrupt the Dapp or circumvent security

Acceptance criteria

See if we can get a review from Mawo, but reference this:

https://www.owasp.org/index.php/Input_Validation_Cheat_Sheet

Additional information

Issue

When running the light node I am getting this error: Failed to retrieve data from network err="no suitable peers available". See here for more details. It seem's like that it takes some time to solve the problem so it might be better to go with infura.io for this release. That's a bid more centralised but work's at least.

Feature / Issue

Show a series of screens when the app is first opened.
Do not show after user has created a profile or a private key.

Acceptance criteria

• Write 3-5 screens
• Get graphics for screens (be sure publishing rights are OK)
• Code screens in React Native

Additional information

Code "screens" as one javascript screen file, using swipe between the picture+texts.
Use "responsive" images, meaning be sure to resize to fit screen. The images provided should cover even the largest screen (iPhone X)
iPhone X screen is 2436 x 1125. Next largest is 1080x1920
Graphics are background images, I think we can go for 1080 x 1920 in size.

Feature / Issue

As a developer I need to access panthalassa.

Acceptance criteria

• Panthalassa installed
• Realm installed
• web3 is working
• Secure storage adapter for ios

Feature / Issue

This ticket pertains to the application's look and feel. Specifically, the:

• fonts
• color palate
• background image

Acceptance criteria

This issue is complete when every screen in the application utilizes the approved styling, pertaining to fonts, sizing, colors, and background image.

Application must take into account customization conventions regarding sizing, fonts, etc

Newest UI Design Screens

https://invis.io/HTF508H5Z

Additional information

See attached.

For clarification, contact Kent (@florianlenz can you add me so I can tag myself pls?)

Latest colors and styles can be found in the Newest UI Design Screens.

Feature / Issue

As a user ... Cows are nice to me.
I sure like them.

Acceptance criteria

• When i ... then ... (remove this)

Additional information

For some reason, this is NOT sync'd in GitHub?

Issue

Panthalassa (an external lib) is mostly written in flow (flow is an opt in type checker (like typescript)). When I start the project with yarn run ios it's starting correct (no transpile errors). BUT when I run the test's I am getting this error:

Test suite failed to run

/Users/florian/project/BITNATION-Pangea-mobile/node_modules/BITNATION-Panthalassa/src/specification/secureStorageInterface.js:7
export interface SecureStorage {
^^^^^^

SyntaxError: Unexpected token export

34 | return sSImplementation;
35 |
> 36 | }
37 |

at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/script_transformer.js:318:17)
at Object.<anonymous> (src/services/panthalassa/secureStorage.js:36:181)
at Object.<anonymous> (__tests__/src/services/panthalassa/secureStorage.js:1:109)

Basically jest don't use babel correctly.

Acceptance criteria

• External flow files should be transpiled as well.

Feature / Issue

Fixes

• Verify Private Key: Testing Mode, so I don't have to enter all words to test UI! Moved to issue #108.
• Either we create a graphic to demonstrate the screens, OR we have to make a reduced version with 24 words. Use graphic in UX-UI/UI/Production/Assets/demo-secret-key-entry.png
• Create Private Key: Remove "Previous" on first screen showing rows of words to write. Make "Previous" inactive on first row.
• Create Private Key: Remove "Done" on all screens showing words to write.
• Create Private Key: Next on 4th screen (last of Group 1 of words) shows an alert, which leads to the second group of words. However, when using previous to go backward, if alert has been shown, to NOT show it again when using Next. That is, the alert shows once, then not again.
• Create Private Key: Next on last screen (which shows words 20-24) shows an alert. The alert "OK" goes to "Verify Key"
• After previous "OK", we do not go to "Congradulations" screen, we go to Verify Secret Key.
• Verify Private Key: Remove "Done" until very end.
• Verify Private Key: "previous" and "next" should go to group 1 and group 2 screens, not prev/next words.
• Verify Private Key: "Done" should appear on keyboard only if all words filled out correctly. Same as "Done" at top of screen.
• Verify Private Key: Do not allow entry of uppercase letters.
• Text on many screens follows the InVision UI designs, but the UX has new text which should be used. Sorry. (Low priority!)

Feature

We need to connect the pangea lib's wallet with the UI in order to send / receive eth.

Acceptance criteria

• send eth
• receive eth
• sync accounts

Additional information

• Keep the promise rejection in mind

Feature / Issue

If the user has not uploaded a picture, we must show a generic avatar

Acceptance criteria

• PNG file of avatar

Additional information

Files for use are below as comments.

UI Graphic Design Fixes

Acceptance criteria

Additional information

When I try to run the app, I got the following error.

$ npm run ios

Error: src/services/container.js:19 19: const ethWeb3Instance = web3(ethDaemon, ee, ethUtilsInstance); ^^^^^^^^^^^^^^^^ EthUtilsInterface. This type is incompatible with the expected param type of 15: export default function web3Factory(node: JsonRpcNodeInterface, ethUtils: EthUtilsInterface, networkAccess: boolean): Promise<Web3> { ^^^^^^^ boolean. See: node_modules/BITNATION-Panthalassa/src/ethereum/web3.js:15

This error is occurred in Panthalassa, please fix this issue quickly.

Feature / Issue

iOS and Android have specific requirements for app icons, loading screens, etc., required for publication.
Android store is Google Play store.

Acceptance criteria

• Design App Icon
• Create iOS versions of app icon
• Create Android versions of app icon
• Create iOS versions of loading screens
• Create Android versions of loading screens

Additional information

Assume we are publishing to Google Play store.

Feature / Issue

In order to see screens, debug, and design the app, I have to be able to change modes, and get assets, etc., without going through long processes.
For example, to see the wallet, I need a way to magically get a wallet without going through the long secret key process.
Like with video games: you don't want to play to level 65 every time you want to see the colors on screen 65!

Acceptance criteria

• TURN ON/OFF refresh from blockchain.
• DO NOT MAKE ANY CHANGES ON THE NETWORK.
• ALL testing code must be in a single module. No testing code can exist inside the real code.
• Internal event system to update the UI must work, e.g. change a nation definition and the UI gets the message and updates, in all places (Nations, Dashboard, etc.)

Nations:

• Ability to edit Nation to see how it looks (local data)
• Quick creation of test nation, e.g. "My Test Nation"
• Quick creation of 15 test nations with different names (long and short), to see lists of nations. Nations should have different status: (draft, pending, active, rejected)

Wallet:

• Quick create a wallet
• Delete existing wallet (to start from beginning of process)
• Add money to wallet
• Set wallet to 0 ETH
• Set wallet to not enough money to create a nation (to see failure)
• Set wallet to enough money to create a nation (to see success)

Profile:

• Delete profile
• Quick create test profile

Chat:

• Quick create list of chats
• Quick create a chat with many messages

Dashboard:

• Sample log file of activities, to see in the Activity panel
• Quick create lists of nations (same as above)

Additional information

It is very hard and slow (and sometimes impossible) to debug and design without this system. Not having it is holding up a lot of my work.

Feature / Issue

If you import container from container.js the app will show an error like on screenshot

The same happened on device and iOS simulator

Acceptance criteria

Container to be loaded correctly

Feature / Issue

the ability for users to create and edit a profile.

Acceptance criteria

Satisfied when the application function and look and feel reflects that which is specified in the attached images and interaction flow (see associated ticket for look and feel)

Additional information

See attached images and document

Newest Screen Designs

https://invis.io/HTF508H5Z
Contact David Gross if you do not have permissions to see.

NEEDED

• Icons
• labels
• help verbiage authoring and approval