Comments (2)
LLFourn
commented on August 11, 2024
1
Note I did the change policy as a single value in #14
from coin-select.
evanlinjin
commented on August 11, 2024
@LLFourn's thoughts (bitcoindevkit/bdk#1072 (comment)):
So in my mind Target and DrainWeights would still be separate things just both exposed and settable publicly. Target would include the number of outputs and DrainWeights would include the number of outputs in the draining output. I also think you need to include the "base weight" in Target as it is coupled to the number of outputs.
Now I thought further -- if we create this invariant I think this also allows us to reduce the change_policy to a single integer -- i.e. the threshold of excess coin which should trigger the inclusion of the drain output. Wdyt @evanlinjin?
from coin-select.
Related Issues (16)
- Use `u64` for weights HOT 1
- `CoinSelector::run_bnb` should fallback to `select_until_target_met`? HOT 1
- Manually implement `Debug` for `Feerate`.
- Rename `FeeRate::spwu` to `sat_per_wu`
- Make `LowestFee` metric better HOT 1
- Remove debug `println!`s HOT 1
- Don't use `#` in README examples HOT 1
- Allow to target suitable transaction fee for RBF
- I'm wondering if this should have been `>=` instead of `>` . The `min_value_and_waste` change policy was previously returning change for excess equal to the min value. HOT 3
- Consider making `Drain` an enum, or using `Option::<Drain>::None` to represent no drain output(s). HOT 1
- Make `Changeless` metric more useful when combined. HOT 5
- ChangePolicy should be decided by metrics in branch and bound
- Rename `Drain` to `Change`
- CPFP: Allow telling coin selector that a candidate has unconfirmed parents HOT 1
- Option to calculate fee based on rounded-up vbytes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coin-select.