Giter VIP home page Giter VIP logo

Comments (3)

jp1ac4 avatar jp1ac4 commented on August 11, 2024

For this test, should it also check that if the change policy min value is 0 and the drain value is 0, then drain_value still returns None (i.e. we don't include a drain with zero value)?

EDIT: Perhaps it would be simpler to keep it as > and let the user set the min value accordingly.

from coin-select.

LLFourn avatar LLFourn commented on August 11, 2024

Well if we keep it as > we have to change the name since I read min as inclusive.

from coin-select.

jp1ac4 avatar jp1ac4 commented on August 11, 2024

Well if we keep it as > we have to change the name since I read min as inclusive.

I agree, I think it's better to change it back to >=. I can try working on this if you like.

from coin-select.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.