bitcoinjs / bs58check Goto Github PK

Example

var bs58check = require('bs58check')
var decoded ='18e559fc6cb0e8de2ce8b50007d474a0d886208e698a07948671e0df520c1525';
console.log(bs58check.encode(decoded))

ERROR "TypeError: buf.copy is not a function".

PS: see also http://stackoverflow.com/q/43599252/287948

chr15m/bugout#6 (comment)

var bs58check = require('base58check');
console.log(bs58check.decode('5Kd3NBUAdUnhyzenEwVLy9pBKxSwXvE9FMPyR4UKZvpe6E3AgLr'));

$ ./node_modules/.bin/browserify -s size size.js | ./node_modules/.bin/minify > size.min.js && du -h size.min.js
320K	size.min.js

Please fix URLs in package.json
OOI: why this repo in bitcoinjs org? not in cryptocoinjs?

I think isValid it will be helpful, if you agree, I add this feature to base-x, bs58 and to bs58check.

3.0.1 returning a Unit8Array instead of a Buffer broke our node.js application.

It's a bit frustrating there is no changelog indicating the new version no longer returns a buffer. And the example still shows a Buffer being returned. I had to check the commits to track down the cause.

Decred use blake-256 instead sha256.
Any ideas how other functions except sha256 can be used here?
New packages bs58check-base/bs58check-blake256/bs58check-sha256?

I'm suggesting these because they are the labels that I've seen used most often. Either use the full description "base58check" or abbreviate "base" as "b" instead of "bs".

https://en.bitcoin.it/wiki/Technical_background_of_version_1_Bitcoin_addresses

converting:
00010966776006953D5567439E5E39F86A0D273BEED61967F6
to:
16UwLL9Risc3QfPqBUvKofHmBQ7wMtjvM

does not work -_-

I have a feeling that the address is wrong on the website though. Just checking.
I get this:
csU3KSAQMEYLPudM8UWJVxFfptcZSDvXF1LYM

I don't know why this didn't happened earlier. It's very common operation (as rmd160(sha256(x)), probably also need own module?). We can put this package to crypto-browserifycryptocoinjs org.

/cc @dcousens @jprichardson

Thoughts about custom checksum function as optional argument?
for example Decred uses double blake256 instead double sha256

cc @dcousens @jprichardson