Hello James , Thanks for sharing knowledge , i am trying to run your contract in Remix ide and struggling get it working. I am afraid i am getting error in pragma solidity ^0.4.11; I have tried to pass the address hardcoded but no luck .

While invoking deploy function with addresses as parameter i am getting error , i have tried to add the local remix address with /without different braces/both cases letters/with/without comma but no luck , please advice what i am doing wrong - i have chosen 1st address of remix for contract and 2nd address for buying and 3rd contract for seller.

{'0X14723A09ACFF6D2A60DCDF7AA4AFF308FDDC160C' , '0X4B0897B0513FDC7C541B6D9D7E929C4E5364D2DB'}

Hope for help.

Kind Regards
raky

https://github.com/James-Sangalli/learn-solidity-with-examples/blob/master/Finance/bitcoin-to-ethereum-swap/BtcParser.sol#L296

Function: https://github.com/James-Sangalli/learn-solidity-with-examples/blob/master/Finance/bitcoin-to-ethereum-swap/BTC2ETH.sol#L79

Wanted to let you know
https://github.com/James-Sangalli/Solidity-Contract-Examples/blob/8b4889cfc67abc7debdc6a4cd6d688f0d2157e3e/Finance/bitcoin-to-ethereum-swap/BTC2ETH.sol#L353-L355 shouldn't work.

As a start, the method is verifyTx. But you shouldn't need to use dynamic calling: you should be able to give the btcrelay variable a contract type, instead of address, so you can then do btcRelay.verifyTx(...)

Allow attestations to be possible inside the contract via approved party signatures

I was using the mentioned script, and I may have uncovered an error. The script throws() in the buyerOrSellerOnly modifier, when the buyer calls it. Your conditional is a little off. Will you honor a pull request?

• User can place an order by locking up a small deposit of eth for a set interval of time (enough time for them to make the btc transaction and receive confirmation). This locks a portion of the eth in the contract just for them.
• When making a deposit, the user set's their btc details including their address
• User receives an order id
• After user sends btc, they can claim the eth and get a refund for the deposit
• If the user does not send the btc and the time lapses, the deposit is given to the MM and the eth becomes available again