Comments (8)
@shochdoerfer: I just tested the new major phpstan version out by hacking my composer dependencies like so:
"require-dev": {
"bitexpert/phpstan-magento": "^0.9.0",
"phpstan/phpstan": "1.0.2 as 0.12.99"
},
This allowed me to install phpstan version 1.0.2 in combination with 0.9.0 of this module.
And executing phpstan works perfectly fine, so it looks like your module works without issues on version 1 of phpstan (not sure if my code covers all your features, so don't take this as your module is 100% compatible yet).
But in case it's discovered that this module works 100% fine with version 1.0 of phpstan, I would suggest to change the version constraints in your module to:
"phpstan/phpstan": "^0.12.23 || ^1.0"
This will allow people to keep using your module in a Magento 2 project, and also allow people that are using your module outside of a Magento 2 project to already upgrade to version 1.0 of phpstan.
from phpstan-magento.
FYI: phpstan 1.x is also coming to Magento: magento/magento2#34555 π
from phpstan-magento.
@hostep stop doing MY job :P Had this on my todo list as well...
from phpstan-magento.
Quick update: Have to create a separate release for PHPStan 1.1 as a few internal changes broke the tests. That means we have a release 0.10 of the extension which supports PHPStan 0.12 and a release 0.11 of the extension to support PHPStan 1.1.
from phpstan-magento.
@sprankhub @hostep what are your thoughts on the PHPStan upgrade to version 1.0?
from phpstan-magento.
The 0.12.x versions won't get any more updates https://twitter.com/OndrejMirtes/status/1455083738564542467
from phpstan-magento.
If 0.x does not get any more updates, I think we should update to 1.0.
from phpstan-magento.
@hostep thanks for your analysis. Very much appreciated. Good to know that things seem to work in both versions.
I feel there might be an issue with some dependencies as can be seen here. I recall having read something similar somewhere in the PHPStan release notes or a tweet by OndΕej. I will investigate if this is fixable easily for both versions.
"Worst-case" approach would be to release a version 0.10 of the extension which would be compatible with 0.12 of PHPStan and a version 0.11 of the extension which is compatible with PHPStan 1.0 and maintain both for a while.
from phpstan-magento.
Related Issues (20)
- Missing check when using factory constant HOT 1
- No coverage data is *not* sent to Coveralls
- Certain CI steps run several times without additional result HOT 1
- Move stubs out of src/ HOT 6
- DateTimeFactory Issue; HOT 6
- Use Magento root for TestFrameworkAutoloader HOT 8
- Project config file at path app/code/Vendor/Module does not exist. HOT 5
- Factory generation misnames output class HOT 4
- Current release version not updated HOT 5
- Wrong directory used as "magentoRoot" when current working direcory is not magento root HOT 2
- private string $magentoRoot; not work in PHP 7.2 HOT 4
- Generated class ProductExtension is passed on incorrectly to phpstan HOT 30
- Missing Interface class HOT 9
- Add support for PHP 8.2 HOT 3
- Compatibility with PHPstan 1.10.x HOT 4
- Failure with `phpstan/phpstan-phpunit` and PHPStan cache usage HOT 19
- Version 0.30.0 fails with errors about unexpected items in parameters HOT 4
- Extend ci_neon_lint script to validate parametersSchema
- Incompatibility with phpstan & rector and 2.4.6 HOT 1
- Internal error: Class\Foo does not exist and has no extension interface in file class.php HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpstan-magento.