Currently, the version constraint <a href="https://github.com/bitExpert/phpstan-magent

Awesome, thanks a lot <a class="user-mention notranslate" data-hovercard-type="user" d

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

Allow package to be installed with phpstan 0.12.x about phpstan-magento HOT 4 CLOSED

bitexpert commented on July 23, 2024

Allow package to be installed with phpstan 0.12.x

from phpstan-magento.

Comments (4)

hostep commented on July 23, 2024 1

Awesome, thanks a lot @shochdoerfer!

Looks like it works perfectly after quickly testing it out over here.

Great job!

from phpstan-magento.

hostep commented on July 23, 2024

Hmm, it is probably not as easy as I would have guessed due to some backwards incompatible changes which got introduced in version 0.12.0 of phpstan, here are some errors I ran into while messing around a bit:

PHP Fatal error:  Class bitExpert\PHPStan\Magento\Reflection\MagicMethodReflection contains 7 abstract methods and must therefore be declared abstract or implement the remaining methods (PHPStan\Reflection\MethodReflection::isDeprecated, PHPStan\Reflection\MethodReflection::getDeprecatedDescription, PHPStan\Reflection\MethodReflection::isFinal, ...) in vendor/bitexpert/phpstan-magento/src/bitExpert/PHPStan/Magento/Reflection/MagicMethodReflection.php on line 20

PHP Fatal error:  Class bitExpert\PHPStan\Magento\Reflection\MagicMethodReflection contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PHPStan\Reflection\ClassMemberReflection::getDocComment) in vendor/bitexpert/phpstan-magento/src/bitExpert/PHPStan/Magento/Reflection/MagicMethodReflection.php on line 22

PHP Fatal error:  Class bitExpert\PHPStan\Magento\Reflection\MagicMethodParameterReflection contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PHPStan\Reflection\ParameterReflection::getDefaultValue) in vendor/bitexpert/phpstan-magento/src/bitExpert/PHPStan/Magento/Reflection/MagicMethodParameterReflection.php on line 20

Good to know:

phpstan is now being delivered as a .phar file via composer since 0.12.0 (which makes it hard to find its source code in a local project)
the source code of phpstan is moved to https://github.com/phpstan/phpstan-src/

from phpstan-magento.

shochdoerfer commented on July 23, 2024

@hostep thanks for opening this issue. Sure we can upgrade the package to support the latest version of PHPStan. Would you be able to contribute a MR for this?

Looks like we better start versioning this package to support multiple versions for PHPStan...

from phpstan-magento.

hostep commented on July 23, 2024

Hi @shochdoerfer

I could look into creating a MR, but might take me a while, bit busy with a lot of things at the moment.

It might be possible to introduce a fix in a backwards compatible fashion though, but further investigation is needed.

from phpstan-magento.

Recommend Projects