Comments (10)
Friendly reminder now that Magento 2.4.4 has been released in pre-release (should you have access to that program) 🙂
from phpstan-magento.
Fixed!
from phpstan-magento.
Version v0.20.0 of bitexpert/phpstan-magento
just got released!
from phpstan-magento.
You are welcome. Yes, once Magento 2.4.4 is released, those constraint needs to be added. Hopefully, we won't run into issues, but that needs to be tested. Since I don't have beta access, I can test this once 2.4.4 is GA. I could imaging being some issues due to PHP 8.1 support. The worst case would be to rip out laminas/laminas-code
.
I don't yet want to add the dependencies as I am not sure what would happen when Composer can't find the dependencies (for the local development install).
What you could do for now, is to make use of inline aliases, see here: https://getcomposer.org/doc/articles/aliases.md#:~:text=It%20is%20rather%20common%20that%20someone%20will%20want,as%20dev-develop)%20dev-%20must%20prefix%20the%20branch%20name.
from phpstan-magento.
Thanks @shochdoerfer, I was able to get everything running before your last comment and forgot to report back.
So: phpstan (and this extension) ran fine without any problems at first sight, no weird errors or new problems found. I did indeed solve the problem temporarily with this constraint "laminas/laminas-code": "4.5.1 as 3.5.1"
So it sounds promising in that the upgrade of laminas/laminas-code
seems to cause no issues (at least not in my case).
from phpstan-magento.
Does your new project make use of extension attributes? I am asking because laminas/laminas-code
is currently only used in the generators for the extension attribute classes and interfaces.
from phpstan-magento.
Ah, good to know. Unfortunately no extension attributes are being used.
So okay, this will need some proper testing indeed after Magento 2.4.4 gets released 🙂
from phpstan-magento.
@hostep I have some bad news for you, I will be on holiday for the next 2 weeks ;( Can you prepare a PR for this? Merging and releasing should be possible for me though.
Making sure CI runs with PHP 7.4 & PHP 8 might get ugly due to the committed composer.lock file, I have solved it for some other tooling like this: https://github.com/hivecommerce/magerun2-list-api-endpoints/blob/main/.github/workflows/ci.yml
from phpstan-magento.
No worries, I wouldn't consider this bad news, a holiday is always good in my opinion 😄
Let's see where the PR of Brent gets us (once 2.4.4 is released publicly) 🙂
from phpstan-magento.
No worries, I wouldn't consider this bad news, a holiday is always good in my opinion 😄
True, I just realized how eagerly you are waiting for the next release :)
from phpstan-magento.
Related Issues (20)
- Missing check when using factory constant HOT 1
- No coverage data is *not* sent to Coveralls
- Certain CI steps run several times without additional result HOT 1
- Move stubs out of src/ HOT 6
- DateTimeFactory Issue; HOT 6
- Use Magento root for TestFrameworkAutoloader HOT 8
- Project config file at path app/code/Vendor/Module does not exist. HOT 5
- Factory generation misnames output class HOT 4
- Current release version not updated HOT 5
- Wrong directory used as "magentoRoot" when current working direcory is not magento root HOT 2
- private string $magentoRoot; not work in PHP 7.2 HOT 4
- Generated class ProductExtension is passed on incorrectly to phpstan HOT 30
- Missing Interface class HOT 9
- Add support for PHP 8.2 HOT 3
- Compatibility with PHPstan 1.10.x HOT 4
- Failure with `phpstan/phpstan-phpunit` and PHPStan cache usage HOT 19
- Version 0.30.0 fails with errors about unexpected items in parameters HOT 4
- Extend ci_neon_lint script to validate parametersSchema
- Incompatibility with phpstan & rector and 2.4.6 HOT 1
- Internal error: Class\Foo does not exist and has no extension interface in file class.php HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpstan-magento.