bjmllr / unnatural Goto Github PK

Thanks for this gem, it's much faster than any of the other ones.

We've run into an issue that is easy to work around but I thought it worth reporting so it can have a better check than a segfault.

Issue: Passing an array of non-strings creates a segfault.

Expectation: Error message, exception, or automatic conversion to string.

Actual: the Ruby interpreter dies, taking the whole server down with it.

Reproduce:

Unnatural.sort([1, 2, 3])
# => segfault

Unnatural.sort([1..5, 8..6])
# => segfault

Unnatural.sort([:one, :two])
# => segfault

# ironically does not segfault:
Unnatural.sort([Object.new, Object.new])
=> [#<Object:0x007fdee21af130>, #<Object:0x007fdee21af108>]

We can, of course, use to_s with sort_by but I don't think it should break everything with the wrong type. 😄