bjoerge / weigh Goto Github PK

According to the readme, you can pass NODE_ENV=production, to get pass this onto envify et al.

With the latest version of npm, this seems to fail - weigh crashes:

espenh@ambrose ~/webdev/weigh $ NODE_ENV=production weigh ascii-doge
⠏ Downloading ascii-doge, this may take a little while…/home/espenh/webdev/weigh/lib/installPackages.js:72
  return Object.keys(dependencies)
                ^

TypeError: Cannot convert undefined or null to object
    at packagesToArray (/home/espenh/webdev/weigh/lib/installPackages.js:72:17)
    at /home/espenh/webdev/weigh/lib/installPackages.js:64:16
    at ChildProcess.exithandler (child_process.js:198:7)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:852:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:5)

After some digging, it seems npm ls changes behavior when NODE_ENV is set to production - but I can't find any documentation stating why, or how. This might be related: npm/npm#12579

Regardless of this, I'm wondering if perhaps it would be a better option to pass a --production flag, or similar? In fact, I'd actually prefer if weigh always gave me the size of production bundles, since that is what I'm usually basing my decisions on. Thoughts?

npm ls errors on extraneous packages and triggers the peer missing message.

• weigh request shows it because of npm ERR! extraneous: [email protected]
• weigh got shows it because of npm ERR! extraneous: [email protected]

It seems to be the usage of --prefix that does it (reproduced by hand), but hopefully that doesn't mean prefix changes npm's installed tree structure-- well, I did a quick search and found npm/npm#20148, so maybe it does. I don't know what to do, otherwise I would try and go make a PR.

Currently $ weigh error/typed fails because it tries to install the package error/typed. Instead it should install error, and then browserify error/typed.

e.g. if npm install cannot find the package, if browserify fails, etc.

I'm not sure if this is outside the scope of the project or not, but a nifty feature would be if running weigh from a directory that contains a package.json file would take the dependencies declared there into account.

For example, if I am in a directory that contains a package.json that looks like this:

{
  "name": "example",
  "dependencies": {
    "react": "^16.2.0",
    "react-dom": "^16.2.0"
  }
}

And I run weigh react-wysiwyg, the output could be:

$ weigh react-wysiwyg

Approximate weight of react-wysiwyg, excluding dependencies already installed in this project:
  Uncompressed: 679 kB
  Minified (uglify): 166 kB
  Minified and gzipped (level: default): 45 kB

This could alternatively be turned on via an option instead.

My main motivation for this would be determining how much extra filesize would a new dependency add to my project, excluding sub-dependencies that I already bundle.

e.g. cat index.js | weigh.

With #6 in place this also makes it trivial to weigh a pre-built file from a remote address:

curl https://cdnjs.cloudflare.com/ajax/libs/jquery/2.2.1/jquery.js | weigh

It would be nice to be able to weigh a file without bundling it. Useful if you have a pre-bundled file:
weigh ./react-with-addons.js

Could be supported with a --no-bundle flag that skips browserify entirely

Hey @bjoerge, thanks for a great module :-)

Maybe I'm doing something wrong, cause I can't get it to work correctly with local modules.

Weighing a local module like so:

$ weigh ./most-w3msg
Approximate weight of ./most-w3msg:
  Uncompressed: 454 B
  Minified (uglify): 448 B
  Minified and gzipped (level: default): 289 B

And weighing the same module via npm:

$ weigh most-w3msg
Approximate weight of most-w3msg:
  Uncompressed: 6.62 kB
  Minified (uglify): 1.64 kB
  Minified and gzipped (level: default): 681 B

Weighing any other local directory also yields 289 B. Am I doing something wrong?

This is Node v6.3.0 and npm v3.10.6.

Would be nice to visualize the module tree with https://github.com/hughsk/disc

This is the error:

Seems that something went wrong with bundling.

Is this caused by their module setup 🤔
https://github.com/RobertWHurst/Keystrokes