bjornsallarp / commercetools-dotnet-sdk Goto Github PK

see https://dev.commercetools.com/http-api-projects-customers.html#customers-password-reset

HttpClient is meant to be reused even though it implements IDisposable. Microsoft has more information about the performance implications here: https://docs.microsoft.com/en-us/azure/architecture/antipatterns/improper-instantiation/

Furthermore Client does not offer a way to customize the creation of HttpClient. Currently it is always created with a custom logging delegate handler that adds an unnessesary dependecy on log4net and always allocates large strings even when log4net is not actually used.

By overloading the constructor with an HttpClient argument the log4net depenceny can be removed entirely and allow library consumers to inject any kind of delegate handlers for logging, performance etc. Perhaps the log4net handler could be moved to "examples" instead.

The way response models are created in Client is not optimal. Compiling lambdas is good but also very costly. What would really make a difference is caching those lambdas. It's also worth investigating if emitting IL is even faster than compiled lambdas.

See https://dev.commercetools.com/http-api-projects-customers.html#customers-email-verification