Don't laugh but, some people requested modules to be separated into their own files, this can be useful and I quote I most of the time delete modules from addons folders instead of having their files loaded but modules disabled in-game...

Skada version 18.45
As you can see in my screehshoot it does show wrong casted spells like Cheap Shot from Death Knight and Teleport Monastery from Dk pet ghoul .

Hi,
I have the newest version of the addon downloaded and I get these lua errors during boss encounters:
https://i.ibb.co/d4zGNQ2/lua1.png
https://i.ibb.co/jGvLR8p/lua2.png

I hope this can help in a way.

Regards,
Wojas

Describe the bug
Hodir fight in ulduar is only tracking phase 1, not any damage on boss. After you kill all the adds in the arena, the roleplay starts and skada just stop working for the fight. Previous version of skada didnt have this problem

Hey!
I'm only making this to remember about this:

Window 1 always opens upward; while windows 2 and 3, as expected, expand to where there is more free space.
The same thing happens when you open these settings by right-clicking on the addon icon on the minimap.
The same thing happens with the Elvui skin too.

Greetings,

I know it sounds weird, but is there any way to save a fight's Skada report out of the game somehow? Where should I look at, is it saved in the WTF folder? Also I presume it won't contain names, just strings/HEX ids for the spells and such, is there a way to convert those?

Both of these errors appeared when I applied http://www.cavernoftime.com/?item=22218 on a draenei paladin. I play on the ruRU game client.

Hey!
I really couldn't fully test newest absorbhealing yet, but I played few fights and it seems to be nice. But nobody had val'anyr and this is what I'm most interested in - discipline priest and other healer with val'anyr. I'll update you as soon as I play full raid.

About the topic:
Sometimes after logging in or joining raid I see red squares instead of role, class or spec icons. In most cases they start appearing properly after some time or after few encounters. THREAT module almost never shows icons properly for me. Is it just mine problem?

And other question - spec icons are copied from talents or is it possible to change how certain spec looks?

Can you somehow remove this extra space?

And i have 1 question, skada-revisited still share data between themself? And with old-skada? If so, can we have option to turn off this function?

Why is this needed?
I recently ran into a situation like this:
The raid killed the boss, I got out of combat, but the data in skada still kept changing for ~ 20 seconds or more - I assumed that from a few bugged players there was information that the combat still ongoing.

Hey!
Today I checked absorbs/absorbs+healing module during the raid. There is something seriously bugged with the absorbs. I'm showing 2 encounters as examples, but I had pretty much the same on every boss (on the right side you can see logs):
https://i.ibb.co/CH6dJ89/image.png
https://i.ibb.co/D7XPHfP/image.png

1. Priest's absorbs go mostly to Divine Aegis talent. It is impossible to have such low absorbs with Power Word: Shield.
2. Paladin's sacred shield seems to be showing some very high numbers. It is impossible to absorb so much per hit (maximum absorbs).
3. Druid Valanyr's absorbs are almost not counted or go to someone else's absorbs. It also shows for many bosses that absorbs were done to only 1-3 players and valanyr bubbles were on almost everyone.

I do NOT expect to have exact same numbers as logs, but these values are seriously wrong. I hope screenshots help. If u need more info ask here please.

Regards,
Wojas

You should move the whole repo into a folder named "Skada", otherwise extracting the archive in any way into the addons folder of wow is not gonna work unless you rename the folder to "Skada".

Also this seems to be standard for all the addon repos I've seen so far.

Hello,
first of all I must say I really like what You did with Skada and how you rewrote it. It is now very smooth and there are many useful things inside.

I don't know whether you want people to give you suggestions what could be changed within the addon, but I if you don't mind I have some ideas.

1. Damage taken details:
   It is very nice, that you added possibility to check what spell/attack did how much damage on certain person (damage taken -> player -> list of spell/attacks). However maybe you could tweak "melee" source, since at the moment every melee attack made against player X is added together. During some encounters players (especially tanks) take melee damage not only from bosses but also from some adds (for example The Lich King encounter: ghouls, shambling horrors, etc). I have no idea how hard would this be, but maybe "melee" position could be listed like this:

1. Melee (source1) 1.34M
2. Melee (source2) 500K
3. Spell1 200K
4. Melee (source3) 150K

Also when I move mouse over the melee source I get info for max, avg, min hits (which is actually very important option: https://i.ibb.co/ZTwBB2q/image.png), but those values are added and averaged from every source. This is why maybe what I proposed would be more clear in a way.

If what I wrote above is too hard to implement, then maybe it could be put in different location:
Damage taken by spell -> Choose Melee -> and here chosing a player would move to next location with list of sources. Hovering mouse over certain source would show tooltip box with max, avg, min, damage and etc.
or
Enemy damage done -> Choose Boss -> and here chosing a player would move to next location with list spells/attacks. Hovering mouse over certain source would show tooltip with max, avg, min, damage and etc.

Adding all of these is probably pointless, but adding 1 of the 3 above could help a lot to see how much boss hits on average.

2. Fails:
   There are two fails (already added by you), that could have more detailed description in the list.

a) Lady Deathwhisper Vengeful Shade/Vengeful Blast:
Today I tested it on normal difficulty, but I'm more interested in how it works on heroic version. On Hc they deal AoE damage when they catch their target and this can wipe the raid if all 3 shades hit melee target. So today from normal I see something like this: https://i.ibb.co/HG1Yvnj/image.png
and logs from same raid show something like this: https://i.ibb.co/spS1dQk/image.png
For some reason player Macieq i missing in fail list (I scrolled whole list) and also Deatrue got hit 3 times by vengeful shade instead of 1.
So what I'm interested in (unless it is too complicated) is to somehow show how many times player X triggered explosion of Vengeful Shade. If there was a list with time of each explosion then it would be perfect, but I assume this would be really hard to add.
Or maybe it would be easier to add this thing to Friendly Fire tab? I mean like when player X triggers explosion then damage done to all players from Vengeful Blast is added here. But maybe it is too hard too - I don't know.

b) Sindragosa Instability/Backlash:
So this I also haven't tested on heroic yet, but situation is somehow similar as above. Backlash on heroic deals AoE damage and could be either treated as friendly fire (if possible) or could be more detailed in Fails tab - each backlash explosion is treated separately and for each explosion there is info how many stacks exploded dealing how much damage (on hover over backlash). But maybe this is too hard too. For now I could only find these 2 (https://i.ibb.co/JpnPY7W/image.png)

BUT once again - I really like the revised addon already and I'm probably going to use it instead of the old Skada. Please, don't treat my suggestions as complaints. These are only my thoughts.

Regards,
Wojas

Skins may be removed from the repo after ElvUI-WotLK/ElvUI_AddOnSkins#155 is merged into the main repo

This screenshot has taken after a "skada reset" and relog. Isn't it "a bit" high?

Date: 2020-11-30 03:36:47
ID: 1
Error occured in: Global
Count: 134
Message: ..\AddOns\Skada\Skada.lua line 1136:
Usage: GetPlayerInfoByGUID("playerGUID")
Debug:
(tail call): ?
[C]: GetPlayerInfoByGUID()
Skada\Skada.lua:1136: FixPlayer()
Skada\Skada.lua:1220: get_player()
Skada\modules\Damage.lua:79:
Skada\modules\Damage.lua:78
Skada\modules\Damage.lua:235: func()
Skada\Skada.lua:3038: ?()
...ibDataBroker\CallbackHandler\CallbackHandler-1.0.lua:147:
...ibDataBroker\CallbackHandler\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[21]"]:4:
[string "safecall Dispatcher[21]"]:4
[C]: ?
[string "safecall Dispatcher[21]"]:13: ?()
...ibDataBroker\CallbackHandler\CallbackHandler-1.0.lua:92: Fire()
...s\ElvUI\Libraries\Ace3\AceEvent-3.0\AceEvent-3.0.lua:120:
...s\ElvUI\Libraries\Ace3\AceEvent-3.0\AceEvent-3.0.lua:119

Hm I got this bug and it broke my combat log, hence I did zero damage (lmao).
I also use combat log fix macro if it helps you for more information.

function Skada:MemoryCheck()
    UpdateAddOnMemoryUsage()
    local mem = GetAddOnMemoryUsage("Skada")
    if mem > 30000 then
        self:Print(
            L["Memory usage is high. You may want to reset Skada, and enable one of the automatic reset options."]
        )
    end
end

I don't care about addon memory usage, but I'm really worried when, due to memory check function, fps drops to zero :(

hey @bkader !
Today I noticed, that Power gained: Mana module is not working properly. Here's example of what I had after boss fight:

There's no replenishment or Innervate at all. Mana Tide has too much mana restored (it is impossible for 1 mana tide to restore so much mana).

I asked friend to show me what he saw on his addon:

Tese values seems more correct, HOWEVER I used mana potion and his addon didn't show that.

Another question:
Should buffs module show only my buffs? Or should I see buffs I get from other players too? Like replenishment?

Regards,
Wojas

Hello,
Today my friend have sent me link to your revisited Skada. I was pretty hyped and downloaded it but it for some reason I couldn't get it to work (was not loading into the game despite showing in addon selection on logging screen). My friend gave me 1 week old version and it is working fine (he could not load newest version too). No idea what is the problem.

Regards,
Wojas

When reviewing the damage / healing of two classes with equal branches for example 2 fury warriors, when clicking on the damage done the pop-up description shows the correct information but having two damage windows, and buying the damage of both, a detail occurs when place the mouse to see the pop-up box shows the information of the other player not the main one.
In this example it was a dungeon (I had found the detail with 2 heals shamans)

1. I have two skada windows.
2. On the left I place one and on the right the other
3. When hovering over to see the pop-up information, the pop-up information of the warrior on the right appears in the warrior on the left.

Note: I have the last update of the skada with cache and wtf files deleted

Left warrior

Right warrior

Because segments are named according to the first attacked mob, I shall implement a check to rename both segments properly.

Hey, currently I'm struggling to check whether rogue or hunt spend their TOT/MD correctly. I know about a Buffs window that can show the total usage of TOT/MD's but it's not really what I'm looking for.

Would be awesome to add module that shows the exact amount of TOT/MD's that where used and their targets.

P.S. If you can make some suggestion on how to faster implement it - I probably could help with that, although I'm mostly working with JavaScript (Node.js) I could learn something new :)

Date: 2021-06-02 04:39:50
ID: -1
Error occured in: Global
Count: 1
Message: ...erface\AddOns\Skada\Libs\LibFail-1.0\LibFail-1.0.lua line 2261:
attempt to compare number with table
Debug:
[C]: ?
...erface\AddOns\Skada\Libs\LibFail-1.0\LibFail-1.0.lua:2261:
...erface\AddOns\Skada\Libs\LibFail-1.0\LibFail-1.0.lua:2256
...erface\AddOns\Skada\Libs\LibFail-1.0\LibFail-1.0.lua:847:
...erface\AddOns\Skada\Libs\LibFail-1.0\LibFail-1.0.lua:832
AddOns:
Swatter, v5.8.4723 (CreepyKangaroo)
Ace3, v
AtlasLoot, vv5.11.04a
AtlasLootFu, vv5.11.04
DBMCore, v
ElvUI, v6.08
GearScoreLite, v3x04
LootCouncilLite, v1.011
Omen, v3.0.9
Quartz, v3.0.3.1
RaidBuffStatus, vv3.274
Skada, v1.8.50
SlideBar, v5.8.4723 (CreepyKangaroo)
SnowfallKeyPress, v
Stubby, v5.8.4723 (CreepyKangaroo)
WeakAuras, v3.2.3
BlizRuntimeLib_enUS v3.3.5.30300 <logon.whitemane.gg>
(ck=1a9)

When making a profile on a character with different windows, example: https://imgur.com/a/gvITLJy the position of the windows is saved when logging other characters on the same account. It puts 2 of the windows at the same position, Example: https://imgur.com/a/5xSsZJP

Hey @bkader
From time to time I still get red squares for icons, but today I have more info when they appear:

So in the top window (threat) I have ROLE set as icons. Red squares appeared for:

1. Pets
2. Feral druid (he also changed spec from tanking feral to dpsing feral few times)
3. Priest (she changed spec from disci to shadow few times)

They didn't fix with reload/relog/combatlog fix and stayed as squares for whole raid.
I noticed pet ROLE problem just yesterday, but for disci/shadow/holy priests or balance/tank/feraldps/resto druids ROLE icon turns into squares very often (sometimes it fixes after few encounters and sometimes not).
This issue now happens only for ROLE (class or spec work fine).

Regards,
Wojas

Hey, when I turn on this modified Skada, my Gnosis (castbar addon) stops working. When I use normal Skada for 3.3.5, this bug does not appear. Could you please fix it or tell me some hotfix?
I also attach two screenshots showing exactly the same situation with Skada on/off.

Could you please remove the rank numbers on spell details? I feel like it's rather unnecessary to show it.
https://imgur.com/a/Bz8wlVg

Skada 1.8.64

mode name - Power Gained, but for some reason in titlebar its Skada_Power Gained

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I haven't found any option for pixel perfectness for each skada window: x and y position (and height+width - edit: found it under bar options)

Describe the solution you'd like
A clear and concise description of what you want to happen.
Each window have a X, Y, (hieght width - edit: found it on bar options ) option in the GUI (like Weakauras for example)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
The draggers are not accurate enough for precision placement. One mitigator is add click modifiers to only drag height or width (like details)

Additional context
Add any other context or screenshots about the feature request here.
I'd add it in Window:

Example of WA position implementation:

Hello,
I often get wrong spec icon for MYSELF. Raid/party members are shown properly, but myself is often shown as red square or if I change spec then wrong icon is shown. Is that only my problem?

Hello. I had previously ported the cc done module and revised a grand majority of the cc spell ids. I'm at work but leaving this ticket open so I can upload the file when I can to give a contribution to this project

Hey,

As the title says, the addon isn't working until you join combat with other raid members/mobs, not like the original Skada, where it collects everything everytime.

This feature is from Details where we can edit the font size on the bar separately, meaning we can edit the font size of the name and the number separately since I sometimes wanna emphasize on the names rather than the numbers.

Alpha values and background texture not applying to title.

Can we see Overkill, Absorbed and Resisted damage in deathlog?

Now everything looks like this

-Time: SpellName   -RecievingDamage (HP, HP%)
0.00: AA   -28.5K (25.6K, 33.2%)
-1.74: Ice breath   -45.7K (20.2К, 26,2%)

Can we change this like

-Time: SpellName   -RecievingDamage [O: , A: , R:] (HP, HP%)
0.00: AA   -28.5K [O:2.9K, A:5K] (25.6K, 33.2%)
-1.74: Ice breath   -45.7K [A:8.1K, R:35.8K] (20.2К, 26,2%)

for Overkill, Absorbed and Resisted damage (which existed in combatlog)

SPELL_DAMAGE,0xF130008FF5000703,"Синдрагоса",0x10a48,0x0000000000346FB4,"Captainblac",0x80514,73064,"Ледяное дыхание",0x10,45694,0,16,35837,0,8063,nil,nil,nil

SWING_DAMAGE,0xF130008FF5000703,"Синдрагоса",0x10a48,0x0000000000346FB4,"Captainblac",0x80514,28514,2866,1,0,0,5031,nil,nil,nil

Please add Skada report compatibility for
https://github.com/ElvUI-WotLK/ElvUI_Enhanced/blob/master/ElvUI_Enhanced/Modules/Chat/DPSLinks.lua

Description:
This Skada doesn't record hunter's tranquilizing shot when they use it to dispel Shambling Horror's Enrage on Lich King Fight

Step to Reproduce:

1. Open Skada
2. Navigate to Dispels

Expected Behavior:
Hunter's Tranquilizing Shot should be recorded as Dispels.

Actual Behavior:
Hunter's Tranquilizing Shot isn't recorded as Dispels.

I also haven't raided Trial of the Crusader where Hunter can use Tranquilizing Shot to dispel enrage/magic, i.e Icehowl and Faction Champions. So I don't know if it works in TOC but in LK, their dispels aren't recorded as Dispels in Skada.

It does not matter what I select under columns, Skada always shows everything.
Full disclosure: I am playing on a german server and the german localization does look a little bit incomplete tbh. Maybe thats part of the problem.

Looking into it

I am trying to turn the background of the skada window transparent and I am not able to do so. This happens only when using the ElvUI Skin

I have tried turning opacity all the way down to 0 and setting texture to none, but still I'm not able

Removing the ElvUI skin fixes the problem

Hey @bkader !
I've just finished raiding with latest updates of skada and names of players get replaced with something like this:

Before this update I NEVER ever had unknown player on my list. Today during the raid ZERO players were Uknown.
I guess it is connected to this:

eeb6017#diff-d979dba22e2ec7ad07b0eed6e9a32aed325ae7248dc4a496ffe1eae0dd19a502

Regards,
Wojas

requests fixes for arena/ srry for english native russian speaker

1. can u do calculation of everything for the arena, like it should show arena name not name of ppl that i dmged / total of arena idk how to say it
2. and it doesnt show that what spell was resisted , like when i spam purge and purge will resisted it should count in addon and the end battle in arena it shows like u click into spell and ot shows how much this spell missed / dodged / parried / resisted and vs who it was resisted

After the latest update class icons have turned into red squares and bar colors are all blue now.
Also, I was only using damage done but now meter shows "DPS" and "%" too. I couldn't fix that.

Some people like to take a peek at Enemy damage taken or Enemy damage done modules to compare the damage they are doing on certain mobs to others. These modules were tweaked from the original and they no longer record any data by instead they read it from Damage and Damage taken modules respectively.

These modules will be updated to show real time numbers when clicking on a target.

Describe the bug
Mark of blood is not being tracked and attributed to DK.

To Reproduce
Use the spell in combat.

Expected behavior
Mark of Blood should show and attribute to DK's healing.

Video
N/A

Additional context
N/A

In Ulduar just doing nothing. Team started clearing.

Message: Interface\AddOns\Skada\modules\Damage.lua:380: bad argument #1 to '_pairs' (table expected, got nil)
Time: 04/09/21 23:00:27
Count: 1
Stack: [C]: ?
[C]: ?
Interface\AddOns\Skada\modules\Damage.lua:380: in function `Update'
Interface\AddOns\Skada\Skada.lua:1894: in function `UpdateDisplay'
Interface\AddOns\Skada\Skada.lua:2867: in function `EndSegment'
Interface\AddOns\Skada\Skada.lua:2906: in function `_callback'
Interface\AddOns\Skada\Skada.lua:3175: in function <Interface\AddOns\Skada\Skada.lua:3163>

Locals: 

Message: Interface\AddOns\Skada\modules\Damage.lua:380: bad argument #1 to '_pairs' (table expected, got nil)
Time: 04/09/21 23:01:02
Count: 353
Stack: [C]: ?
[C]: ?
Interface\AddOns\Skada\modules\Damage.lua:380: in function `Update'
Interface\AddOns\Skada\Skada.lua:1894: in function `UpdateDisplay'
Interface\AddOns\Skada\Skada.lua:2962: in function `_callback'
Interface\AddOns\Skada\Skada.lua:3175: in function <Interface\AddOns\Skada\Skada.lua:3163>

Locals: 

skada version - ce566e4 or 4efef4a

1. before GunshipBattle combat start i switched mode from DamageDone>Damage to Enemy>EnemyDamageTaken

2. after combat end, and before Saurfang fight i switched mode from Enemy>EnemyDamageTaken to DamageDone>Damage

3. then on trash fight (Precious, raid in combat, but i'm not) i switched segment from Current to Saurfang, and for some reason alongside with segment my mode switched too (from Damage to EnemyDamageTaken)

the window i'm interacting with - is the parent window

video with timings
https://youtu.be/o5MAFPHJZk4