Dynamic vertex buffers getting overwritten after bgfx::update about bgfx HOT 19 CLOSED

Don't know if ill have time today.

from bgfx.

Please create repro by modifying some existing example.

from bgfx.

how to build the examples?

from bgfx.

https://bkaradzic.github.io/bgfx/build.html#quick-start

from bgfx.

Any luck with repro?

from bgfx.

Sorry I've been gone for the past day ish. I should have it working by tomorrow

from bgfx.

Whenever you can.

from bgfx.

As i was trying to get the bug to work it ends up crashing on a call to bgfx::update() because of the fact that the initial memory size is for the buffer is 0, even though BGFX_BUFFER_RESIZEABLE is set. I don't know if this is intentional or not, and it might be connected to the original bug. I haven't been able to get the original bug to work in a simple example yet. If I cannot get it to work after a bit more playing ill probably just upload my code (with the bug).

Here is a link to a repo with the example code (just cloned bgfx and it is example 50 but it is in the example 5 folder). https://github.com/0xheron/bgfx

from bgfx.

Yes, you should have some number other than 0 as your number.
https://github.com/0xheron/bgfx/blob/7a0e660bd6802c343b1c8a8da4fa8f647399d3cb/examples/50-bug/instancing.cpp#L285

First argument here is start vertex (see https://bkaradzic.github.io/bgfx/bgfx.html#_CPPv4N4bgfx6updateE25DynamicVertexBufferHandle8uint32_tPK6Memory), so this code makes no sense:
https://github.com/0xheron/bgfx/blob/7a0e660bd6802c343b1c8a8da4fa8f647399d3cb/examples/50-bug/instancing.cpp#L305

from bgfx.

Also you're using bgfx::makeRef with data that's on the stack, which is incorrect too. You should use bgfx::copy instead.

from bgfx.

Also you're not releasing dynamic vertex buffer you're creating, which will cause leak.

from bgfx.

Thats just me being stupid then. That being said, on my code the bug still occurs with a fixed size.

from bgfx.

Oh, because I couldn't figure out the build system I ended up hacking one of the existing examples for the last 2 points. However i still am using 0 which is the main focus of this. (example 5)

from bgfx.

Also, the code that in my case causes the bug (could just be my fault again, but i have tried a few things) is here.
https://github.com/0xheron/engine

from bgfx.

134 & 135 are the lines of the bgfx::update call.

from bgfx.

Everything you need to know about build system is explained here:
https://bkaradzic.github.io/bgfx/build.html#getting-source

It's fine that you used existing example. You should just make it correct, so that repro of your issue you're claiming exist is focused only on the issue.

from bgfx.

Just out of curiosity, did you look at it anymore with some of the resources I sent? Also, sorry for not doing more with repro as I did fail to get a replicated copy of the bug and because I had a solution I didn't do anymore. Thanks for your time.

from bgfx.

I sent you my feedback here: #3126 (comment)

from bgfx.

Of the repro? Because that never demonstrated the bug I initially talked about. That was my bad as I rushed to finish it. However, after the fact I was still never able to replicate the bug in the repro context. At a certain point I decided it didnt matter for my case. However, it may affect someone else. The repo I posted, with a pretty self explanatory build system does demonstrate this bug, in case you want to look at it further.

from bgfx.