Multiple glyph encodings not included in in glif_list response about django-robo-cjk HOT 9 CLOSED

I confirm! (maybe just few ms due to this data manipulation, db queries are not changed).

from django-robo-cjk.

For reference: https://robocjk.black-foundry.com/admin/robocjk/characterglyph/893881/change/?_changelist_filters=font%3D6%26q%3Duni313B

from django-robo-cjk.

@justvanrossum now the unicode_hex field value contains all glyph encodings separated by comma, and there is a new unicodes field containing a list of unicodes as integers, but this is not available on all methods:

Unfortunately it's not possible to add the unicodes field to the glif_list API method without sacrificing performance: actually the glif_list method returns all glifs in ~1 second because it returns only a subset of each glif data directly from the database, returning the unicodes list slowdowns the response up to ~6 seconds, for this reason I think it's better to split the unicode_hex string on client side.

from django-robo-cjk.

Achieved in 39d5642 , not the cleanest solution, but probably the best compromise given the constraints.

from django-robo-cjk.

Did you confirm that the performance of glif_list is not negatively affected?

from django-robo-cjk.

@fabiocaccamo what was the PR or commit that resolved this?

from django-robo-cjk.

@justvanrossum in 6bad3ed I added support to multiple glyphs encoding, then in 39d5642 I added unicodes to glif_list response (there was a performance issue to solve first).

from django-robo-cjk.

But the task is now completed, right?

from django-robo-cjk.

Yes

from django-robo-cjk.