Giter VIP home page Giter VIP logo

crix-client-py's People

Contributors

r-raymond avatar reddec avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

crix-client-py's Issues

fetch_ohlcv returns duplicate entries and is missing candles

>>> x = client.fetch_ohlcv('ETH_BTC', s, datetime(2019, 2,1,9,30), limit=10) 
>>> x = [y.open_time for y in x]
>>> x
[datetime.datetime(2019, 2, 1, 9, 23), datetime.datetime(2019, 2, 1, 9, 24), datetime.datetime(2019, 2, 1, 9, 24), datetime.datetime(2019, 2, 1, 9, 25), datetime.datetime(2019, 2, 1, 9, 27), datetime.datetime(2019, 2, 1, 9, 28), datetime.datetime(2019, 2, 1, 9, 29), datetime.datetime(2019, 2, 1, 9, 30)]

it returns minutely candles for 9:23, 9:24, 9:24, 9:25, 9:27, 9:28, 9:29, 9:30, missing 9:26 and having 9:24 twice. I noticed that this happens about once a day in the history.

fetch_ohlcv seems to ignore limit on repeated calls

Python 3.6.4 session (Debian 9)

>>> x = client.fetch_ohlcv('ETH_BTC', datetime(2019,3,20), datetime(2019,5,22), limit=100)
>>> len(x)
100
>>> x = client.fetch_ohlcv('ETH_BTC', datetime(2019,3,20), datetime(2019,5,22), limit=1000)
>>> len(x)
100
>>> x = client.fetch_ohlcv('ETH_BTC', datetime(2019,3,20), datetime(2019,5,22), limit=1000)
>>> len(x)
100
>>> x = client.fetch_ohlcv('ETH_BTC', datetime(2019,3,20), datetime(2019,5,22), limit=10)
>>> len(x)
100
>>> x = client.fetch_ohlcv('ETH_BTC', datetime(2019,3,20), datetime(2019,5,22), limit=10)
>>> len(x)
100
>>> x = client.fetch_ohlcv('ETH_BTC', datetime(2019,3,20), datetime(2019,5,22), limit=100)
>>> len(x)
100
>>> x = client.fetch_ohlcv('ETH_BTC', datetime(2019,3,20), datetime(2019,5,22), limit=500)
>>> len(x)
100
>>> x = client.fetch_ohlcv('ETH_BTC', datetime(2019,3,20), datetime(2019,5,23), limit=500)
>>> len(x)
500
>>> x = client.fetch_ohlcv('ETH_BTC', datetime(2019,3,20), datetime(2019,5,23), limit=1000)
>>> len(x)
500
>>> x = client.fetch_ohlcv('ETH_BTC', datetime(2019,3,20), datetime(2019,5,24), limit=1000)
>>> len(x)
1000

Only if I change the datetimes, the new limit is adhered to.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.