Giter VIP home page Giter VIP logo

simc_support's People

Contributors

bloodmallet avatar github-actions[bot] avatar iout1aw avatar nuohep avatar scamille avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar

simc_support's Issues

Missing talent data

from simc_support.game_data import WowSpec
spec = WowSpec.get_wow_spec_from_combined_simc_name("Priest_Shadow")
print(spec.talents[2])

returns

{3: {'name': 'Intangibility', 'spell_id': 288733}, 2: {'name': "San'layn", 'spell_id': 199855}}

This seems to be missing talent with key 1, namely "Body and Soul"

Edit:

from simc_support.game_data import WowSpec
for spec in WowSpec.WOWSPECS:
  for i in range(1, 7):
    for j in range(1, 3):
      try:
        talent = spec.talents[i+1][j]
      except Exception as e:
        print(f"Error obtaining talent for spec {spec} at row {i} with talent# {j}")

Results in a ton of missing talents.

Encode dps talent validity in blueprint more accurately

Talent blueprints for specs could use octal values to save which talents in each row are actually dps relevant. This change allows a higher accuracy of generated talent combinations and reduced their numbers for some specs.

0 = no talent
1 = first talent on row
2 = second talent on row
3 = third talent on row
4 = first and second talent on row
5 = first and third talent on row
6 = second and third talent on row
7 = first second and third talent on row

Originally posted by @abelito75 in #11 (comment)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.