Sometimes the first entry is smaller and offset, it stays until the serverbrowser refreshes I suppose

PR: #74

It would be great if new features or refactoring could be unit tested.

Better code decoupling, enhanced stability, less stress to break things, better productivity, self documenting code etc ..

I wish I could implement it but I'm not familiar enough with C++ stack for now

really simple, /answer <string> would be used to whisper the last person that whispered you.
for example, let's assume we have user0 and user1:

user0:
  /whisper "user1" test -- whisper user1
user1:
  /answer "test2" -- whisper user0
user0:
  /answer "test3" -- whisper user1

Instead of coloring the entire texture of the weapon, I'd like to only color certain parts. e.g. the lights on the shotgun should change color according to the team. This would just be a visual "improvement" (I can't say if it'll look that much better but I think it definitely could)

I've been asking around and many people agree with me that the muzzle flash of the shotgun lasts just a lil' bit to long. Just a fraction of a second. So ... I wanna change that.

I'd like to make the camera automatically start spectating the person who killed you after you died (ofc with a few secs delay). this will be customizable in a new tab in the Gameplay options called "Spectator"

The Ability to choose the botoffset for the next round during map voting.
This feature would still maintain compatibility with Red Clients since the votings of those would use the default botoffset of the server.

While holding CTRL and clicking mouse1 it should react like in any good file browser, select the files even if they're not next to each other, IMO that could make it easier to build e.g. walls for houses at once.

Game is a masterpiece but its code is twisted as hell.

I think it would be a good thing for health of the project to refactor stuff when we have opportunity to.

However the project is currently lacking guidelines about this. This ticket is to discuss and debate about these guidelines.
Here's some example points :

• is refactoring allowed at all ?
• what can(not) be refactored (what is worth refactoring, what must not be refactored not to break things etc..)
• maximum size of refactoring PRs
• is refactoring can be in the same PRs/commits as bugfixes/feature add ? or should be completely alone ?
• are refactorings must be at all times first be approved in a ticket dedicated for this ?
• minimum code quality for it to be considered as a refactor
• other stuff

Once these guidelines completed, that will prevent people from working hours on a PR that will get refused for X reason, as well as motivate people to refactor code because they will be aware of what they are getting into.

When playing survivor and one of your team-members leaves during a match, you'll play this round with one person less on the team.

I'd like to add a maxfps slider to the Display & Graphics menu since the only way to modify it atm is through commands

Usually when you shoot a teammate the damage popup has the same color as always, I wanna change that to give more visual feedback that you're actually shooting a teammate

This is just to clean up unused code, since we removed the IRC implementation for clients anyways, we could just dump the entire code that was used to manage the IRC menu/chat window.

Add the ability to mark a server as favourite to show them on top of all other servers in the serverbrowser.

First seen in: Red eclipse 1.6

Observation: In editing triggers works client-size and don't impact other players

How to reproduce:

1. Place for example a door and a trigger (let's say an toggle-action one)
2. Ask another player to stand on the top of the door
3. Open the door and see that the other player isn't impacted by the door opening

Though in an other mode than editing the triggers work fine

I think that this entire crc stuff could just be removed since it keeps you from playing downloaded maps until you rename them, and if you do, they play just fine. I can't see the purpose in this system.

For now, CI only checks if things build. It does not implement any automated tests, nor warning potential regressions.

I suggest to use -Werror in the builds, and for each compiler disable the actual currently known warnings, so that new warnings will trigger failure.
Long term goal would be to remove all disabled warnings, for all compilers.
I also suggest using both clang and gcc, as they have different warnings, and gcc does include false negatives (-Wunreachable-code).

On my current master, I have this list of warnings that are actually generated by clang with -std=c++14 -Weverything -Wall -Wno-c++98-compat-pedantic -Wno-c++98-compat -stdlib=libc++ -Wno-documentation -Wno-documentation-deprecated-sync -Wno-documentation-unknown-command :

-Wcast-align
-Wcast-qual
-Wcomma
-Wconditional-uninitialized
-Wconversion
-Wdeprecated
-Wdouble-promotion
-Wembedded-directive
-Wexit-time-destructors
-Wfloat-conversion
-Wfloat-equal
-Wformat-nonliteral
-Wformat-pedantic
-Wglobal-constructors
-Wgnu-anonymous-struct
-Wgnu-zero-variadic-macro-arguments
-Wimplicit-fallthrough
-Wmissing-noreturn
-Wmissing-prototypes
-Wmissing-variable-declarations
-Wnested-anon-types
-Wnull-pointer-arithmetic
-Wold-style-cast
-Wpacked
-Wpadded
-Wpointer-bool-conversion
-Wredundant-parens
-Wreserved-id-macro
-Wshadow
-Wshadow-field
-Wshadow-field-in-constructor
-Wshift-negative-value
-Wshift-sign-overflow
-Wshorten-64-to-32
-Wsign-compare
-Wsign-conversion
-Wswitch-enum
-Wtautological-type-limit-compare
-Wunreachable-code-break
-Wunreachable-code-return
-Wunused-macros
-Wunused-parameter
-Wunused-template
-Wvarargs
-Wweak-vtables
-Wzero-as-null-pointer-constant

Thus, using the -Wno versions of those would, combined with -Werror, allow CI to detect more regressions.
I think most of those warnings could be considered an actual bug, and be treated by individual PRs.

It'd be really nice to be able to navigate through menus using UP, DOWN, RIGHT, LEFT, SPACE, RETURN and TAB

I've experienced a few issues with the voiceline playback e.g. your own voicelines sometimes only play on one ear, that they get cut off when you respawn/the round ends/you die or sometimes they don't even play at all. I'd like to take a look at the code and make following changes: Don't cut off voicelines, Make sure voicelines always play, and make own voicelines always play on both ears (maybe even all voicelines)

Instead of pain white text when mentioning someone's nickname, I think it would be nice that player mention gets it's own colour and a badge (that small symbol next to the nickname).

Pressing in editing mode "numkey 0" opens a material list. However it's strange that all materials including 'hurt', which doesn't have it's shortcut key, are in the material list. Even though it says it's not recommended to use glass, I think adding this material to the list won't hurt anybody really.

Strangely, glass even has it's own colour change list.

The only way I know how to add glass is by typing in the chat "/glass".

An in-game GUI that allows you to select and import custom resource packs for the game, e.g. changed weapmodels, changed sounds, etc.

This is how such a menu could look like:

We need a new logo, as discussed in #25.

@SalatielSauer made a proposal, see #25 (comment). Even if it might just be used temporarily, it doesn't look bad at all. The main criticism I have it's not a vector graphic, which would be better in the long term. Something in SVG that also looks good in grayscale resp. with some clear contours which could also work in high-contrast situations.

To be able to use @SalatielSauer's logo e.g., as a base, we need to clarify licensing. @SalatielSauer what license is your logo published under? Would something like the CC By(-SA) 4.0 Intl. work for you? We need one that grants us and everyone else the right to also modify it and create derivatived works.

Whenever you hit head, you get those fancy texts appearing like "headshot!" or doing combo kills "x2" 3x"... I thought about that it could be possible to add more of those. For example: There is also not so often happening but an interesting one. When you hit 2 players, with 1 rifle shot and kill both of them. It would be nice to implement separate text for this.

Check every message that goes in if it contains the username (exactly) and then play a sound, can be turned off in the options #50

First seen in: current master

Observation: switching the SDL_VIDEODRIVER to wayland causes the game to use a lower color depth, this is mostly noticed by the "clipping" of the gradients' color

How to reproduce:

1. launch the game with SDL_VIDEODRIVER=wayland on wayland

I searched the issue list and checked that this is not a duplicate ✅
I tried to rename my config.cfg, and the problem also occurs with default settings ✅

#50 inspired me to this idea. We should add some chat highlighting feature, like you have in most IRC clients. Whenever you are mentioned (and this has become fairly easy with #37), the client should display the entire line in a special, highly visible (maybe even customizable) color. This is a very non-invasive, subtle but powerful way to inform users about lines which affect them.

One thing to look out for is, whatever color is used, the game must still make sure that when a color code is used in such a message, that part is highlighted in some way. I could imagine something like "if same color then display that part in white font color".

currently bots apparently answer EVERYTIME you whisper somebody, let's instead make it so they don't react to whispers at all but instead give them their own command to interact with.
I propose:
/bot and /bots
syntax:

/bot <bot_name/cn> <command/command_num>
/bots <command/command_num>

I want to add an option to toggle the ping inside of the HUD, like the FPS

I'd like to start to go through every file in src/game and remove things like in-line if statements, append spaces before and after operators, stuff like that, I know that sounds like much but I think I can do it in a very short amount of time so it won't interfere with any of our other stuff

As per the Red Eclipse Mark Policy (a copy of which you have in this repository), I hereby ask that you respect the intellectual property and rights of the Red Eclipse project and remove our copyrighted materials.

• The name "Red Eclipse Legacy" is not a permitted use of the "Red Eclipse" name, as it is likely to cause confusion with the false belief it is an official product by the Red Eclipse team and in turn harms the community. Part of our plan included re-releasing v1.6 on Steam under the name "Red Eclipse Legacy" at a later point (and is already available on GameJolt under that branding), which has now been confused by the existence of this improperly named fork.

• The files "icon.png" and "logo.png", along with all derivatives and imagery, are provided under the provisions of the Red Eclipse Mark Policy. The use of these images in this project is not only illegal, but it serves to further confuse people as to the nature of the project.

I don't much appreciate people trying to piggyback on the hard work I've put in over the last decade. A lot of time and effort has gone into establishing the Red Eclipse brand and related intellectual properties, and I've been more than generous in making sure everything you need to make a fork is free and open source - but I had one simple rule: please don't use our name and logos. You of all people should have respected that.

I'm trying not to get upset and do the right thing by coming and asking nicely. I'm not interested in an argument or a debate on the issue. Should the matter not be resolved within 10 business days (close of business 11th June 2020), I will unfortunately have to take further action in order to protect the interests of the Red Eclipse project.

Currently, "fast cooldown weapons" do not have indicators allowing players to know they can fire anew. The default setting is set at 1000ms in the variable indicatorminattack.

This means several attacks:

• rifle1
• sword1/2
• shotgun1
• grenade1/2
• mine1/2
• pistol1/2

Which includes some of the most powerful weapons are artificially made harder to use to anyone that does not know the existence of this variable (those are only the weapons without fullauto, too).

I propose to change the default value of this variable. The value it should have is hard to say... beha suggested on irc to use 400ms, which would enable it for every non-fullauto weapons but the pistol, while still not clobbering fullauto weapons

e.g. connecting to a server, instead of printing "Connecting To Server.." show a big green "Connecting..." inside the serverbrowser entry where previously it stated the Players and the game info. The main reason is because of focus, usually people focus on where they click so if you click on a server entry in the serverbrowser you would expect something to happen there, but instead it shows in the upper left corner.

If you carry around any pickable item like rocket, mine or grenade, there's a bug that must be fixed.

When someone kills you just at the right time when you use the item, not only will the item be used, but you can pick it up again. This creates catastrophic results when someone uses something like a rocket, kills and after the rocket is shot, other player picks it up like nothing happened and uses it again.

This bug is very common.

color screenedges in a red-ish tint to indicate that you're taking damage, or maybe that you're low on health. Why? Because there is no real way to see that you're taking damage when you disabled sounds. This would therefore also help with accessibility.

I think if we want to continue using cubescript we have to make some serious improvements, and for readabilities sake I'd say we should start by adding operators. so instead of (+ 2 9) we'd have (2 + 9) I do not know how we can do that yet, but we have to do it eventually

Currently sounds are registered and added to a list but the sound being loaded correctly depends on them being registered in the correct order.
e.g.

(Cubescript)
registersound "sounds/sfx/chat" // S_CHAT
registersound "sounds/sfx/mentioned" // S_MENTIONED

and in C++ we have an enum like this
enum { S_CHAT = 0, S_MENTIONED = 1 }
(very simplified)

what I want to do is simply make it so you have to give an index to register a sound
e.g.

(Cubescript)
registersound "sounds/sfx/chat" 0 // S_CHAT
registersound "sounds/sfx/mentioned" 1 // S_MENTIONED

I think this would make the code a lot safer.

While playing in serious matches (for example duels) you don't want to hear or see the chat at all. I think it would be nice to have option to turn off chat while playing until you are in spectator mode.

We want to localize the game. Therefore, we need to implement I18n in the code base. To do so, we:

• need to decide on I18n strategy
• find a suitable I18n framework/library (e.g., gettext)
• implement I18n interface in Cubescript (provide a function to interface I18n framework, basically)

Once we resolve all these points, we can then start to wrap all strings in the game (including Cubescript) which require localization, and then set up e.g., Weblate and have people translate the game. This process, the actual Localization (L10n), should be tracked in a separate issue.

I'd like to give players the ability to modify a custom circle menu with the entries they want #51

The title should describe it pretty well I think. #58

I tried doing silly stuff on player profile like changing to longest name possible. So I suddenly found this weird thing.

This should just make it more obvious what "corner" really means #61

You can navigate through your commandbuf history already using UP and DOWN already, which is great.
But I'd like to have the ability to press DOWN once more when being at the most recent entry of the history to get an empty commandbuf

in commit af74d03 the map thumbnails are all identical when trying to switch server while already playing (and match currently played map's thumbnail).

Reported by varco on irc.

First seen in: current master

Observation: the game would freeze with one core on 100% usage until its killed

How to reproduce:

1. Play normally
2. When spectating, switch cameras and sometimes the bug will trigger (cannot be reproduced easily)

I searched the issue list and checked that this is not a duplicate ✅
I tried to rename my config.cfg, and the problem also occurs with default settings ✅

I suggest the switch from the default SDL_mixer to OpenAL for positional audio playback, as this would enable us to have audio occlusion and onstruction, which would help make the sounds sound a lot more realistic and be more helpful for orientation

Display a warning on the screen when you're shooting someone that is in textmode, something like "This person inside the menu, shooting now is a dick move!" or smth along those lines

my yet to improve linter detected an unterminated string in https://github.com/blue-nebula/base/blob/master/config/usage.cfg#L64

It does not triggers problems in Blue Nebula compiler though.

I'm adding an extra menu for editing weapon variables to make the process easier, this what my earliest prototype looks like

:
when you change a variables value (so it isn't the default anymore) it'll be highlighted in orange:

The main inspiration and a big part of the code was taken from @IceflowRE, big thank you again.

You'll have the ability to import and export custom configs for each weapon separately (see Import and Export buttons at the top), tho I still have some alignment issues there.

The upper scroll part is for general values like Name, Colour, etc. while the lower scroll part is for variables that have separate values in primary and secondary attack