bluemurder / ds1624 Goto Github PK

Totally new on arduino. Actually DS1624 is my first test project.

Though when I play with the DS1624 address pins, I found there might be an error on line 51:

_address = 0x48 + (addressByPins & 0xf8);

With this calculation, any input address from 0x00 to 0x07 will result _address = 0x48.

I changed the code to:

_address = 0x48 + (addressByPins & 0x07);

and the code tests okay.

I found an error in the constructor of the DS1624 class
Currently the code will only work with address 0

this line:
_address = 0x48 + (addressByPins & 0xf8);
should be:
_address = 0x48 + (addressByPins & 0x07);
to make the other addresses available.

See https://datasheets.maximintegrated.com/en/ds/DS1624.pdf

Concerning command 17h

See https://datasheets.maximintegrated.com/en/ds/DS1624.pdf

Need to modify library to support Arduino Due platform as in following example

/*----( These lines allow code to work also on Arduino DUE )----- */
#ifdef AVR
  Wire.begin();
#else
  Wire1.begin(); // Shield I2C pins connect to alt I2C bus on Arduino Due
#endif

Hello, @bluemurder!

First of all, thanks for making this library available. Recently I've had the opporunity to test it against real hardware. Sadly it did not seem to work properly and some functionality is missing (like EEPROM reading/writing). So I've modified the code (and tested) to fix some issues and to add such functionality.

It would be great if you merged these changes so people working with the DS1624 can do it easily. The examples were updated as well and are working. I can make a PR right away.

Thanks!