blueshoe / djangocms-layouter Goto Github PK

Add an option to set the height of the content of a row to the same height.

It would be nice if the tests run regularly here.

Divio Cloud support to make the layouter installable in the control panel.

The migration for the equal height field is missing.

Currently, in the structure mode, child plugins are rendered as rows (just like everything else in django CMS).
Maybe it's possible to render the child-plugins in columns.

This might make it easier to understand long pages in structure mode, since it's a bit more WYSIWYG-ish than the current approach.

However I'm not totally sure, whether this makes sense, it's just something that came to my mind. Maybe it's not even possible to easily change the stucture mode's render templates?

In the distibuted package (the one you get when you pip install djangocms-layouter) version 0.2 the migration files are missing.

pip install djangocms-layouter                                                                                            
Collecting djangocms-layouter
/home/mmuth/PycharmProjects/mpicc-demo/env/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:90: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading djangocms-layouter-0.1.2.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 20, in <module>
      File "/tmp/pip-build-LMWCat/djangocms-layouter/setup.py", line 36, in <module>
        long_description = read('README.rst'),
      File "/tmp/pip-build-LMWCat/djangocms-layouter/setup.py", line 6, in read
        return open(os.path.join(os.path.dirname(__file__), fname)).read()
    IOError: [Errno 2] No such file or directory: '/tmp/pip-build-LMWCat/djangocms-layouter/README.rst'
    
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-LMWCat/djangocms-layouter

I'm running this from within a virtualenv with 9.0.1

Looks related to #1

I'm testing the package with Dajngo 3.1 and DjangoCMS 3.8.0rc1. Needed to make some minor code fixes to get it to work. PR incoming... 🎯

It might be useful to provide an option to disable a row for certain screen sizes. This way the layout and design could be changed for different devices like smartphone and desktop.

We probably would add a fixed number of screen sizes like "Desktop", "Tablet" and "Smartphone" to keep the options screen as simple to use as possible.

Dragging and Dropping in the structure view does not yet update the warnings within the
plugin.

The added default value of the field ContainerPlugin.margin causes a migration which has not yet been added to the repo.

I just realized that this plugin isn't Python3 compatible:

Exception Value: name 'unicode' is not defined Exception Location: /Users/fabian/.virtualenvs/petaw/src/layouter/layouter/models.py in __str__, line 77

I kindly ask you to document that in the readme. If I at some point find time to create a Python 3 compatible version, I'll happily create a pull request.

In the distibuted package (the one you get when you pip install djangocms-layouter) version 0.2 the static files are missing.

Fixes #29

Currently the layouter only works for the 12-column bootstrap grid. However it is possible to extend the bootstrap grid to other grid sizes (e.g. 24-column grid).
Maybe we could find a more simple possibility for developers to adapt this parameter to their projects without having to override all templates.

It might be cool to allow the user to set some styling options for the background of the row. Examples are:

• Solid background color
• Background image
• Background video
• Parallax effect for the background image/video

What do you guys think of this feature?

Fix installation instruction - add layouter urls.

We're currently using the prefix icon- for the icons used by layouter. This might clash with other other icon fonts, so we should use a more specific class.

Same might be true for the FontAwesome icons we introduced in #12

We're only loading that CSS when the page is in draft mode which somehow reduces the importance of the issue. Nevertheless, it should be improved.

Currently the breakpoints are hard-coded in the grid templates, e.g: https://github.com/Blueshoe/djangocms-layouter/blob/master/layouter/templates/layouter/bootstrap4/partials/three_cols.html#L12

The defaults are sensible but also inflexible. In my use case it makes sense to let the user configure the breakpoints manually for each layouter plugin. With some rather simple code changes I got it to work:

A downside is that the layout can only have a single breakpoint (currently some layouts are hard-coded with two breakpoints, as in the example linked above). I think this downside can be easily countered by the user by nesting two Layouter plugins. I guess we could also implement a "Secondary breakpoint" field, but since only some layouts could make use of this field, it could be confusing and also adds complexity. IMHO anyway.

I'm interested to see if you think this could be added to Layouter plugin (can make PR). I'm not sure how this plays with Bootstrap 3, though, need to check...

• Hide certain options / fields (eg. the visibility option)