• was_published: whether this PageVersion was published once
• backup_id: using the batch-add to create a 'backup'. If you want to roll back: select all PageVersions by backup (introduce a new backup-model?)
• version_owner: the creator of the PageVersion (for the rights management)

1/2 Lost changes

Problem: Reverting to a PageVersion with unsaved Changes.
Solution: Show an alert box with the button to create a PageVersion

2/2 Roll back to published page

Problem: Published pages are not automatically versioned
Solution: auto-create a version when publishing

The audit trail should be downloadable as follows

Revision | Date | Author | Comment | Html diff

In order to unmark Page-language combinations as currently revised, a mixture of signal receivers and PageAdmin hooks is used. There are arguments for both:

On the one hand, to the best of my knowledge, the PageAdmin method post_plugin_move is the only way to hook into moving a CMSPlugin because that action never calls save(), but uses QuerySet.update(...) instead which does not send a signal.

On the other hand, listening to signals makes the marking/unmarking feature much easier to test.

Ultimately, I think it is desirable to have it all in one place if possible.

after running the batch-add, there were multiple pages with the same title__path

Reference: https://travis-ci.org/Blueshoe/djangocms-reversion2/builds/279460478

@mammuth Have you seen this error before?

When installing djangocms-reversion2 via pip install git+https://github.com/Blueshoe/djangocms-reversion2.git, templates and CSS are not copied, because they are not listed in setup.py. For me this resulted in a TemplateDoesNotExist error.

See https://docs.python.org/3/distutils/setupscript.html#installing-package-data

I'll create a pull request.

make the plugin in pre-stable installable via pypi

hidden pages remain in page tree although page version was deleted

• A back button is missing
• the apply revision button should be added to the diff view

When a page is dragged out of a basket in the bin, the basket is not detected as bin basket and therefore misses the trash icon

The bin is a unpublished page. Right now other pages can be below the bin. SAD

The diff view shows the difference between the current Page draft and a Revision of that Page. This view is very (too) simple a this point, displaying plain text HTML with marked insertions/deletions based on diff-match-patch.

Any visual enhancement of this view, e.g. rendering of the diffed HTML, will be greatly welcome!

Some fixes but still need work

diff --git a/djangocms_reversion2/admin.py b/djangocms_reversion2/admin.py
index 49a250f..65289e8 100644
--- a/djangocms_reversion2/admin.py
+++ b/djangocms_reversion2/admin.py
@@ -8,7 +8,8 @@ from cms import api, constants
 from cms.admin.pageadmin import PageAdmin
 from cms.middleware.page import get_page
 from cms.models import Page, Title, EmptyTitle
-from cms.utils import get_cms_setting, get_language_from_request, get_language_list, i18n
+from cms.utils.conf import get_cms_setting
+from cms.utils import get_language_from_request, get_language_list, i18n
 from cms.utils import page_permissions
 from collections import defaultdict
 
@@ -671,4 +672,4 @@ def render_admin_rows(request, pages, site, filtered=False, language=None):
     rendered = (render_page_row(page) for page in pages)
     return ''.join(rendered)
 
-admin.site.register(Page, PageAdmin2)
\ No newline at end of file
+admin.site.register(Page, PageAdmin2)
diff --git a/djangocms_reversion2/utils.py b/djangocms_reversion2/utils.py
index 20d91c5..b1a6777 100644
--- a/djangocms_reversion2/utils.py
+++ b/djangocms_reversion2/utils.py
@@ -55,7 +55,7 @@ def _copy_model(instance, **attrs):
 
 def get_version_page_root(site):
     try:
-        return Page.objects.get(title_set__title=VERSION_ROOT_TITLE, site=site)
+        return Page.objects.get(title_set__title=VERSION_ROOT_TITLE).filter(node__site==site)
     except Page.DoesNotExist:
         return api.create_page(
             VERSION_ROOT_TITLE, constants.TEMPLATE_INHERITANCE_MAGIC, settings.LANGUAGES[0][0], site=site)

  File "/home/www/django/home-page-cms/djangocms_reversion2/utils.py", line 218, in is_version_page
    return page.is_descendant_of(version_page_root)
AttributeError: 'Page' object has no attribute 'is_descendant_of'

The plugin should use django's internationalization (German translation needed)

Problem: When editing a page version a popup-ception occurs and the current close_frame.html doesn't close the inner popup

Currently python 3 won't work out of the box probably. See for example this travis build which ran into an issue with python 3: https://travis-ci.org/Blueshoe/djangocms-reversion2/builds/250749224

Currently, django-cms registers all subclasses of CMSPlugin with the registry of django-reversion. This default registration's follow option does not include a 'cmsplugin_ptr', which is why we currently add this to the existing registration options for each CMSPlugin subclass.

It would be desirable to have a custom registration for djangocms-reversion2 which allows cms-plugin developers to register their cms-plugins with custom options that can override or be merged with the existing registration options.

Otherwise, custom relations cannot be properly versioned.

If you click on the view button of a PageVersion in the diff-view, an iframe loads the url of a the hidden_page of the PageVersion.

1. rights management: who can view the page
2. hide the menubar with css instead of javascript: element.remove()

User:

• can create PageVersion
• can view own PageVersion
• can view all PageVersion
• can add PageVersion
• can revert Page to PageVersion

It looks like the plugins of all languages of a page are copied to the target page

The PageRevision admin views are currently added as modal items to the django-cms toolbar. These admin views are very rudimental and should be improved both visually and functionally:

• there is no way to get back from the diff view to the list view
• there is no warning when reverting to a PageRevision: what changes will take effect, what objects may be lost, etc.
• etc.

make everything configurable!

Documentation for editors:

• What features are there
• How to use them
• Dangers

does not work

This project needs documentation for developers:

• explaining the core concepts
• how to use the page_revisions api

Travis-CI?

Hi,

is this project supporting last versions of Django-cms? this would be awesome

Readthedocs?

1. Create a backup model
2. connect all PageVersions created by one batch-add
3. batch-revert

This is necessary because LimitedJoe (the test user) can't access the page versions

Translate the module