blugeni / decombinator Goto Github PK

I seem to be experiencing some issues with the code. Using the code from your site seems to work (i.e. the oled shows the current number being tested and all buttons respond as they should). I didn't see any pin changes between the two versions.

Issues I am experiencing with the code on github:

1. When I am done uploading the code, the serial monitor is continuously showing "Decombinator" and doesn't stop.
   

2. There is no response from the start button at all (the other buttons, (move and combo found) seems to respond)
   
   

Here is the serial output from the other version:

The loops seem to be obviously wrong:
for (combo[3] = 0; combo[3] < 40; combo[3]++) {
for (combo[0] = combo[3] % 4; combo[0] < 40; combo[0] += 4) {
for (combo[1] = combo[0] + 2; combo[1] < 40; combo[1] += 4) {
[...]
I printed out the variations, and you have many doublettes, because you never write into the third array.
This could be a simple mistake ([3] instead of [2], but what did you wanted to achive with the mod 4 ,+4,+2?
Was your intention to test less, than the 64000 possible combos?

The trivial loop would look like this:
for (combo[0] = 0; combo[0] < 40; combo[0]++) {
for (combo[1] = 0; combo[1] < 40; combo[1] ++) {
for (combo[2] = 0; combo[2] < 40; combo[2] ++) {
[...]
of cause testing impossible combinations, so I just wanted to check in, what you intended with your approach.