blumed / weblibbs Goto Github PK

As a user, I would like to be able to see the list of words that I've set up for replacement, and delete individual words.

Youtube comments aren't affected.

Commit: 009ba24

Steps to reproduce:

1. turn on extension
2. navigate to youtube.com
3. load a video page
4. try to change one of the words in the comment section

Expected Result

words should have changed in comment section

Actual Result

"main" webpage shows the word replacement, but it isn't replaced in any of the comments.

when the extension is activated, connect to the current running tab; when the tab is changed, connect to that tab. Refreshes will not be required to "connect" the extension to a tab.

http://developer.chrome.com/extensions/tabs.html#method-connect

As a user I might want to disable word replacement or clear the words list on the fly. In this case I would want the replacements to be undone.

It's not enough to reverse the word and replacement in the walk function; just because I replace pigs with hogs, doesn't mean every hogs on the page was a result of this replacement. In other words, on a page composed of "All pigs are hogs", replacing pigs with hogs would yield "All hogs are hogs", but reverse-replacing would yield "All pigs are pigs" - which is not the original string.

I think this would work:

1. at every replacement, the node and the character offset of the replacement, as well as the length of the replacment and the original word (words could be referenced by the offset in the words array potentially as long as it is reverted before that is cleared) is saved
2. when the replacements are reverted, we would go through that list in reverse order (replacements can change the results of other replacements) and in each position of each text node changed, the original string would be added in and the old string removed.

we currently send messages to refresh word list on change, to the current tab of the current window

we should send it to every tab on every window.

Computer: Mac

1. google index
2. wiki of chosen word
3. back to google index

Changed word does not reappear. Even after refreshing.

Sometimes content_script.js generates an error, basically because response.words isn't defined.

As a user sometimes I just want to clear the words list. Since it's pretty destructive I suggest you have a confirmation before clearing.

on this page
https://www.google.com/search?q=bear&oq=bear&aqs=chrome..69i57j0l5.1250j0j7&sourceid=chrome&espv=210&es_sm=91&ie=UTF-8#q=hair

if you change the word hair into chair and continue making additional words the c in chair multiplies.