blurosie / hg-engine Goto Github PK

we still have wav2swav + swav2swar, just need to implement them in this. sdattool being another python requirement is sad, but it is what it is

move galarian ponyta/rapidash up
same with slowpoke/bro
mr mime too
linoone
hisui samurott as well
galar darumaka/darmanitan
hisui zorua/zoroark
flabebe line has got some weird stuff, red side sprites are swapped
pumpkaboo line is clearly largest size, find smaller overworlds
avalugg side is facing the wrong way
move up 10% zygarde
hoopa unbound fails
appletun is facing the wrong way
kubfu can move up a little
spectrier and glastrier need to come down
make calyrex forms into 64x64
therian enamorus doesn't show up

mold breaker, fairy aura, etc.

see https://www.smogon.com/dex/sm/abilities/sheer-force/

has to do with mega code

when a pokémon uses transform, it does not seem to copy the enemy moveset

roar seems to just corrupt everything

thanks @Drayano60 for reporting this!

probably just recalculates the ability when changing the pid

basically we need to build the code into overlays as we add it instead of the bs we are doing now, shit is getting too big

hypothetically chikorita gets its HA though

thanks to @Drayano60 for reporting this!

gcc doesn't like our code, it's probably full of technical undefined behavior

need to update everything to gen 8 or 9 to standardize the format

the grip claw + a few other items needs the turn limit for binding moves upped to 7 possible

Whirlwind

• fails if user's level is less than target's in wild battles, no accuracy check (except fly/dig invulnerable), not affected by protect

Bind

• damage over time is raised to 1/8 hp each turn

Wrap

• damage over time is raised to 1/8 hp each turn

Jump Kick

• crash damage 1/2 total HP

Hi Jump Kick

• crash damage 1/2 total HP

Growth

• raises both atk & sp.atk 1 stage each. 2 stages each if its sunny

String Shot

• lowers speed 2 stages

Fire Spin

• damage over time is raised to 1/8 hp each turn

Toxic

• bypass accuracy if the user is poison type. Even hits during dig and fly

Teleport

• switches the user out during trainer battles. Has a priority of -6

Minimize

• Raises evasion 2 stages. Other effects remain the same.

Fury Cutter

• base power increased to 40. Maximum base power should still be 160

Rapid Spin

• now raises speed by 1 when using it

Sweet Scent

• lowers evasion 2 stages

Hidden Power

• damage is now a static base power of 60

Whirlpool

• damage over time is raised to 1/8 hp each turn

Beat Up

• deals Dark-Type damage now instead of typeless. Uses a new damage calculation. See: https://bulbapedia.bulbagarden.net/wiki/Beat_Up_(move)

Uproar

• base power increased to 90. Always lasts 3 turns

Knock Off

• base power is now 65. Deals x2 damage if the targets held item is knocked off

Tail Glow

• raises sp.atk 3 stages

Sand Tomb

• damage over time is raised to 1/8 hp each turn

Feint

• base power lowered to 30. Now hits even if the target didnt use protect

Tailwind

• the effects now last 4 turns instead of 3

Defog

• its effect that removes spikes, stealth rock, etc. Now also effects the user as well as the target. However, it does not remove light screen/Reflect/Mist/Safeguard from the user, only the target.

Chatter

• damage is now a static base power of 65 and will always confuse the target

get rid of placeholders

there are now more than 256 abilities. need to track down all of the u8 abilities and make them u16 so that things are handled properly

data structures, function names, variable names, get it out

basically we only have a limited amount of space, converting certain bigger routines to be capable of running from malloc'd space would be ideal to allow the arm9 expansion to be arm9 expansion

just a matter of expanding a069 and dumping everything. shouldn't be too bad

this as well as the togepi script command need to be modified to take into account hidden abilities

implement the fairy type using this repo and make it toggleable using the same ones that we already use

i.e.

learnset MOVE_COUNTER, 15
learnset MOVE_MIRROR_COAT, 15
learnset MOVE_SAFEGUARD, 15
learnset MOVE_DESTINY_BOND, 15

the mon will try to learn counter and safeguard upon level up, but not mirror coat or destiny bond. however, a level 15 mon encountered in the wild will have all 4 moves as expected

catching a pokémon gives experience in later games

need to look into this one, it creates a menu with all the ones that you've seen. defaults to male/female

with item expansion, we need to expand the items that can go in the pockets so that the player can't run out any more.

also document how it's stored + expand on it.

thanks @Drayano60 for reporting this!

GivePokemon 27 30 1 1 1 0x800C (DSPRE nomenclature) gives alolan shrew, but doesn't properly set the ability or hidden ability

todo list

remaining gen 5 abilities:

• regenerator f0595bb
• imposter f0595bb
• infiltrator 555ae59
• magic bounce e1cfe68
• sand force 555ae59
• cursed body 03a7696
• illusion data update on the hp bars (switchindataupdate? setstatusicon BATTLER_xFF, 0x0?, give it its own battle script + message), ensure it also restores the name properly consistently ceb02c3 8574702
• sheer force skips a few item effects, particularly life orb 958cb6e

fix existing forms/implement gen 5 forms that now pull their form data (especially graphics data) from a personal narc entry:

• castform 1d17f62
• cherrim d3b8f3a
• shellos d3b8f3a
• gastrodon d3b8f3a
• darmanitan 9c27dfc
• meloetta d3dfe6d
• genesect 5d4bf87 eaf3fb1
• tornadus 88634fb
• thundurus 88634fb
• landorus 88634fb
• kyurem 2edb469
• keldeo
• deerling 14a47d6 b133a93 117eec2
• sawsbuck 14a47d6 b133a93 117eec2

misc:

• fill out ability descriptions 54e5b86
• hidden abilities, get these working and assignable to pokemon. can we just expand the personal structure and highjack access method? reassigning abilities to mons that change form in battle--how do we handle this? i think we need to have a hidden ability bit in the mon structure, sadly 347dfa6
• primal reversion 61c6943
• have dragon ascent trigger rayquaza mega evolving too 7682e8b
• improve build system, utilize hella makefile features for the narc building that will be skipped automatically if they don't need to be built again. cfru building is speedy (especially on rebuild), users with crappy laptops having to wait 10+ mins to use this would be understandably frustrating as our build times are already frustrating fcaa497 f2eccc0 0f8885f fa9a62c
• sanitize the repo, get the source outta here. at least function names (it's fine by now tbh)
• confirm with adastra and maybe a few other prominent members that they don't mind the barrage that will come with a public release. this may just affect how we market the repo (reddit post? twitter thread?) instead of a release in and of itself
• make sure mega animation either always plays or the sprite is updated in the battle script d08b158
• 60 fps battles config option (config from config.h preferable) 8379db3
• when done with testing (aka ready to start new save), expand dex save structure further to catch language byte overflow. this makes the dex structure 0x4C0 so that the language bytes don't overflow into the daycare save area and create completely gibberish mons 6ec06eb
• get rid of hgss-monexpansion artefacts, mainly in rawdata f488ba6
• per brioche: new exp system (2-byte base exp, maybe even level scaling?) 6bd1086
• icon gender differences (or do we just make them forms? meowstic has completely new everything and may be better as a form) fbbc7da
• handle form egg moves 7860a60
• handle form learnsets in the wild c06a3a0
• handle form evolutions+evolving into forms baaa3e6
• selectively make mega button available/at all visible 5264936 323e302

wiki:

• document trainer data structure and how to modify in the wiki
• document dex flag save structure changes in the wiki and how that was changed to support more dex flags for existing pokemon
• document changing every aspect currently editable of pokemon
• hidden ability wiki documentation
• document move data
• document battle script systems
• document item data

stretch:

• landing pad system where we can load in new functions from a narc subfile and have it load and jump to said area to not use too much space with the synthetic overlay
• incorporate sdattool to build the sdat including the cries
• ai improvement/documentation
• dex forms
• item bag expansion
• catch experience
• build footprints from images
• add various configs for building certain features
  • mon expansion config (!) b51f8c4
  • item expansion
  • new exp system 26d5ce5
  • hidden ability system e0fe77b
  • 60 fps 8379db3
  • battle always set 4e11490
  • mega evolution c1c4eac

also just fury cutter in general. if a move isn't fury cutter reset the effect

also when facade is used the reduction is completely ignored

this is the function responsible from https://github.com/pret/pokeheartgold/blob/master/asm/overlay_63.s#L4649 i believe

the biggest cry in vanilla is 24 kb. plenty of pokemon go over this limit and the solution is basically to torch the heartgold sound system

let's look into this and find out how platinum does it in multi battles

src/field/encount_set.c

normally i would think this has to do with a somehow damaged sdat file, but now that we are using sdattool and that matches byte-for-byte i'm not 100% sure what the problem is

using this post as a todo list 😅

Hone Claws

• effect
• anim

Wide Guard

• effect
• anim

Guard Split

• effect
• anim

Power Split

• effect
• anim

Wonder Room

• effect
• anim

Psyshock

• effect
• anim

Venoshock

• effect
• anim

Autotomize

• effect
• anim

Rage Powder

• effect
• anim

Telekinesis

• effect
• anim

Magic Room

• effect
• anim

Smack Down

• effect
• anim

Storm Throw

• effect
• anim

Flame Burst

• effect
• anim

Sludge Wave

• effect
• anim

Quiver Dance

• effect
• anim

Heavy Slam

• effect
• anim

need sound effects because i haven't been doing this when sound is acceptable:

Synchronoise

• effect
• anim

Electro Ball

• effect
• anim

Soak

• effect
• anim

Flame Charge

• effect
• anim

Coil

• effect
• anim

Low Sweep

• effect
• anim

Acid Spray

• effect
• anim

Foul Play

• effect
• anim

Simple Beam

• effect
• anim

Entrainment

• effect
• anim

After You

• effect
• anim

Round

• effect
• anim

Echoed Voice

• effect
• anim

Chip Away

• effect
• anim

Clear Smog

• effect
• anim

Stored Power

• effect
• anim

Quick Guard

• effect
• anim

Ally Switch

• effect
• anim

Scald

• effect
• anim

Shell Smash

• effect
• anim

Heal Pulse

• effect
• anim

Hex

• effect
• anim

Sky Drop

• effect
• anim

Shift Gear

• effect
• anim

Circle Throw

• effect
• anim

Incinerate

• effect
• anim

Quash

• effect
• anim

Acrobatics

• effect
• anim

Reflect Type

• effect
• anim

Retaliate

• effect
• anim

Final Gambit

• effect
• anim

Bestow

• effect
• anim

Inferno

• effect
• anim

Water Pledge

• effect
• anim

Fire Pledge

• effect
• anim

Grass Pledge

• effect
• anim

Volt Switch

• effect
• anim

Struggle Bug

• effect
• anim

Bulldoze

• effect
• anim

Frost Breath

• effect
• anim

Dragon Tail

• effect
• anim

Work Up

• effect
• anim

Electroweb

• effect
• anim

Wild Charge

• effect
• anim

Drill Run

• effect
• anim

Dual Chop

• effect
• anim

Heart Stamp

• effect
• anim

Horn Leech

• effect
• anim

Sacred Sword

• effect
• anim

Razor Shell

• effect
• anim

Heat Crash

• effect
• anim

Leaf Tornado

• effect
• anim

Steamroller

• effect
• anim

Cotton Guard

• effect
• anim

Night Daze

• effect
• anim

Psystrike

• effect
• anim

Tail Slap

• effect
• anim

Hurricane

• effect
• anim

Head Charge

• effect
• anim

Gear Grind

• effect
• anim

Searing Shot

• effect
• anim

Techno Blast

• effect
• anim

Relic Song

• effect
• anim

Secret Sword

• effect
• anim

Glaciate

• effect
• anim

Bolt Strike

• effect
• anim

Blue Flare

• effect
• anim

Fiery Dance

• effect
• anim

Freeze Shock

• effect
• anim

Ice Burn

• effect
• anim

Snarl

• effect
• anim

Icicle Crash

• effect
• anim

V-create

• effect
• anim

Fusion Flare

• effect
• anim

Fusion Bolt

• effect
• anim

definitely an issue with the u16 level, u16 move implementation

thanks @Drayano60 for reporting this!

hook_12_spriteOffsetSpecies love to see it