barbar.nvim colors are off about vim-nightfly-colors HOT 6 CLOSED

Adding in colors for barbar.nvim is fine via plugin specific highlight groups. PR is welcome.

However, the following setting listed above is a no go:

exec 'highlight TablineFill guibg=bg'

That breaks the tabline for stock installations as seen here:

I already set TablineFill to:

exec 'highlight TablineFill cterm=none guibg=' . s:slate_blue . ' guifg=' . s:slate_blue . ' gui=none'

That should remain as is.

from vim-nightfly-colors.

Sorry, this completely went off my radar. I'll get to this today.

from vim-nightfly-colors.

However, the following setting listed above is a no go

I absolutely agree, I was just testing things out. I'd rather provide a patch to barbar.nvim for having another variable that only uses TablineFill as a fallback, like the other variables.

I'll look into this a bit more. Thanks for the feedback!

from vim-nightfly-colors.

What do you think about this? I'm not all too great with colors, but I think it fits the original style of barbar.nvim very well while staying mostly true to the default tabline of nightfly.

exec 'highlight BufferCurrent      guibg=' . s:dark_blue . '  guifg=' . s:white
exec 'highlight BufferCurrentMod   guibg=' . s:dark_blue . '  guifg=' . s:tan
exec 'highlight BufferCurrentSign  guibg=' . s:dark_blue . '  guifg=' . s:blue
exec 'highlight BufferVisible      guibg=' . s:dark_blue . '  guifg=' . s:grey_blue
exec 'highlight BufferVisibleMod   guibg=' . s:dark_blue . '  guifg=' . s:tan
exec 'highlight BufferVisibleSign  guibg=' . s:dark_blue . '  guifg=' . s:grey_blue
exec 'highlight BufferInactive     guibg=' . s:slate_blue . ' guifg=' . s:grey_blue
exec 'highlight BufferInactiveMod  guibg=' . s:slate_blue . ' guifg=' . s:tan
exec 'highlight BufferInactiveSign guibg=' . s:slate_blue . ' guifg=' . s:cadet_blue

I can't figure out why some of the icons have an incorrect background, I think this may be a bug in barbar.nvim.

If you think the colors are fine, I'll try to resolve the icon background issue and open a PR.

from vim-nightfly-colors.

@strayer,

The barbar.nvim theme colors are fine. Go ahead and open a PR.

I will then try and port those colors over to my other moonfly theme. I like to keep the two color schemes in synchronization.

Best regards.

from vim-nightfly-colors.

@strayer,

Is it still your intention to produce a PR?

I would like to get this issue off the books soonish, if possible.

Regards.

from vim-nightfly-colors.