bobbah / centcom Goto Github PK

https://github.com/bobbahbrown/CentCom/blob/a7cc04332c04a655a76d76a6eca7c200e17a6882/CentCom.API/CentCom.API.csproj#L10

This should really be using environment variables 😄

?onlyActive=true doesn't seem to return perma bans as "active." Assuming this is because it checks for an expiration date, but perma bans don't have one included.

Example: https://centcom.melonmesa.com/ban/search/katebishop?onlyActive=true

Edit: Turns out it was the UnbannedBy check, also it doesn't work for any active bans.

Reported by @AffectedArc07

see title

it should only be deleting records that are no longer present on the source, the code looks a bit silly as it is and is probably the result of the initial re-write of centcom occurring in part late at night

this is unnecessarily generating a lot more ids than needed which is sad and also probably higher IO than needed on db

Beestation has requested the ability to see when their bans are global (on all beestation servers) and hence would like a system where they can flag a ban as such in CentCom.

Fulp bans do not take into account the newly added unbannedTime field.

The API should not collect or provide CIDs and IPs for bans. That is a pretty major breach of trust and is in violation of several privacy acts.

Latest bans don't seem to show up for TG/Fulp, Fulp stopped working since fulpstation/fulpstation#846 was merged (one of the PRs which they update to latest TG code)

Example: https://tgstation13.org/phpBB/viewtopic.php?f=34&t=32749&p=656628
https://centcom.melonmesa.com/viewer/view/fizziz

TG permabans are public, but this one hasn't showed up

Fulp's ban API: https://api.fulp.gg/bans/50/1
The 3 most latest banned from the time of reporting:
https://centcom.melonmesa.com/viewer/search/floatingbudgie
https://centcom.melonmesa.com/viewer/view/hbreddl10
https://centcom.melonmesa.com/viewer/view/funnytoilet

None of these bans show up in the database, fulp's bans are all meant to be public (compared to tg's perma-only, this one is a much better example).

The field unbanned_datetime is currently ignored by the parser and results in some lifted bans displaying as active.