bohoffi / ngx-deploy-ftp Goto Github PK

Describe the bug
When using --tls false the flag is not respected. The builder than uses its default value true.

Expected behavior
Passing false via the --tls flag should be respected. In such a case the builder should false instead of the default value (true).

Version information (please complete the following information):

• Library [1.0.0-next.0]

To me it seems like ngx-deploy-ftp likes me to add a ftp username and password permanently to my package.json. Doesn't feel very secure, especially if the projects source is shared on a popular versioning control system.. Is there a solution or best practice to separate such credentials from package.json and store/share them independently from the code?

Angular CLI: 13.3.4
Node: 14.16.1
Package Manager: npm 6.14.12
OS: win32 x64

in my angular.json

 "options": {
            "host": "",
            "username": "",
            "password": "",
            "remote-dir": "public_html/test1",
            "tls" : false
          }

public_html is a dir not a symbolic link
Everything works but files are always pushed to the default connection location (remote-dir doesn't work)

Is your feature request related to a problem? Please describe.
In case of an error during the deploy process the user is supplied with an insufficient amount of information - limited to the errors message - which makes it hard to understand what went wrong.

Describe the solution you'd like
In case of an error more - or better all - available error information should be handed to the user.

Please: I get a timeout error (control socket) with the --verbose option enabled. How do I find out what precisely timed out?

Input:
ng deploy --host 'my-host.url' --port 23 --tls --username 'myusername' --password 'mypassword' --remote-dir '/path/to/my/folder' --clean-remote --verbose --no-build --dry-run

Output:

Your global Angular CLI version (13.1.2) is greater than your local version (11.2.8). The local Angular CLI version is used.

To disable this warning use "ng config -g cli.warnings.versionMismatch false".
📦 Skipping build
🔍 Verifying passed options...
✔️ Verified passed options
As --dry-Run was used nothing will get changed on the remote.
🌐 Connecting to remote...
Connected to 12.34.56.78:23 (No encryption)
< SSH-2.0-mod_sftp

7ϛ�#�|WT�S��ecdh-sha2-nistp521,ecdh-sha2-nistp384,ecdh-sha2-nistp256,diffie-hellman-group18-sha512,diffie-hellman-group16-sha512,diffie-hellman-group14-sha256,diffie-hellman-group-exchange-sha256,diffie-hellman-group-exchange-sha1,diffie-hellman-group14-sha1,rsa1024-sha1,ext-info-s=ecdsa-sha2-nistp256,rsa-sha2-512,rsa-sha2-256,ssh-rsa,ssh-dss_aes256-ctr,aes192-ctr,aes128-ctr,aes256-cbc,aes192-cbc,aes128-cbc,cast128-cbc,3des-ctr,3des-cbc_aes256-ctr,aes192-ctr,aes128-ctr,aes256-cbc,aes192-cbc,aes128-cbc,cast128-cbc,3des-ctr,3des-cbc[hmac-sha2-256,hmac-sha2-512,hmac-sha1,hmac-sha1-96,[email protected],[email protected][hmac-sha2-256,hmac-sha2-512,hmac-sha1,hmac-sha1-96,[email protected],[email protected]�׮i
❌ An error occurred!
❌ An error occurred when trying to deploy:
Timeout (control socket)

Thank You :)

By looking at package.json it seems that Angular 14 is not covered. Is it supported? Should dependency versions be updated to include Angular latest versions?

  // ...
  "devDependencies": {
    "@angular-devkit/architect": ">= 0.900 < 0.1400",
    "@angular-devkit/core": "^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0",
    "@angular-devkit/schematics": "^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0",
    // ...
  },
  "peerDependencies": {
    "@angular-devkit/architect": ">= 0.900 < 0.1400",
    "@angular-devkit/core": "^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0",
    "@angular-devkit/schematics": "^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0"
  },
  // ...

Right now, including this package into an Angular 14 project causes npm to downgrade all dependency versions.

Thank you!

The following error occurs on a fresh Angular 13 project:

ng add ngx-deploy-ftp

ℹ Using package manager: npm
⚠ Unable to find compatible package.  Using 'latest' tag.
⚠ Package has unmet peer dependencies. Adding the package may not succeed.

The package [email protected] will be installed and executed.
Would you like to proceed? Yes
✔ Package successfully installed.
An unhandled exception occurred: NOT SUPPORTED: keyword "id", use "$id" for schema ID
See "/private/var/folders/65/0k8dncr10pj8lqmh192hjqgc0000gn/T/ng-5Dkb7c/angular-errors.log" for further details.

This is well-know breaking change of Angular 12, please see this commit:

angular-schule/ngx-deploy-starter@55b7c98

We also added support for Angular 13 to the npx-deploy-starter demo here:

angular-schule/ngx-deploy-starter@337e3c6

Greetings,
Johannes