Giter VIP home page Giter VIP logo

Comments (7)

timelsass avatar timelsass commented on June 12, 2024

This is dependent on quite a few other changes that have to happen, but typography is something that needs to be changed. I don't think we will add controls for different viewport sizes in the theme though, but it is a possibility.

Just as an initial idea, I originally thought of doing something along the lines of this pen:
https://codepen.io/times/pen/qGWXer

That's using the typography scale defined for heading sizes(bootstrap), but I'd like to introduce some "scale" controls which would change the typography rhythm used. As an example of this, look at the site modularscale.com.

Overall, I'd like to see a solution taking the typography scales mentioned above, and then setting some minimum and maximum thresholds for the viewpoints. We can then use the linear interpolation technique shown in the pen above to allow for sizing the relationships between viewports automatically, all based on the user scaling the content size fluidly. Once this is implemented it will be trivial to add controls in for a custom scale, so everything can be controlled in a more visual way.

There's more to it all, but ideally I want to remove the bootstrap dependency we currently have first. There's been a large amount of work to getting to that point put forth so far, but typography is one of the bigger barriers left.

from boldgrid-theme-framework.

jessecowens avatar jessecowens commented on June 12, 2024

@jamesros161 this feature has been requested by another user in the BoldGrid Support Forums.

from boldgrid-theme-framework.

nicolepaschen avatar nicolepaschen commented on June 12, 2024

wpbex3 server / Chrome / W3TC not active / Crio Pro is not active either

I changed the heading and body fonts. The heading font pulls thru to the PPB as expected but the body font stays Roboto (default config). On the Add Block screen, the right side shows the correct font but as soon as I add it to the page it reverts. The body font size is incorrect as well.

fonts

from boldgrid-theme-framework.

jamesros161 avatar jamesros161 commented on June 12, 2024

wpbex3 server / Chrome / W3TC not active / Crio Pro is not active either

I changed the heading and body fonts. The heading font pulls thru to the PPB as expected but the body font stays Roboto (default config). On the Add Block screen, the right side shows the correct font but as soon as I add it to the page it reverts. The body font size is incorrect as well.

fonts

This SHOULD be as simple as enqueueing the custom CSS for this in PPB. The control I created was entirely custom, not a Kirki control, so I have to add enqueue the styles from it separately

from boldgrid-theme-framework.

nicolepaschen avatar nicolepaschen commented on June 12, 2024

Buttons should not respond to the main text responsive values - since they are getting a new control in the Customizer responsive controls should be there.

Also we need to consider how the padding should change on the button as font size does.
image
image

from boldgrid-theme-framework.

nicolepaschen avatar nicolepaschen commented on June 12, 2024

[needs discussion]

Could extend to:

  • Tagline
  • Menus
  • Custom Page Header Site Title

from boldgrid-theme-framework.

nicolepaschen avatar nicolepaschen commented on June 12, 2024

Font weights do not change in the live preview:

variant-live-preview

from boldgrid-theme-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.