boldgrid / boldgrid-theme-framework Goto Github PK

View Code? Open in Web Editor NEW

18.0 7.0 7.0 44.65 MB

The BoldGrid Theme Framework used in BoldGrid themes.

Home Page: https://www.boldgrid.com/theme-framework/

License: GNU General Public License v3.0

JavaScript 18.27% PHP 40.12% Shell 0.10% SCSS 41.51%

customizer wordpress-theme-framework wordpress-theme-development wordpress boldgrid theme-framework

boldgrid-theme-framework's Introduction

BoldGrid Theme Framework

Contributors: rramo012, timph, jamesros161
Tags: inspiration,customization,build,create,design
Requires at least: 4.9
Tested up to: 6.1
License: GPL-3.0-or-later
License URI: https://www.gnu.org/licenses/gpl-3.0-standalone.html

Browser testing and compatibility is made possible to us with BrowserStack's awesome support and wonderful service! The following browsers are the currently supported browsers for BoldGrid Theme Framework. Other browsers do work perfectly fine for the frontend of websites, but aren't guaranteed to have active testing and bugfixes in terms of the tools provided to build a site. We highly suggest using a modern browser, such as the latest Chrome release.

Edge	Firefox	Chrome	Safari	iOS Safari	Opera
last version	last 2 versions	last 2 versions	last 2 versions	last 2 versions	last version

Description

BoldGrid Theme Framework is a library that allows you to easily make BoldGrid themes. Please see our reference guide for more information: https://www.boldgrid.com/docs/configuration-file

Installation

Create a configuration that overrides required fields. Please see the BoldGrid theme user guide for more information.
Include boldgrid-theme-framework.php from your theme's functions.php

Changelog

2.18.2

Bug Fix: Fixed Container CPH = 0 padding on mobile #779
Update: Remove unnecessary woocommerce template override global/quantity-input.php

2.18.1

Bug Fix: Some footer designs are altered when upgrading from 2.17 to 2.18 #774
Bug Fix: PHP 8.1 installing recommended plugins #776

2.18.0

New Feature: Support for Crio Premium's MegaMenus feature.

2.17.3

Update: Updated WooCommerce templates used by Crio #148
Update: Add additional filters to support and upsell URLs.

2.17.2

Bug Fix: Change metabox text color to black to pass accessibility #755
Bug Fix: Changing Color Palette changes page content #750
Bug Fix: (SproutPRO) Can't access PDF's with Crio enabled #146
Bug Fix: Sidebar hover effects incorrect #741

2.17.1

Bug Fix: (Sprout) Crio doesn't load sa_templates properly #620
Bug Fix: btn-large not consistent between button-primary and button-secondary #738
Bug Fix: Footer links inherit site content link hover effect #733
Bug Fix: Add Media modal uses theme fonts & colors without PPB active #721

2.17.0

New Feature: Allow Post featured image to link to post single page #399
Bug Fix: Fix Build Dependancies #734

2.16.3

Bug Fix: Logos using Flex display stretch vertically on iOS #516
Bug Fix: Duplicate Header in Customizer related to Windows display settings #488
Bug Fix: WPForms email confirmation field error #614
Bug Fix: Conflict with PolyLang, Header/Footer Layout Controls do not function #401
Update: Update "postcss" dependancy from 6.0.22 -> 8.2.13 #370
Update: Update "snyk " dependancy from 1.338.0 -> 1.685.0 #562
Update: Update "@wordpress/dom-ready" dependancy from 2.11.0 -> 2.13.2 #367
Update: Update "@wordpress/hooks" dependancy from 2.10.0 -> 2.12.2 #366
Update: Update "@babel/runtime-corejs2" dependancy from 7.12.1 -> 7.13.17 #365
Update: Update "moment" dependancy from 2.24.0 -> 2.29.4 f4ddfd5
Update: Update "follow-redirects" dependacy from 1.5.9 -> 1.15.1 399bcab
Update: Update "url-parse" dependancy from 1.4.3 -> 1.5.10 e9a9eee
Update: Update "chownr" dependancy from 1.0.1 -> 1.1.4 1b1d681
Update: Update "i" dependancy from 0.3.6 -> 0.3.7 855c5d0
Update: Update "puppeteer" dependancy from 1.9.0 -> 1.20.0 132f018

2.16.2

Bug Fix: Dividing by Zero in the Header #708
Bug Fix: Featured Image background for Posts does not display #717
Bug Fix: WooCommerce Custom Ordering is Ignored #363
Bug Fix: Review z-index with dropdown menus #489

2.16.1

Bug Fix: Hover Underline Reveal effect for Menus is broken #711
Bug Fix: Allow filtering of Premium URL's in theme #706
Bug Fix: Fix submenu background colors not changing with palette
Bug Fix: Hover Effect for Links does not respect Customizer setting #713

2.16.0

New Feature: Change translucent overlays with palette changes #554
New Feature: Make menu underlines and menu hovers match styles #586
New Feature: Change Menu Button styles to match padding / margins of other menu items #546
Bug Fix: Transparent Buttons in Menus do not work as expected #702
Bug FIx: Responsive Typography - Live Preview is incorrect with Custom Page Headers #704
Bug Fix: MFW / FWR content has gap on left side #701
Bug Fix: Customizer Heading font used in dashboard #705
Bug Fix: Font weights do not update in live preview #677
Bug Fix: Responsive typography - live preview is incorrect #684

2.15.0

New Feature: Add font-display: swap to FontAwesome CSS #649
New Feature: Improve integration with weForms & Crio #585
Bug Fix: Footer menu inherits site content link underline #678

2.14.0

New Feature: New container type - full width but contained #540
New Feature: Extend new container type to headers & footers #555
Bug Fix: hamburger menu icon shows next to menu from 1160px - 1199px #366

2.13.3

Bug Fix: Re-build release with 2.13.1 & 2.13.2 fixes properly merged.

2.13.2

Bug Fix: Fonts in Customizer are misaligned from input #646

2.13.1

Bug Fix: Responsive Utilities from PPB are not respected in latest Crio version #637

2.13.0

New Feature: Add controls for submenu backround, link, and active link colors #587
Feature Update: Update PPB and Crio Google Fonts #276
Bug Fix: Headings responsive typography controls buttons #623

2.12.0

New Feature: Hamburger Menus on Tablet / Desktop #512
New Feature: Extend responsive text controls to Tagline & Custom Page Header Site Title #557
New Feature: Select primary / secondary button design from Customizer #507
New Feature: Make button text responsive #556
New Feature: Font control for buttons #506
Bug Fix: Custom Template 'Page Title' does not use calculated Heading Font Size values. #553
Bug Fix: wp_register_style was called incorrectly #595
Bug Fix: Custom Footers do not inherit main text setting from Customizer #579
Bug Fix: Inconsistent hover effect on links #513
Bug Fix: Sticky Headers & live preview #564
Bug Fix: Edit buttons & Custom Footers #571
Bug Fix: Fix hr alignment in custom footer templates #578
Bug Fix: Remove min-height from small buttons #577
Bug Fix: Hiding Page titles breaks title display in the Recent Post widget #382
Bug Fix: Button color stays orange after changing palette #561

2.11.0

New Feature: Added responsive font size controls for Body Font, Headings and Site Title#84
New Feature: Added support for new Sticky Header template and Footer Template features in Crio Pro 1.5.0#544

2.10.0

Bug Fix: Add Menu Link Hover Color Control in Crio #328
Bug Fix: Explicit button height and nowrap makes buttons on mobile look bad #475
Bug Fix: Improve button display in menus #509
Bug Fix: Remove Text-Wrap from Headings #508
Bug Fix: Cannot work with page title control from page unless Pro is active #501
Bug Fix: Pagination padding and full-width margins creating horizontal scroll on mobile #357
Bug Fix: Continued padding / margin fixes in Crio #347
Bug Fix: Search result excerpt incldues the word Read... unlinked without space #448
Bug Fix: Fix escaping in template file 105677

2.9.4

Bug Fix: Fix fatal error with Font Awesome Plugin.

2.9.3

Bug Fix: Removed Font Awesome notice from the admin notices #317
Bug Fix: Crio Pro Sticky Header Menu #376
Bug Fix: Default menu locations not selectable after changing them in the customizer #483
Improvement: Make embedded videos more responsive #490

2.9.2

Bug Fix: Footer Layout Delete Buttons are disabled in same row as Attribution #478

2.9.1

Bug Fix: Blog Page Read More Links - missing / broken controls #480

2.9.0

New Feature: New Edit Buttons added to Customizer Preview that feature dropdowns for buttons with multiple control options.
Bug Fix: Crio - Branding in Footer - Site Title font bug #431
Bug Fix: Crio Customizer Live Preview - font size / font weight does not update #307
Bug Fix: Crio - Difficulty working with Widgets in the Customizer #293

2.8.2

Bug Fix: Crio - Venetian Inspiration (inspirations-theme-73) z-index issue with CTA button #430

2.8.1

Bug Fix: BoldGrid Attribution should not be toggleable without license #189
Bug Fix: Crio Customizer Missing Sprout Invoice Icon #270
Bug Fix: Excerpt Length controls in Design > Post List Settings #358
Bug Fix: Active menu item on blog posts - Inspirations #348
Bug Fix: Site Background Opacity only shows with Customizer open #281
Bug Fix: Links - Hover Color Brightness does not show in live preview #257
Bug Fix: Change background image implementation #189
Bug Fix: Control for Box Shadow Inset / Outset - clicking actual toggle doesn't work #255
Update: Improve Attribution display #311
Update: Transparent Widget Background #280
Update: Update Customizer Styling to be compatible with upcoming WordPress 5.8 Release
Update: Opted-out of customizer's Gutenberg Widget Editor for upcoming WordPress 5.8 Release

2.8.0

New Feature: Added 'Related Controls' feature to customizer.
Update: Re-arranged / consolidated some typography controls.
Update: Renamed 'Colors' section to 'Color Palettes'
Update: Updated some deprecated jQuery.

2.7.1

Bug Fix: Crio Custom Header Glitches #368
Update: Theme Check fixes made to column width controls.

2.7.0

New Feature: Header layout presets.
New Feature: Partial Refresh enabled for more header elements in customizer.
New Feature: Replaced Column Width controls with new multi-sliders.
Note: Skipped 2.6.0 for more consistent versioning with BGTFW & Crio releases.

2.5.2

Bug Fix: Crio - Nested Row #343 Update: Added CSS styles for WedgeV2 update.

2.5.1

Bug Fix: Full width menu background doesn't touch sides [#327] (#327) Bug Fix: Widget in full width header = horizontal scrollbar [#244] (#244) Bug Fix: Full width sidebar background doesn't hit sides on mobile [#229] (#229)

2.5.0

New Feature: Added a 'Crio' top level menu page, moved the welcome page there, and added a 'Get Pro' page to highlight new premium features.
Update: [Snyk] Upgrade @wordpress/hooks from 2.8.0 to 2.10.0 #305
Update: [Snyk] Upgrade jarallax from 1.12.1 to 1.12.4 #304
Update: [Snyk] Upgrade @wordpress/dom-ready from 2.9.0 to 2.11.0 #303
Update: [Snyk] Upgrade @babel/runtime-corejs2 from 7.9.6 to 7.12.1 #302
Update: [Snyk] Fix for 2 vulnerabilities #209

2.4.0

New Feature: Added functionality for Crio Premium's Page Header Templates.

2.2.3

Bug Fix: Crio 2.3.2 & PPB 1.13.3 - Main Text font doesn't pull thru to Editor #272
Bug Fix: Some fonts don't show their name in the font selection dropdown #264
Bug Fix: Restoring a backup loses the stylesheet (all styling) #278

2.2.2

Update: Updated Kirki-Framework to latest stable version.
Update: Updated Google Fonts Sprites and webfonts.json
Update: Updated typography to work with new version of Kirki Framework
Update: Updated to work on WP 5.5+

2.2.1

Bug Fix: Moved Header Background Color control to the Design -> Header -> Background section
Bug fix: Full Width sections do not span the entire header #232
Bug fix: Fixed Background Image doesn't work #193
Bug fix: Incorrect body text color when setting background image effect to "Parallax" #220
Bug fix: Header overlay control should be conditionally visible #89

2.2.0

New Feature: Added Control to change the number of products shown per page on shop catalog #210
New Feature: Added Featured Image Control to single blog posts #192
Bug fix: WooCommerce Container control appears w/o WooCommerce installed #216
Bug fix: Custom Theme JS incorrectly escaping single and double quotes #199
Update: Updated build dependancy sass.js from 0.9.13 to 0.11.1 #196
Update: Updated build dependancy css-var-ponyfill from 1.11.1 to 1.17.2 #195
Update: Updated build dependacy @bable/runtime-corejs2 from 7.4.4 to 7.9.6 #194

2.1.18

Bug fix: Store Notice should be at top of page #39
Bug fix: Required fields in checkout missing asterisk #37
Update: Added container control for WooCommerce Pages #30
Update: Added WooCommerce icon for customizer menu #67

2.1.17

Bug fix: Corrected display of attribution controls when used with Inspirations #187
Update: Adding host_attribution footer control.

2.1.16

Update: Updated WooCommerce Templates.
Bug fix: Sub-menus not displaying in preview after making changes to header in customizer #26
Bug fix: Attribution links not displaying properly on mobile devices #177
Bug fix: Colorpalette click event listener triggering on all sections clicks #23
Bug fix: Column / Row flexbox issues on Safari #25
Bug fix: widget partial refresh causes background image tabs to display all options #156
Bug fix: Second header menu dropdown overlaps text link on mobile #150
Bug fix: WP Editor text-contrast issues in dark palette #40
Bug fix: Class 'Boldgrid_Framework_Activate' does not have a method 'reset' #173
Bug fix: Crio Full Width Footer = Horizontal Scrollbar #149
Bug fix: Video Header with Sticky Header has wrong background color #164
Bug fix: Clicking the Home icon in breadcrumb trail hangs for 5-7 seconds in customizer panels/sections #27
Bug fix: Form styling from wp.org theme preview incomplete #152
Bug fix: header/footer widgets inheriting bootstrap body font #28
Bug fix: Previewing bgtfw based themes fails to load google fonts #155

2.1.15

Bug fix: Directional controls not saving css output correctly.

2.1.14

Bug fix: Reset password field not visible.

2.1.13

Bug fix: Reset row margins to bootstrap defaults, fixes column widths.

2.1.12

Bug fix: mce_external_plugins returning incorrect values. #129
Bug fix: WP 5.3 - Color palette preview fails with js error. #132
Bug fix: Background patterns not displayed if background image is set. #135
Bug fix: Preview of header background videos not displaying. #138
Bug fix: Body background overlay not working if pattern was selected before setting image. #139
Bug fix: Variable styles not applied for when used within Post and Page Builder. #141
Bug fix: Background image setting switches to pattern & color after adding image. #140
Update: Font sprite and webfonts json were updated to match latest font availability. #134

2.1.11

Bug fix: Ensure that the site header is correctly output when settings are updated in customizer. #127
Update: Changed upsell link in customizer. #126

2.1.10

Bug fix: Comment titles on post/pages should not be hidden when post titles are hidden in customizer. #123
Bug fix: Creating new menu in customizer should show only used menu locations. #124
Bug fix: Allow fonts to display in Gutenberg and Classic Editor for proper WYSIWYG. #125

2.1.9

Bug fix: Menu items with mark now respect whitespace. #114
Bug fix: The "No Sidebar" icon is used for customizer controls instead of default "Sidebar Right". #116
Bug fix: Primary sidebar now loads in the Widgets section in customizer. #118
Bug fix: Sidebar icon is now properly positioned. #119
Bug fix: Section title fonts in customizer are now correct. #120
Update: Removed unnecessary loading of FontAwesome from CDN in Kirki. #113
Update: The default for post dates has been set to date format instead of human readable. #115
Update: Removed Crio branding from customizer controls. #117

2.1.8

Update: Minor changes for WPTRT WordPress.org submission.

2.1.7

Bug fix: Pagination "active" class is now properly applied. #109
Bug fix: Removed duplicate panel being displayed in Gutenberg Editor. #108
Bug fix: Ignored CSS transitions on archive pages when printing. #106
Update: Increased tap target size for pagination. #105

2.1.6

Update: Ensure paginate_comments_links is being used where necessary. #92
Update: scssphp package updated to address Theme Check issue.

2.1.5

Bug fix: Fixed issue where sidebars were not dynamically populating in customizer. #47
Bug fix: WP5.2 unitless line-height causing alignment issues for icons in customizer. #88
Bug fix: WooCommerce quantity inputs no longer disabled after ajax cart updates. #34
Bug fix: Fixed partial refresh issue with changing header layouts. #91

2.1.4

New Feature: Users can now toggle on/off the "Scroll To Top" button from the customizer. #78, #79
New Feature: Users can now select different background blend modes for background image overlays in the customizer. #85
Bugfix: Southwest alignment control for branding blocks should now be correctly aligned. #80
Bugfix: Pagination elipses should no longer have hover effects applied. #77
Bugfix: Parallax backgrounds should show up on the frontend site now. #81
Bugfix: Parallax backgrounds should now fill entire screen in customizer. #82
Bugfix: Fixed some issues for select elements not displaying with the correct styles on the frontend site.
Update: Raised minimum PHP version to 5.6.0.
Update: Updated scssphp dep to latest version.
Update: Removed jQuery Stellar library and added Jarallax for a smoother parallax effect and better performance.
Update: Removed limitation of node 10.12.0 - 10.13.0 for build process. #86
Update: Added support for WooCommerce's upcoming new hooks: woocommerce_before_quantity_input_field, and woocommerce_after_quantity_input_field.
Update: Added .form-control and .input-number CSS classes to quantity inputs via woocommerce_quantity_input_classes.

2.1.3

Bugfix: Fixed issue with dynamic imports resolving to incorrect paths.
Update: Removed wp_deregister_style and wp_deregister_script calls for selectWoo.

2.1.2

Bugfix: Added starter content's customizer query for blog posts.
Bugfix: Removed closing div for widget areas in customizer.
Update: Removed source maps for production build.

2.1.1

Bugfix: Addressed various output escaping issues.
Update: Moved translation support from bgtfw to themes.
New Feature: Added new background patterns for customizer.
New Feature: Added styles for Gutenberg buttons.
Update: Removed NinjaForms bootstrap.css overrides.
Update: Switched to MIT licensed animation library, everything works as it did before, including other plugins hooked in.
Update: Updated license to GPL-3.0-or-later.
Update: Removed starter content overrides that aren't allowed in WordPress.org.
Update: Replaced all non-GPL-2.0-or-later compatible images.

2.1.0

Bug fix: Remove font preview in MS edge, helps with performance

2.1.0-rc.2

New Feature: Section links added to customizer for Header/Footer layouts.
Update: Removed composer installation from bgtfw for libraries only used by themes.
Update: WooCommerce compatibility for v3.
Bug fix: Dynamic content areas should wrap rows when more than 6 items are added.
Bug fix: Custom logo control in dynamic layouts is not being hidden.
Bug fix: Sticky Header not being initialized correctly when toggling options in customizer.
Bug fix: Unable to add new section if no sections present in dynamic layouts.
Bug fix: Titlecase BoldGrid and WordPress in attribution controls.
Bug fix: Italic fonts on main typography control overrides menus and widgets fonts.
Bug fix: Tagline needs bottom margin.
Bug fix: Blog page featured images have auto width applied.
Bug fix: Editor not aligning column content in center.
Bug fix: Undefined index for bgtfw configs generated from BoldGrid Inspirations Premium due to removed config.
Bug fix: 404 page containers conflict with container controls.
Bug fix: Add spacing below Post Navigation.
Bug fix: Featured Images aren't able to be hidden on blog page.
Bug fix: Removed hardcoded language strings from JS for widget highlight in customizer for proper translations.

2.1.0-rc.1

Update: Added tabs for dynamic header layout, sticky vs standard.
Update: Allow sticky navigation to have it's own nav locations set.
Update: Moved sticky controls out of standard dynamic header layout controls.
Update: Menus and sidebar location sections are now dynamic based on dynamic controls.
Update: Adding Crio Enzo as icon for admin menu.

2.1.0-alpha.1

New Feature: Adding dynamic layout controls for header/footer.
New Feature: Added base form support with a new style.
Bug fix: Fixed scrolling issues on IE, Safari, and FF in customizer.
Update: Removed controls for enable footer, header/footer containers.
Update: Change radio select controls for header position to buttonset with icons.

2.0.0

New Feature: Layout Selection - Allow users to select between a full width content area or fixed width within the Customizer.
New Feature: Header and Footer Layouts - Multiple header and footer styles, which can be selected from within the Customizer.
New Feature: Background Video Support - Homepage background video for your header from Youtube or Vimeo.
New Feature: Dynamic Content Layout Support - Allow users to select between multiple different blog styles, and change elements such as title, metadata and the overall look and feel with much more precision than ever before.
New Feature: Improved Font Controls - Users now have much more control over the fonts elements independently, allowing granular control of the typography.
New Feature: Improved Color Controls - Users have much more control over the colors individual elements use, to allow for greater customization of their website's look and feel.

1.5.10

Update: Removed reference from bootstrap css to glyphicons since they are unused in bgtfw.

1.5.9

Update: Removing the spinner's arrows from the quantity number inputs.

1.5.8

Update: Added styles for 3.4.0 WooCommerce changes.

1.5.7

Update: Updating WooCommerce templates to latest stable version.

1.5.6

Bug fix: Fixing issue with .site-title line-height conflict from WP4.7 changes.

1.5.5

Update: Change Post and Page Builder url.

1.5.4

Update: Updating version of kirki.

1.5.3

Update: Updating components.

1.5.2

New Feature: Moving component library into it's own package.

1.5.1

Update: Moving sidebar widget area into configuration file.
Update: Provide support for buttons as post navigation.

1.5

Update: Bump version.

1.4.8

Bug fix: Fixing button font sizes.
Bug fix: Append tinymce customizer typography styles instead of prepending.
Update: Updating versions on CSS files.

1.4.7

Bug fix: Adding theme's defined palette class to TinyMCE Editor instances.

1.4.6

Update: Updating component shapes to match image styles.
Update: Loading sticky header JS for mobile.

1.4.5

Update: Changed the default fieldset legend styles added.
Update: Adding new styles to the default components.

1.4.4

Bug fix: Fixed help overlay section in customizer so it's part of the actual controls.
Bug fix: Fixed cases where FS_CHMOD_DIR is an undefined constant with $wp_filesystem.

1.4.3

Update: Link focus should be dynamically found for hide_ links.

1.4.2

Bug fix: Check if template configs are present.
Update: Default menu descriptions are now generic instead of contextual.

1.4.1

Update: Let sidebar search widget have standard appearance on small devices.
Bug fix: Fixing issues with wooCommerce ratings and extraneous div outputting.
Bug fix: Customizer tablet preview not showing tablet size menu.
Update: Add default button styles for wooCommerce support.

1.4.0.1

Bug fix: Adjusting line-height for tinymce editor for WordPress 4.8 changes.

1.4

Bug fix: CTA widget inherits well class if user tries to re-add it.
Bug fix: Added default styles for sidebar search form widgets.

1.3.9

Bug fix: Fixing error when running wp-cli commands.

1.3.8

Update: Set the editor content area to the max width from the theme.
Bug fix: Customizer edit button for edit this page goes to wrong URL.
Bug fix: Staging theme mods being transfered across themes.
Bug fix: Issues compiling colors on upgrade from old themes.
Update: Removing CTA checks from framework.

1.3.7

Update: Attribution links are now using postMessage to avoid customizer refreshes.
New Feature: Custom Modernizr builds are now added to theme framework.
Update: Sticky Footer is now handled with flexbox if browser supports it.
Bug fix: Added markup for password required pages and posts inside sections/containers.
New Feature: Adding body class for disabled bstw state.
Update: Margin applied to contact blocks for better spacing in bgtfw.

1.3.6

Bug fix: Adding .page-template-default to editor if default template is in use.

1.3.5

Update: Allow widget data to be filtered before widgets are created.
Bug fix: weibo icon.

1.3.4

Update: Setting JS compiler instance limit to 50 to accommodate larger sass sheets.
Bug fix: Aligning post navigation links to left and right for older vs newer.
Update: Adding padding to search results.

1.3.3

Bug fix: Merging standard and minified js files.

1.3.2

Bug fix: Hide inline link editor when closing black-studio panel.
Bug fix: Load theme styles only for pages and posts.
Update: Open social media icons in new tab.

1.3.1

Update: Changing post navigation links from H1s to H2s.
Update: Changing format of boldgrid_menus_created option.
Update: Using meaningful keys in boldgrid_widgets_created option.
Bug fix: Fixing issue with bad data in boldgrid_widgets_created.

1.3.0.2

Bug fix: Customizer edit buttons not appearing for menus.
Bug fix: Edit buttons appearing when not in Customizer.

1.3.0.1

Update: Removing custom CSS panel added in WordPress 4.7 Core update.
Update: Removing visible edit buttons added in WordPress 4.7 Core update.
Bug fix: Fixing issue causing fatal Javascript issues in background controls after 4.7 Core update.
Bug fix: Fixing issue with stacked display controls in background section, 4.7.
Bug fix: Fixed issue where help text in menu and widget customizer not visible 4.7.
Bug fix: Fixed errors when viewing a changeset id on the front end: 4.7.

1.3

Update: Prevent Buttons from wrapping.

1.2.11

Update: Added neutral color color classes.

1.2.10

Update: Boldgrid sections now have a min-height of 30px inside site content.
Update: When Home template is used, update disabled page title tooltip message.

1.2.9

Bug fix: Fixing issue compiling staging colors.

1.2.8

Update: Adding additional text contrast classes.
Bug fix: Check colors are enabled and default palette exists before attempting to set palette.
Bug Fix: Home page title causes duplicate H1 tags.
Bug Fix: Enqueue staging buttons and staging colors to the editor control system.

1.2.7

Update: Framework now handles filtering for full width pages.
Bug Fix: Fixing issue with tinymce cache busting.
Bug Fix: Blog page not getting proper containers if set to a static page.

1.2.6

Bug Fix: Fixing issue with sidebar displaying on specific page templates.

1.2.5

Bug Fix: Fixing issue were suggested palettes did not respect the locked color.
Bug Fix: Sidebar widgets should have h2 tags for titles instead of h1.
Bug Fix: Removed Bootstrap button classes from theme buttons.
Update: Removed staging from recommended plugin install list.
New Feature: Added config for BGTFW Version.
Update: If any colors aren't found before compile, don't attempt to compile the scss.
Bug Fix: Attachment pages need container classes.
Update: Only recommending plugins, and updating verbiage to reflect that.

1.2.4

Bug Fix: Fixing issue causing masonry galleries to not display.
Bug Fix: Allow page templates to define the element's container classes.
Bug Fix: Add font family classes to framework.
Bug Fix: Check if function exists before display_sidebar fires.
New Feature: Allow all WordPress conditionals to be used in display_sidebar.
Update: No longer renaming Widgets to Header/Footer Widgets in the customizer.
Bug Fix: Default h1 and h3 font sizes not rendering correctly (not in use on current themes).
New Feature: Adding buttons library for editor.
Bug Fix: TinyMCE triggered by a Ninja Forms hook while editing a form.

1.2.3

New Feature: Added SnapChat social media icons.
Update: Added some default styles to BGTFW components.
Bug Fix: Addressed jQuery Migrate deprecated notice for .load() in edit buttons.
Bug Fix: Add blog container class if user sets front page to display their blog posts.
New Feature: Allow theme activation to trigger recommended/required plugins.
Bug Fix: Palettes with two of same color didn't get unique color class assigned.
Bug Fix: Custom classes push via configs to tagline weren't applied for live preview in customizer.
Bug Fix: Apply comment submit classes via PHP instead of jQuery.
Update: Sass.js updated to v0.9.12.
Bug Fix: Some themes don't have an edit button for footer attribution links.
Bug Fix: Let attribution links bounce on focus with customizer edit buttons.

1.2.2

Bug Fix: Background size not being applied to parallax backgrounds.

1.2.1

Update: Updating color palettes tutorial link.
Bug Fix: Updating the load order of styles into the editor.

1.2

New Feature: Add tutorials link to each section in the menus panel.
New Feature: Adding container configuration classes.
Update: Font Awesome updated to 4.6.3.
Bug Fix: Fixing issue with typography controls 4.4 compatibility.
Bug Fix: Fixing 4.6 bug causing background image previews to not display.
Bug Fix: Hiding generic locations that are not in use.
Bug Fix: Customizer dialog inheriting styles with undesired effects.
Bug Fix: Stop Wordpress from assigning widgets to our areas on theme switch.
Bug Fix: Edit buttons display primary menu background even if no menu is present.

1.1.9

Bug Fix: Typography - additional selectors should be read for showing/hiding menu item.
Bug Fix: Typography - headings/subheadings from configs override each other.

1.1.8

Bug Fix: Edit buttons no longer pull in color from themes.
Bug Fix: Typography in the editor is no longer prefixed with .mce-content-body.
Bug Fix: Removed php closing tag from category.config.php.

1.1.7

Update: Added helper method for Inspirations category lookups.
Bug Fix: On theme activation set default color palette theme_mod.
New Feature: Colors in the active palette now have animations to upon focusing the control.
Bug Fix: Staging theme updates reset color palettes.

1.1.6

New Feature: Updated drag behavior to swap colors.
New Feature: The neutral color of a palette can now be modified with drag and drop.
New Feature: The UI of color palettes has been improved.
New Feature: Colors within a users color palette can now be selected from the color picker.
New Feature: Improved color palette suggestion algorithms.
New Feature: Enabling customizer edit buttons.
Bug Fix: Removed duplicate entries of color palettes from saved palettes.

1.1.5.1

Bug Fix: Enable footer switch not fully triggering.

1.1.5

Update: Kirki from v2.1.0.1 to v2.3.2.
Update: Changed customizer tablet view width to 768px.
New Feature: Added slim scrollbar support via configs.
New Feature: Added scroll to top support via configs.
New Feature: Added support for additional font relationships via configs.
New Feature: Allow child theme to auto-enqueue it's own js file.
New Feature: Updated wow.js to support framework configs.
New Feature: Added blockquote calculations to Main Text font sizes.
Bug Fix: Headings Text Transform property not saving.

1.1.4.1

Bug Fix: Issue causing Visual Editor widget areas to fail on firefox.

1.1.4

Bug Fix: Issue causing color palette customizer to fail on child themes.
New Feature: The frameworks root path can now be overwritten with BGTFW_PATH constant.
New Feature: Text shadow controls are now postMessage.
New Feature: Tagline will now inherit margin controls from site title.
Update: Customizer edit buttons now using pencil icon.

1.1.3

Bug fix: Addressed issue where subheadings weren't having font-family property set.
Bug fix: Inline Links in Visual Editor in Customizer now are working for WP 4.5+.
Misc: Bootstrap-compile now works with SCRIPT_DEBUG set to true.
New Feature: Child theme's will transfer menus from parent on activation.

1.1.2

Hotfix: Disable responsive device previews, and use WP's new responsive previews in WP 4.5+.

1.1.1

New Feature: Child themes can now be created and work properly.
Misc: Replaced Underscore's accessibility classes with Bootstrap's.
New Feature: Added support for using heading classes that work with typography controls.
Misc: Code refactor of activate class.
Misc: Added CodeClimate Configuration.

1.1

Bug fix: Animate.css now can load properly.
Bug fix: Allow child themes to use their own background images.
Misc: Updated scssphp dependency to v.0.6.1.
New Feature: Typography controls now have image previews.
Bug fix: Unique menu names not formatted correctly.
Bug fix: On start over, staging menus are not deleted.
Bug fix: Search results hiding page titles unintentionally.
Misc: Setting default style of menus as inline.

1.0.10

Update: Changing email links to @example.com.
Update: Reorganized advanced footer panel.
Update: Added alt-font to tagline and widgets, and change section title.
Fix: Correcting issues with sticky footer.

1.0.9.2

Fix: Color palettes not working on staging sites.

1.0.9.1

Fix: Attribution links unintentionally hidden from footer.
Fix: zIndex issues with magnified files.

1.0.9

Fix: Preventing titles for showing up when menu title is markup.

1.0.8.3

Update: Moved repo to github.

1.0.8.2

Fix: Updating Kirki to 2.0.9

1.0.8.1

Fix: Fixing Issue with toggling controls

1.0.8

Fix:Enable page title toggle on new pages
Update: Update kirki to v2.0.3
Update: Updating PHP Sass compiler
Update: Updating JS Sass compiler
Fix: Fixing conflict with other plugins that include our PHP compilers

1.0.7.1

New Feature: Adding a page title toggle

1.0.7

Fix: Correcting issues with colors in site previews

1.0.6

New feature: Adding a method to add incline styles to the editor plugins
Fix: Fixing Style issues in the customizer overlay

1.0.5.1

Bug Fix: Fixing issue with sticky Footer in middle of page
Bug Fix: Fixed Post page with comments markup issue

1.0.5

New feature: Save menus created by framework in an option.
Bug Fix: Upon deploying staging, new active site lost Social Media icons.

1.0.4

Bug Fix: Fixed Typos in Advanced Header/Footer Sections
New feature: Adding readme.txt file

1.0.3

Bug Fix: Fixing issues with special thanks links
New feature: Added sticky footer options

boldgrid-theme-framework's People

Contributors

Stargazers

Watchers

Forkers

nicolepaschen jessecowens reswordpress jamesros161 timelsass joe9663 carolinan

boldgrid-theme-framework's Issues

colorpalette click event listener triggers on all section clicks

The colorPalette.bind_help_section_visibility has an event listener registered triggering for every click on .accordion-section. This is causing some performance issues as every registered section has listeners registered here:
https://github.com/BoldGrid/boldgrid-theme-framework/blob/dev/src/assets/js/customizer/color-palette.js#L74

I believe this is for an admin notice/pointer - but I think the listener should only be added for the color palettes expanded state to help reduce some of the memory/cpu consumption which is causing slow performance.

pages need container control

I cannot make my WooCommerce pages full width - they do not respond to page or post container control. Please add a control specific for WooCommerce pages or have them respond to the Page container control.

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on Greenkeeper branches of this repository. 🚨

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please click the 'fix repo' button on account.greenkeeper.io.

Add unit tests

A major setback for the framework is and has been not having solid unit testing being done. I believe at the base level, we at least need to get coverage for phpunit tests across the majority of our codebase. We also need to look at some JS testing, in particular some testing for controls and expected outputs etc.

link color not displayed in gutenberg editor

Describe the bug
link colors not added in gutenberg

To Reproduce
Steps to reproduce the behavior:

Open a page with links in the gutenberg editor.

Expected behavior
The link color should be the same as the front end, but the styles aren't being applied. Hover appears to be applied just not the the default color.

Desktop (please complete the following information):

OS: ubuntu
Browser: chrome/ff

Additional context
wp 5.1

Add toggle for scroll to top in customizer

A toggle to turn off/on the scroll to top arrow functionality in the WordPress customizer would be a nice feature addition.

I think an appropriate place to add this in the customizer would be: "Design > Site Content > Scroll To Top"

This lib is separated out into configs already, so additional controls to handle the many options it has shouldn't be hard to implement. I think for the time being the toggle wouldn't require any adjustments to the library that handles the functionality, but in the future I'd like to add some icon selection, alignment, and color selection options and think we would rewrite this library to use our own implementation and get rid of the third-party dep.

col/row flexbox issues when using safari 12

When using safari 12 the columns seem to be slightly larger than the row and wrap to new lines:

quantity input disabled after cart update

I have an item in my cart. When I change the quantity to 4 and click Update Cart, when the page reloads the minus button isn’t clickable until I click the plus button.

replace icon-newpage.png with dashicons-external

For resource documentation, I couldn't track down icon-newpage.png without asking a bunch of people where they got it from since it's used internally in other applications:

After looking at the image itself, we can just replace this with dashicons-external to avoid doing all that other stuff.

Required fields in checkout missing asterisk

Customizer > WooCommerce > Checkout
I have ‘Highlight required fields with an asterisk’ checked but the asterisks do not show on the page.

Load scripts via webpack

As we've implemented webpack in v2 of the framework, I think it would be a good next step to look into creating a manifest for assets, and autoloading them in the framework. This would help reduce some of the enqueue's and reduce some of the overhead in various classes that add scripts/register scripts etc.

customizer sections/panels/icons display

Describe the bug
After changing display for customizer icons in sections/panels and the associated headings, they are all wonky. A lot of css was removed and stable, but things aren't stable as there have been many changes since then. The css for this needs to be reevaluated, and perhaps further reduced. Previous selectors were causing some performance impacts as they were chaining together several attribute contains word and attribute contains substring selectors. Reduction has helped a bit in the transition between panels/sections, but the display of these need to be adjusted, and icons need to be "normalized". There's 3 types of icons currently, dashicons, bgtfw icons, and fontawesome - all of which has slightly different positioning/sizing to look out for.

To Reproduce
Steps to reproduce the behavior:

go to customizer, switch through various panels/sections - some of the title sections are too small, and some of the panel/section selections are too short.

Expected behavior
These should all be displayed as intended by wp

Desktop (please complete the following information):

OS: ubuntu
Browser chrome/ff/ie/safari

Additional context
wp 5.0, wp 5.1

Bug: Parallax for Site Background

Describe the bug
When the parallax option is set for the Site Background in the Customizer it disables the parallax from working on any boldgrid-section configured in the page content. Using Scroll or Fixed on Site Background does not produce this bug.

To Reproduce
Steps to reproduce the behavior:

Go to the Site Background settings in the Customizer
Configure an image background with the parallax option
Edit a page and set a parallax background for a section in the visual editor
View the page from the front end
The background for the section will scroll with the content and will not have the parallax behavior.

Expected behavior
Parallax backgrounds in the page content should function regardless of the Site Background settings.

Desktop:

OS: Fedora 28
Browser: Firefox, Chromium

Add autoloading

Now that we don't have focus on php 5.2+ and require php 5.4+ we can take advantage of composer and/or using an autoloader. This could help with some of the performance hits currently from loading everything when the framework is instantiated.

Add browserstack image and link for repo

For browserstack support we need to add the image and link to their website and let others know we use them for browser testing coverage.

header/footer widgets inheriting bootstrap body font

It appears that header/footer sections are inheriting the font style declared by bootstrap.css. These areas should inherit the customizer control for "Main Text", so that the user is able to change these.

Additional Information:
BGTFW: 2.1.0
WP: 4.9.8
Tested in: Chrome/FF/Edge

Clicking the Home icon in breadcrumb trail hangs for 5-7 seconds in customizer panels/sections

When clicking on the various Home icons in the customizer, there is a noticeable delay before being moved to the main location after clicking on the icon:

Additional information:
BGTFW: v2.1.0
WP: 4.9.8
Tested in: Chrome/FF/Edge

Advanced keyboard nav support

by default smartmenus is keyboard accessible, and follows accessibility standards. They do provide an additional plugin which enhances keyboard support and brings alternative navigation patterns into the menu, such as arrow keys. I think for accessibility focus this would be a good improvement. Some details available here for reference: https://www.smartmenus.org/blog/smartmenus/advanced-keyboard-navigation-and-v0-9-4/

WP Editor text-contrast issues in dark palette

I am using Crio 2.1
When I have the site background set to a dark color, the 'Set featured image' button and the Page Attributes dropdown are not legible.

Widget Areas in customizer not dynamically populating

Describe the bug
In the customizer's dynamic header/footer areas, the widget areas added don't appear when adding new ones if you have no thememods set.

To Reproduce
Steps to reproduce the behavior:

Clear thememods for a bgtfw based theme, such as https://github.com/BoldGrid/prime
Go to customizer > Design > Footer > Layout
Add a widget area to a section.
Expand the widget area added, and click on button to go to "Edit Sidebar" for that area.

The result is that the button doesn't take you to the widget area's controls because the control doesn't exist.

Expected behavior
The widget area should exist for dynamically created area.

Note: Possibly related to overriding the render_content method in the parent class. I don't recall this happening before that change.

Desktop (please complete the following information):

OS: Version 70.0.3538.77 (Official Build) (64-bit)
Browser: Chrome
Version 70.0.3538.77 (Official Build) (64-bit)

Additional context
WordPress 5.1

add woocommerce icon for customizer menu

when wooCommerce is installed, they add their own customizer controls. I'd like to see their icon added to the control so it fits the existing interface choices of all sections/panels having their own icons.

In looking into it, it appears they have an icon font included, so we could use something along the following with their import of the fontface (or enqueue whatever file) & style customizer script:

@charset "UTF-8";@font-face {
    font-family: star;
    src: url(../fonts/star.eot);
    src: url(../fonts/star.eot?#iefix) format("embedded-opentype"),url(../fonts/star.woff) format("woff"),url(../fonts/star.ttf) format("truetype"),url(../fonts/star.svg#star) format("svg");
    font-weight: 400;
    font-style: normal
}

@font-face {
    font-family: WooCommerce;
    src: url(../fonts/WooCommerce.eot);
    src: url(../fonts/WooCommerce.eot?#iefix) format("embedded-opentype"),url(../fonts/WooCommerce.woff) format("woff"),url(../fonts/WooCommerce.ttf) format("truetype"),url(../fonts/WooCommerce.svg#WooCommerce) format("svg");
    font-weight: 400;
    font-style: normal
}

#customizer-section-id? {
    font-family: WooCommerce;
    content: '\e03d';
}

Crio menu background isn't full width when set to full width

Describe the bug
The menu background color does not touch the sides of screen when container is set to Full Width with Crio.

To Reproduce

Activate Crio
Make a header layout with a menu in a Full Width container
Add a background color to the menu
The color does not touch the sides of the screen.

Expected behavior
I expect the color to hit the sides of the screen - be truly full width.
If I remove the left/right padding on the column it looks as expected.

Screenshots

Color help pointer not displayed

Describe the bug
The color palette help is not displayed

To Reproduce
Steps to reproduce the behavior:

Reset help pointers
Go to color palette tool in customizer
Help pointer does not display

Expected behavior
Color Palette help should display

Desktop (please complete the following information):

OS: Windows 10
Browser: chrome
Version: 72

webpack runtime paths incorrect

Going through testing, I noticed that currently the build paths for webpack requires are resolved to the path for /wp-content/themes/prime/inc/boldgrid-theme-framework/. I had added this path in order to resolve imports for patterns, but the issue is/was preexisting just a different path was resolved before. This hasn't caused any conflicts since we switched to webpack because we are generating the output on build, then enqueue them through WP when they are used. All the imports from the entry point where they are enqueued from are resolved relatively to that location, but dynamic imports will look for public paths, __webpack_publicpath__ or runtime paths, __webpack_require__.p. We sometimes run bgtfw from outside of theme directories via defining the constant in PHP, which changes the paths needed to resolve, and during build time, we are building from the directory we install bgtfw to, which we had path.resolve() calls to ensure successful builds. These all result in the wrong paths needed for resolution.

Steps to replicate:

Take the current build and put it in a theme called test.
Remove any other themes which may have BGTFW installed.
Go to customizer > background > images & patterns.

The result is that you will get a console error, and the pattern import will fail and no patterns are shown, just boxes with the current color selected.

Note: the latest .zip release provided on Friday, I did a find & replace to change the resolution paths in the final build, so the dist copy works as intended. This isn't a resolution though as we need the paths to be correct at runtime, so no part of our build process can accurately change them until bgtfw is being implemented wherever that may be. It's possible as a quick fix that build scripts are added in the themes to find replace for theme releases, but I think I'll figure out something a bit more flexible as we wouldn't want someone developing against BGTFW to have a requirement of running a find and replace on a dep. Similar issues happen with create-react-app and other various deps who want the runtime to be dynamically determined. I don't think it will be much work to fix this.

Generate RTL styles

Currently our CSS is split up into various parts, and during the build process we don't have any transforms added to create RTL styles. We should look at consolidating some of this CSS, and also look into piping through something like postcss to create RTL styles. Themes would then be able to be tagged as having support for this.

No notice given if vendor folder is missing

I suggest a notice be thrown if the vendor folder is missing because the developer did not run composer.

Store Notice should be at top of page

Right now the Store Notice appears at the bottom of the page - it should be at the top. Header Top position.

Split out control deps

As the framework has grown, it's become clear that we need to begin splitting out our components into their own contained repos. With our controls, we have several intertwined deps, such as Kirki, our own framework/custom controls, and our js controls lib. A good goal to help make this more maintainable as the future of the customizer/WordPress changes to become more JS driven would be to embrace our own controls lib more, and perhaps look at rendering the controls using react as that's what core will be using. This would also allow us to leverage controls available within the editor(gutenberg), so users would have a more consistent interface when working with their sites. This would also give us an opportunity to focus a bit more on controls, and untangling some of the interrelated logic of the previewer, controls, previews and come up with a unified method that is optimized for frontend output as well. We use a variety of different methods at the moment, and it becomes a burden trying to figure out which pieces might conflict with others. while making changes.

reinit smartmenus on customizer partial refreshes of dynamic layout sections

"Nested menu in sticky navigation looses its dropdown indicator and the actual dropdown menu when changing the location of the menu using the Alignment control. Page refresh corrects it."

It seems like the menus aren't being initialized/destroyed properly when the locations are dynamically added/removed.

Firefox Console provided this error:

Add edit button to scroll to top arrow in customizer preview

This is related to #78 where a toggle was introduced for the scroll to top arrow functionality for a site. To help address usability it was suggested to add a customizer edit button to the scroll to top arrow in the customizer preview, so users can easily turn it on/off.

Update BGTFW license for compatibility with included libraries

BGTFW should be licensed under GPLv3 instead of GPLv2. See BoldGrid/prime#26 for further information.

header images not visible

Describe the bug
If you add a custom header image, the image is not visible on the frontend.

To Reproduce
Steps to reproduce the behavior:

go to customizer, and add a header background image.
save and publish.
view homepage on front end. The image does not appear.

Expected behavior
I expect the header image to visible.

Customizer southwest alignment misaligned

When selecting southwest alignment, content is aligned east:

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on Greenkeeper branches of this repository. 🚨

Switch to gulp4

Gulp4 has been out for a while, and addresses some of the shortcomings of gulp3. We use gulp as a taskrunner, and we should upgrade to the latest version so we can keep our deps up to date. Ideally I would like to be able to move from gulp altogether, but I think this would be a good preliminary step where we can re-evaluate some of the build processes happening, and optimize certain portions/pull out others into an alternative workflow.

page/post titles not displayed since removal to premium

Describe the bug
The page and post titles do not display since controls were removed into premium.

To Reproduce
Steps to reproduce the behavior:

Activate a theme using bgtfw, like prime.
view any page/post with thememods cleared.

Expected behavior
Page and post title should be displayed.

Desktop (please complete the following information):

OS: ubuntu
Browser chrome/ff
Version: latest

Additional context
wp 5.1, wp 5.0

Customizer background overlay effects

Add background overlay effects for background images in customizer.

Given increased browser support of background blend modes, I think a nice feature would be to add different background blend mode effects for background image overlays in the customizer to give a little more diversity.

Parallax background doesn’t fill screen if not auto

When Parallax is selected, and any background image size isn't set to auto, then there is a gap at the bottom of the screen because the offset is not calculated correctly:

fresh_site install doesn't apply link color to footer links

It looks like an install with get_option( 'fresh_site' ) === 1 doesn't apply footer link colors to the attribution areas. I believe the classes just need to be added to the filters for that block, but I'm not 100% sure on that off the top of my head.

Integrate color palette with Gutenberg palettes

We should have our color palettes integrated with the Gutenberg editor palette via add_theme_support and updating it based on the user's active palette. This would provide tighter integration of site content colors with the overall color palette selected in the theme.

breadcrumb elipses should not have hover effect applied

On hovering on the ellipsis in pagination, the ellipsis has a hover state like the links to pages:

Expected behavior
The ellipsis should not have a hover state applied, and remain the same visually when a user hovers over it.

jquery stellar not loaded on frontend

When enabling jQuery Stellar in the customizer, the script is not loaded on the frontend after saving and publishing the site, so the effects are not seen for background images.

Update display of page title control in editor

Since the free version doesn't have a global page title control, we're going to hide the option within the editor.

Add responsive font controls

Is your feature request related to a problem? Please describe.
Some Headings are too large when viewed on a mobile screen and there is no option to set specific font sizes for various devices.

Describe the solution you'd like
Add controls in the Customizer to allow for site wide defaults to control fonts across the range of devices.

Describe alternatives you've considered
Currently you need to use custom CSS code to address these display problems.

add responsive oembeds

In exploration of other themes, and ideas for a better experience for users -- it seems like responsive ombeds are a nice feature to have. One implementation I ran across was https://github.com/Automattic/jetpack/blob/7.1.1/modules/theme-tools/responsive-videos.php/#L102 - which might be something worth implementing within the theme framework.

add remaining removed control defaults to new theme_mods config array

Initially most controls didn't exist in previous versions, and as a measure to counteract some of the "missing" theme_mods during the transition periods for testers - additional CSS has been added to adjust for certain things missing and still displaying without any mod correctly. For the most part this has worked out, but there are a couple of small alignments and color configurations that I think need to be moved into @rramo012 's implementation in the theme_mod array for the configs. I believe doing this should resolve the slight discrepancies, and also help ensure seamless upgrade/downgrades without users having certain settings disappear unintentionally.

undefined index body_class

v1 themes have php notice when entering editor in WP 5.1.1(Gutenberg):

Undefined index: body_class in /srv/www/wordpress-two/public_html/wp-content/boldgrid/boldgrid-theme-framework/boldgrid-theme-framework/includes/class-boldgrid-framework-editor.php on line 279.

Bug Report: 'Go There Now' button in Customizer navigation problems

Describe the bug
Clicking the Edit icon in the Customizer for elements contained in page content displays the 'Go There Now' button as expected. However, the button does not navigate to the Page Editing interface as expected.

To Reproduce
Steps to reproduce the behavior:

Open the Customizer in any V1 theme.
Click on the Edit icon for page content elements.
See the popup containing the 'Go There Now' button directing the user to the page editing interface.
Click the button.
User is not redirected as expected.

Expected behavior
User should be taken to the page editing interface.

Screenshots

Desktop (please complete the following information):

OS: Fedora 29
Browser: Firefox
Version: 64.0.1

Additional context
This behavior was replicated in Cloud WordPress and on a VPS.

Console also showed this error:

Unsafe JavaScript attempt to initiate navigation for frame with URL 'https://demo2.boldgrid.com/trial-63y0w8z9/wp-admin/customize.php?return=https://demo2.boldgrid.com/trial-63y0w8z9/wp-admin/' from frame with URL 'https://demo2.boldgrid.com/trial-63y0w8z9/?customize_changeset_uuid=a37b7120-a6ec-4066-89e5-1785c545c268&customize_theme=boldgrid-swifty&customize_messenger_channel=preview-0&customize_autosaved=on'. The frame attempting navigation of the top-level window is sandboxed, but the flag of 'allow-top-navigation' or 'allow-top-navigation-by-user-activation' is not set.
Uncaught DOMException: Failed to set the 'href' property on 'Location': The current window does not have permission to navigate the target frame to 'https://demo2.boldgrid.com/trial-63y0w8z9/wp-admin/post.php?post=17&action=edit'.
at HTMLDivElement.d.buttons.(anonymous function) (https://demo2.boldgrid.com/trial-63y0w8z9/wp-content/themes/boldgrid-swifty/inc/boldgrid-theme-framework/assets/js/customizer/edit.min.js?ver=1.2.2:1:1902)
at HTMLButtonElement.d.click (https://demo2.boldgrid.com/trial-63y0w8z9/wp-includes/js/jquery/ui/dialog.min.js?ver=1.11.4:11:6517)
at HTMLButtonElement.dispatch (https://demo2.boldgrid.com/trial-63y0w8z9/wp-includes/js/jquery/jquery.js?ver=1.12.4:3:12444)
at HTMLButtonElement.r.handle (https://demo2.boldgrid.com/trial-63y0w8z9/wp-includes/js/jquery/jquery.js?ver=1.12.4:3:9173)
d.buttons.(anonymous function) @ edit.min.js?ver=1.2.2:1
d.click @ dialog.min.js?ver=1.11.4:11
dispatch @ jquery.js?ver=1.12.4:3
r.handle @ jquery.js?ver=1.12.4:3

Accessibility and Accessibility testing

One thing we don't do across all of our plugins and themes is coverage of accessibility. This is a pretty important part, especially given the statistics of user who use assistive technology.

One test suite that is worth exploring is AXE, which I have installed the chrome extension to see some of the information and results I could get from it. It does some pretty good general testing, and also provides details on how to fix issues. I think integrating AXE testing in an automated fashion can be done effectively as well.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.