boolfly / product-label Goto Github PK

Version: 1.0.2
Steps:

1. Type: SALE
2. Store view: Default
3. Customer groups: All
4. Dates: 16/11/2020 - 30/11/2020
5. Product Listing: Yes, Top-Right, Text: "SALE"
6. Product Page: Yes, Top-Right, Text: "SALE"
7. SAVE -> Error:

==> var/log/debug.log <==
[2020-11-17 07:32:47] main.ERROR: DateTime::__construct(): Failed to parse time string (16/11/2020) at position 0 (1): Unexpected character [] []

In Magento 2.4.5-p1 there is an issue in admin grid on click of Add Rule and Admin grid is not showing the correct grid data.

Issue 1 error : Deprecated Functionality: stripos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /var/www/html/pdc/vendor/magento/module-price-permissions/Observer/AdminhtmlBlockHtmlBeforeObserver.php on line 125
Exception in /var/www/html/pdc/vendor/magento/framework/App/ErrorHandler.php:62

Issue 2 error

:

Hi,

This is more a question or a feature request: is it possible to create a rule to automatically add the labels to either NEW products (news from/to attribute set) or products IN SALE (which have an active special price).

Thanks

Hi,

we created a new Product Label rule. After that if we want to edit, there's only this text displayed in Rule Manager:

Not registered handle boolfly_label_rule_listing_data_source

Under Boolfly icon there's nothing available as well.

Hello @mrkhoa99 ,

Hope you are doing good, We are using the EE 2.4.0 and the issue we are having is when we use the condition for attribute sku with any condition the data saving in the boolfly_productlabel_product_index_rule table is using the product row_id and not the entity_id.
Is that possible to fix this issue and use entity_id instead ?

Below is the fix and to be applied on the function used in below files
boolfly/module-product-label/Helper/Rule.php
boolfly/module-product-label/Model/Condition/Sql/Builder.php
boolfly/module-product-label/Model/Indexer/Full.php
boolfly/module-product-label/Model/Indexer/Row.php

private function getProductIdentifierField()
    {
        if ($this->productEntityIdentifierField === null) {
            $this->productEntityIdentifierField = $this->getMetadataPool()
                ->getMetadata(ProductInterface::class)
                ->getIdentifierField();
        }
        return $this->productEntityIdentifierField;
    }

Kindly let me know in case you want me to create a commit instead if I find something

Hi,

First of all, thanks for this module. However, it is not possible to install it:

• It depends on boolfly/base module, which is not available anywhere
• composer install is not possible either (not released version and dependencies not available)

May I ask if you're planning to fix this?

Thanks!

after save the rule i got these error

SQLSTATE[42S02]: Base table or view not found: 1146 Table '.boolfly_productlabel_product_index_rule' doesn't exist, query was: DELETE FROM boolfly_productlabel_product_index_rule WHERE (rule_id = '5')1 exception(s):