Giter VIP home page Giter VIP logo

adobexd-maps's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

adobexd-maps's Issues

Map style

Feature request: Ability to tweak the style of the map.

  1. Would be nice to be able to generate the map without a location pin. I (and I assume many other designers) like to design the location pin myself.
  2. Be able to style the map. I.e. by pasting JSON style like you can do on Google Maps style wizard: https://mapstyle.withgoogle.com/

Run without selection and other improvements

Hey there! I'm a designer on the XD team at Adobe and an avid fan of maps of all types โ€” so I love your plugin! I have some feedback.

  • I would love to be able to run this plugin without any selection. Perhaps it would just paste onto the canvas at a reasonable size.
  • I think you could do without the success message. Only if there is an error do you need to show another dialog after running the plugin.
  • Would be nice to have images with an example city to show what the zoom levels look like.
  • Lastly, retaining the settings of the last time the plugin was run would be handy!

I made a mockup with some design tweaks:
image

I recommend putting the check box before a string instead of after.
Here's the asset for the zoom level examples if you'd like to use it:
image

EDIT: One more thing! Would also be awesome to see/select the map type with examples.
image

Plugin Failure Bug

I would thing "${req.status}" is not a good error for the user, it should return rather it has an authentication problem or not to show that its an API key issue,

function xhrBinary(url) { return new Promise((resolve, reject) => { const req = new XMLHttpRequest(); console.log(getApiKey()); console.log(url); req.onload = () => { if (req.status === 200) { try { const arr = new Uint8Array(req.response); resolve(arr); } catch (err) { reject('Couldnt parse response.'+err.message+','+req.response); } } else { reject('Request had an error:'+ req.status); } } req.onerror = function() { reject('Network Request failed. Please ensure you have internet connectivitiy.'); }; req.onabort = reject; req.open('GET', url, true); req.responseType = "arraybuffer"; req.send(); }); }

I think the fix should be something like this , it will prevent other non developers and non authors from spinning wheels

Test plan for version 1.2.0

  • Check whether Esc and Cancel button closes the dialog
  • Check whether error is given on no selection
  • Check whether rectangle is filled correctly
  • Check whether ellipse is filled correctly
  • Check whether path is filled correctly
  • Check whether polygon is filled correctly
  • Check whether boolean group is filled correctly
  • Check whether multiple layers selection is filled correctly
  • Check whether error is given for other types of layers except rectangle, ellipse, path and boolean group
  • Check whether Location field works correctly
  • Check whether Zoom level works correctly
  • Check whether Map Type works correctly
  • Check whether Location Pin works correctly
  • Check whether Style works correctly
  • Check whether error is given on no internet connection
  • Check whether the input values are retained in a session
  • Check whether the Done message is shown only when a unsupported layer is selected

Need feedback regarding the plugin usage

Hi All,

I was contacted by Adobe to provide some content for a blog post featuring this plugin.

Any examples of real users we can mention or get quote for testimonial would be an added bonus, but not mandatory? How much time did they save? How it helped them on a deliverable.. etc.. The narrative should match the theme here. Maybe you also have some unique ideas on what you would like to convey here.

So can anyone, if you find the plugin useful, give some feedback on using it? Any feedback is appreciated ๐Ÿ™‚

Tagging the stargazers of this repo, @1adangb @masa-sumimoto @tomlschmidt @HaninFhd @danielblom @ashryanbeats @PaoloBiagini . Sorry for spamming. I don't know how to reach out to the users ๐Ÿ˜ž

Test Plan for Version 1.1.0

  • Check whether Esc and Cancel button closes the dialog
  • Check whether error is given on no selection
  • Check whether rectangle is filled correctly
  • Check whether ellipse is filled correctly
  • Check whether path is filled correctly
  • Check whether boolean group is filled correctly
  • Check whether multiple layers selection is filled correctly
  • Check whether error is given for other types of layers except rectangle, ellipse, path and boolean group
  • Check whether Location field works correctly
  • Check whether Zoom level works correctly
  • Check whether Map Type works correctly
  • Check whether Location Pin works correctly
  • Check whether Style works correctly
  • Check whether error is given on no internet connection

Plug-in not found

I have the plug-in installed but have been getting the "Request had an error" error. >Tried to re-install it, but now I get the plug-in not found in the Plug-in Tabs in XD when I tried to do it.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.