boris-em / colorkit Goto Github PK

I think this might be a bug? Here's my code.

let greenComp:UIColor = UIColor.green.complementaryColor //works let greenCompComp:UIColor = greenComp.complimentaryColor //error: value of type 'UIColor' has no member 'complimentaryColor'

I know that UIColor does have member complimentaryColor cause it just used it in line 1. Not sure if I did something wrong.

Properties .red, .green, .blue is in conflict with standard static properties .red, .green, .blue when I add project as the folde

Generating color histograms out of images.

Here is some good resource from OpenCV as to what type of histogram we could generate as well as how to represent them.

A useful feature for accessibility is to be able to attach a readable color name to UIColor instances.
For example UIColor.red or UIColor(red: 1.0, green: 0.0, blue: 0.0) should read something like "red".

A trivial implementation of this could be to work with a predefined color palette and just compare it to the colors using the existing deltaE.

Hey, first of all thanks for this amazing, impressive library.

I'd like to report that when using .kMeansClustering algorithm, I often get a crash from unwrapping nil value.
It happens at line 112 in file ColorPalette.swift

The image I'm feeding to the algorithm is a transparent PNG (an asset file) so that's probably the cause of it. I know it doesn't make sense to pull colors from such image but the code should fail gracefully in such cases.

Hey!
Found a bug for the following function:

extension UIImage {
 func getDominantColors(with minCount: Int = 0) -> [UIColor]? {
        var resultColors: [UIColor]?
        // Try With PNG Data
        if let pngData = pngData(),
           let pngImage = UIImage(data: pngData),
           let colors = try? pngImage.dominantColors(with: .best, algorithm: .iterative) {
            if colors.count >= minCount {
                return colors
            } else {
                resultColors = colors
            }
        }
        // Try With JPEG Data
        if let jpegData = jpegData(compressionQuality: 1),
           let jpegImage = UIImage(data: jpegData),
           let colors = try? jpegImage.dominantColors(with: .best, algorithm: .iterative) {
            if colors.count >= minCount {
                return colors
            } else {
                resultColors = colors
            }
        }
        // Try With Original Image
        if let colors = try? dominantColors(with: .best, algorithm: .iterative) {
            if colors.count >= minCount {
                return colors
            } else {
                resultColors = colors
            }
        }
        if let colors = try? dominantColors() {
            if colors.count >= minCount {
                return colors
            } else {
                resultColors = colors
            }
        }
        return resultColors
    }
}

When the following image is added as input parameter, crash inside ColorKit happened:

Via #10, we introduced a new function called name() that gives the English name of a UIColor instance.

Localizing those names makes sense as a next step.

I'm testing my app with the iOS 17 public beta and I get totally unexpected dominant colors, whereas on my device with iOS 16 I still see them fine.
It could be a bug of the beta but it could also be that there's something fundamentally different in UIImage now. Can you guys check that?

First of all, thanks for this great package! I would love to use it on macOS as well but noticed that it only supports iOS. Are there any plans to make this work for macOS (and/or tvOS) too?

For those who can't use swift package manager it would be really handy if this great library will be available from cocoapods.

When trying to fetch dominant colors from some images an exception is raised.

File: DominantColors.swift line 159

This is the image that's causing crash

In my code I just called the dominantColors() method with default arguments.

I'm using this function on each image of a video feed, and after a few seconds/tens of second, my program stops with this error, EXC_BAD_ACCESS (code=1, address=0xd833deece4d0). I assume it comes from this function and precisely kMeansClustering, because I don't encounter this issue using .iterative algorithm

Calculating things like Analogous Color or Tetradic Color could be useful.
See https://www.sessions.edu/color-calculator/ for more.

When importing ColorKit SwiftUI can’t find Color anymore …
Will provide detailed error logs soon ..

Hi!
CIEDE2000 Shows on the comparison options bug isn't implemented.
Is there a reason it wasn't implemented? How hard would it be?

Hello,

first of all I wanted to say thank you for this awesome kit.

I'm using ColorKit to generate a color palette of pictures that I manually add from my photo library. Everything work good but I only have problems with pictures of my library that were not taken with my iPhone.

If I want to get the colors of pictures taken with my iPhone or a screenshot which was taken with my iPhone the function .dominantColors does not work.

Is it a format thing? or maybe I missed something.

If I send the picture per WhatsApp and then I download the same picture I can get the colors but not from the original. Photos taken with an external camera and then imported to the iPhone have also no problem at all. Only Iphone photos.

I appreciate your help, thank you very much!

Pablo.

UPDATE
I think that the problem is that ColorKit can't use .dominantColors() with pictures taken with the iPhone because they are HEIF/HEIC files. I still can't solve the problem but I'm trying to convert the image to JPEG. I don't know if that is useful because I thought UIImage also supports HEIF format.